<AWT Dev> splashscreen.so is missing pnggccrd.c

Martin Buchholz martinrb at google.com
Fri Aug 29 10:36:45 PDT 2008

Hi Anthony,

On Fri, Aug 29, 2008 at 3:30 AM, Anthony Petrov <Anthony.Petrov at sun.com> wrote:
> Hi Martin,
> The AWT folks think we need to guard this CPPFLAGS setting with the
> following condition:
> ifneq ($(PLATFORM), windows)
> ...
> endif

I am certain this would "work" for everyone, but ...
I am a perfectionist and I am also quite certain that it is wrong.
But if you insist, it's OK.

> We don't use gcc on Windows, and everything works just fine with MS VS.

"We" are now a community of folks with different platforms in mind.
People will want to use gcc on Windows.

> Please feel free to submit the patch with this change, and please add
> OpenJDK user 'art' to the reviewers list. Given this modification applied,
> I'm approving the fix. The push is going to be performed by Artem (CC'ed).
> Thanks in advance!

Again, sorry to be contrary, but I am an OpenJDK committer,
and I would prefer to do hg pushes myself,
for "community development" reasons.
I propose to push these changes to jdk7/awt-gate/jdk

It appears that currently every changeset needs a unique bugid,
so a new bug would have to be filed.  Anthony, could you take care of this?



More information about the awt-dev mailing list