<AWT Dev> Reviewer needed - fix for regression test java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest

Dr Andrew John Hughes ahughes at redhat.com
Fri Dec 3 17:47:15 PST 2010

On 10:04 Fri 03 Dec     , Joe Darcy wrote:
> Anthony Petrov wrote:
> > On 12/3/2010 5:35 PM, Dr Andrew John Hughes wrote:
> >> The patch is heavily reliant on:
> >>
> >> 6797195: Forward-port enhancements for hw/lw mixing from 6u12 to 7
> >> Reviewed-by: art, dcherepanov
> >> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f36e9200cb85
> >>
> >> So is it ok if I bring this one over to OpenJDK6 too?
> >
> > I'm fine with this one as well.
> >
> Same here.
> -Joe

Thanks.  Seems there's a stack of dependencies here :-(

4993545: NativeInLightFixer adds asynchronousity
Summary: All the hooks related to the NativeInLightFixer have been moved
to the HW/LW mixing handling methods. The NativeInLightFixer itself has been removed.
Reviewed-by: son, alexp

6682046: Mixing code does not always recalculate shapes correctly when resizing components
Summary: The valid property is now encapsulated in Component.
Reviewed-by: art

These introduce some methods which are then patched by 6797195.
Should I backport this first or just skip those methods in
applying 6797195?  4993545 seems to be a code cleanup, and
6682046 a bug fix to my eyes, but I'm no expert on AWT code.
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

More information about the awt-dev mailing list