<AWT Dev> A change about the include header file of sun/awt/medialib/mlib_types.h

Artem Ananiev artem.ananiev at oracle.com
Wed Dec 7 07:12:33 PST 2011


Hi, Charles,

On 11/15/2011 5:36 AM, Charles Lee wrote:
> On 11/14/2011 11:14 PM, Artem Ananiev wrote:
>>
>> (Copying to 2d-dev as mblib is a Java2D area)
>>
>> On 11/14/2011 9:59 AM, Charles Lee wrote:
>>> Hi guys,
>>>
>>> I'd like to propose a change in mlib_types.h, it looks loke:
>>>
>>> -#if defined(__linux__)
>>> -#include <stdint.h> /* for uintptr_t */
>>> -#include <malloc.h> /* for ptrdiff_t */
>>> -#else
>>> -#include <link.h> /* for uintptr_t */
>>> -#include <stddef.h> /* for ptrdiff_t */
>>> -#endif /* __linux__ */
>>> +#include <stdint.h>
>>> +#include <stddef.h>
>>>
>>> The patch is mainly about using POSIX complaint headers to get rid of
>>> the if/else define.
>>>
>>> I have check uintptr_t on the solaris 11 express. It will be included in
>>> stdint.h. And my ubuntu works where which malloc.h changed to stddef.h.
>>
>> Does it still compile on Solaris 10? MacOSX?
>>
>>> Would anyone like to take a look at this?
>>
>> Thanks,
>>
>> Artem
>>
> Hi Artem,
>
> I am sorry I do not have a Mac on the hand (too expensive :-)

I've checked that including <stdint.h> and <stddef.h> is enough to 
resolve uintptr_t and ptrdiff_t on Solaris 10 and Mac OS X 10.6 (don't 
think that 10.7 is different), so your change looks fine.

Thanks,

Artem



More information about the awt-dev mailing list