<AWT Dev> JDK 8 code review request for javadoc fix to java.aw.Toolkit

Rémi Forax forax at univ-mlv.fr
Tue Jun 14 10:24:41 PDT 2011


Hi Joe,
the last line of the patch should use link and not code.

Rémi

On 06/14/2011 07:10 PM, Joe Darcy wrote:
> Hello.
>
> There are a few javadoc warnings from java.awt.Toolkit when doing a 
> build.
>
> Please review this patch to fix the warnings for JDK 8.  If this look 
> goods, I'll file a bug and push the fix.
>
> Thanks,
>
> -Joe
>
> diff --git a/src/share/classes/java/awt/Toolkit.java 
> b/src/share/classes/java/awt/Toolkit.java
> --- a/src/share/classes/java/awt/Toolkit.java
> +++ b/src/share/classes/java/awt/Toolkit.java
> @@ -1857,7 +1857,7 @@
>
>     /**
>      * Adds the specified property change listener for the named desktop
> -     * property. When a {@link PropertyChangeListenerProxy} object is 
> added,
> +     * property. When a {@link java.beans.PropertyChangeListenerProxy 
> PropertyChangeListenerProxy} object is added,
>      * its property name is ignored, and the wrapped listener is added.
>      * If {@code name} is {@code null} or {@code pcl} is {@code null},
>      * no exception is thrown and no action is performed.
> @@ -1874,7 +1874,7 @@
>
>     /**
>      * Removes the specified property change listener for the named
> -     * desktop property. When a {@link PropertyChangeListenerProxy} 
> object
> +     * desktop property. When a {@link 
> java.beans.PropertyChangeListenerProxy PropertyChangeListenerProxy} 
> object
>      * is removed, its property name is ignored, and
>      * the wrapped listener is removed.
>      * If {@code name} is {@code null} or {@code pcl} is {@code null},
> @@ -1896,8 +1896,8 @@
>      * contains {@code PropertyChangeListenerProxy} objects
>      * that associate listeners with the names of desktop properties.
>      *
> -     * @return all of this toolkit's {@ code PropertyChangeListener}
> -     *         objects wrapped in {@code PropertyChangeListenerProxy} 
> objects
> +     * @return all of this toolkit's {@code PropertyChangeListener}
> +     *         objects wrapped in {@code 
> java.beans.PropertyChangeListenerProxy PropertyChangeListenerProxy} 
> objects
>      *         or an empty array  if no listeners are added
>      *
>      * @see PropertyChangeSupport#getPropertyChangeListeners()
>




More information about the awt-dev mailing list