<AWT Dev> [8] Request for review: 7124286: macosx] Option modifier should work like AltGr as in Apple jdk 6

[Artem Ananiev]

Hi, Leonid,

the fix looks fine.

I would also suggest to rewrite the default check in SunToolkit from

(mods & InputEvent.ALT_MASK) == (mods & InputEvent.CTRL_MASK)

to

(mods & (InputEvent.ALT_MASK | InputEvent.CTRL_MASK)) == 0

because the latter seems easier to understand (personally to me).

Thanks,

Artem

On 4/16/2012 8:10 PM, Leonid Romanov wrote:
> Hi,
> Please review a fix for 7124286: macosx] Option modifier should work like AltGr as in Apple jdk 6.
> This fix has already been pushed into 7u4.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124286
> Webrev: http://cr.openjdk.java.net/~leonidr/7124286/webrev.01/
>
> Thanks,
> Leonid.
>
>