<AWT Dev> Request for Review: Remove import of empty JNI header files

Chris Hegarty chris.hegarty at oracle.com
Wed Apr 25 08:27:18 PDT 2012

[ cc'ing awt-dev & 2d-dev ]

The change looks fine Magnus, though it may be best to push through the 
awt or 2d forest. Members of these groups, cc'ed, are in a better 
position to comment on this.

Oh, just to clarify, I agree and approve this change (as much as my 
approval counts ;-) ). Just need to determine the best route for 


On 25/04/2012 14:44, Magnus Ihse Bursie wrote:
> There are a few files native files in AWT and Java2d, which include
> generated JNI header files, but the corresponding header files are
> empty, since the class contains neither native methods nor constants.
> All of them have probably been useful at one point in time, but then the
> Java code changed and the include became irrelevant, but nobody noticed.
> (Some of them contains JDK1.0-style, pre-JNI native access...)
> The trouble is, in the new build system, we only generate JNI header
> files when they actually contains something useful! So these files don't
> get generated. But then the compiler complains when building the native
> library, since the #include statements points to non-existent files.
> Webrev:
> http://cr.openjdk.java.net/~ihse/remove-empty-imports/webrev.00/
> /Magnus

More information about the awt-dev mailing list