From denis.fokin at oracle.com Wed Feb 1 07:39:44 2012 From: denis.fokin at oracle.com (Denis S. Fokin) Date: Wed, 01 Feb 2012 19:39:44 +0400 Subject: [8] Review request for 7123476: DesktopOpenTests:When enter the file path and click the open button, it crash Message-ID: <4F295CC0.5070406@oracle.com> Hi AWT team, Please review a fix for the CR 7123476 at http://cr.openjdk.java.net/~denis/7123476/webrev.01 CR URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123476 The Gnome API is deprecated so we need to migrate on GTK function. See the next thread. http://mail.gnome.org/archives/gnome-devel-list/2009-January/msg00004.html Thank you, Denis. From anthony.petrov at oracle.com Wed Feb 1 09:03:59 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 01 Feb 2012 21:03:59 +0400 Subject: [8] Review request for 7123476: DesktopOpenTests:When enter the file path and click the open button, it crash In-Reply-To: <4F295CC0.5070406@oracle.com> References: <4F295CC0.5070406@oracle.com> Message-ID: <4F29707F.4040909@oracle.com> Hi Denis, The gtk_show_uri() is available since GTK 2.14. Did you verify if all platforms supposed to be supported by JDK 8 have this version of GTK libraries installed by default? I'm mostly concerned about Solaris systems, as well as corporate Linux desktops. If this is not the case, then perhaps using this function should be conditional, and with the old GTK library we should fall back to using the old API. You may notice that, for example, for the file chooser we have an explicit check for GTK 2.8.0 and use the new gtk_file_chooser_set_do_overwrite_confirmation() API only when it's available. I like that we move all the GTK-related utility code to the gtk2_interface files. A few comments: 1. Please use the TRUE and FALSE constants instead of 1 and 0 as a return value for gtk2_show_uri_load(). 2. Should the fprintf() call be #ifdef'ed for INTERNAL_BUILD's only? -- best regards, Anthony On 2/1/2012 7:39 PM, Denis S. Fokin wrote: > Hi AWT team, > > Please review a fix for the CR 7123476 at > > http://cr.openjdk.java.net/~denis/7123476/webrev.01 > > CR URL: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123476 > > The Gnome API is deprecated so we need to migrate on GTK function. See > the next thread. > > http://mail.gnome.org/archives/gnome-devel-list/2009-January/msg00004.html > > Thank you, > Denis. From zhouyx at linux.vnet.ibm.com Wed Feb 1 22:31:10 2012 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Thu, 2 Feb 2012 14:31:10 +0800 Subject: Request review for 7129742 : Unable to view focus in Non-Editable TextArea In-Reply-To: <4F1448A5.4050509@oracle.com> References: <4F1448A5.4050509@oracle.com> Message-ID: Hi Artem, Alexander and Pavel , I'm writing the testcase, but while testing it, I got IllegalAccessError . Compilation of the testcase is successful. The spec says " this error can only occur at run time if the definition of a class has incompatibly changed." I'm using jdk8 built on 2012_02_01_17_01 and I changed nothing about that class. Do you have any idea about the error ? Thanks. The test case and error are as follow: ////////// includes two classes. package sun.awt.X11 ; import java.awt.TextArea; import javax.swing.text.Caret; import javax.swing.JTextArea; import java.lang.reflect.Field; public class XPeerTestHelper extends XTextAreaPeer{ public XPeerTestHelper(TextArea target) { super(target); } public Caret getCaret() { return jtext.getCaret(); // Exception reported to this line. } } ///// import java.awt.FlowLayout; import java.awt.TextArea; import java.awt.Toolkit; import javax.swing.JButton; import javax.swing.JFrame; import javax.swing.JTextField; import javax.swing.SwingUtilities; import javax.swing.text.DefaultCaret; import sun.awt.SunToolkit; import sun.awt.X11.XPeerTestHelper; public class bug7129742 { public static boolean passed = false; public static JFrame frame = null; public static JButton button = null; public static TextArea textArea = null; public static DefaultCaret caret = null; public static void main(String[] args) throws Exception { SunToolkit toolkit = (SunToolkit) Toolkit.getDefaultToolkit(); SwingUtilities.invokeAndWait(new Runnable() { @Override public void run() { frame = new JFrame("Test"); button = new JButton("JButton"); textArea = new TextArea("Non-editable textArea"); textArea.setEditable(false); frame.setLayout(new FlowLayout()); frame.getContentPane().add(button); frame.getContentPane().add(textArea); frame.pack(); frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); frame.setVisible(true); } }); toolkit.realSync(); SwingUtilities.invokeAndWait(new Runnable() { @Override public void run() { //caret = (DefaultCaret) try { XPeerTestHelper helper = new XPeerTestHelper(textArea); caret = (DefaultCaret) helper.getCaret(); } catch (ClassCastException e ){ // If it is not XTextAreaPeer, the test case is skipped System.out.println("It is not it is not XTextAreaPeer, testcase skipped"); passed = true; } } }); toolkit.realSync(); if (passed){ SwingUtilities.invokeAndWait(new Runnable() { @Override public void run() { frame.dispose(); } }); toolkit.realSync(); return; } SwingUtilities.invokeAndWait(new Runnable() { @Override public void run() { button.requestFocusInWindow(); } }); toolkit.realSync(); SwingUtilities.invokeAndWait(new Runnable() { @Override public void run() { textArea.requestFocusInWindow(); } }); toolkit.realSync(); SwingUtilities.invokeAndWait(new Runnable() { @Override public void run() { passed = caret.isVisible(); frame.dispose(); } }); toolkit.realSync(); if (!passed) { throw new RuntimeException("The test for bug 71297422 failed"); } } } ///////////////////////// end testcase Error information is: Exception in thread "main" java.lang.reflect.InvocationTargetException at java.awt.EventQueue.invokeAndWait(EventQueue.java:1238) at javax.swing.SwingUtilities.invokeAndWait(SwingUtilities.java:1344) at bug7129742.main(bug7129742.java:80) Caused by: java.lang.IllegalAccessError: class sun.awt.X11.XPeerTestHelper cannot access its superclass sun.awt.X11.XTextAreaPeer at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:791) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:442) at java.net.URLClassLoader.access$100(URLClassLoader.java:64) at java.net.URLClassLoader$1.run(URLClassLoader.java:354) at java.net.URLClassLoader$1.run(URLClassLoader.java:348) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:347) at java.lang.ClassLoader.loadClass(ClassLoader.java:423) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang.ClassLoader.loadClass(ClassLoader.java:356) at bug7129742$2.run(bug7129742.java:85) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:241) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:701) at java.awt.EventQueue.access$000(EventQueue.java:102) at java.awt.EventQueue$3.run(EventQueue.java:662) at java.awt.EventQueue$3.run(EventQueue.java:660) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75) at java.awt.EventQueue.dispatchEvent(EventQueue.java:671) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:216) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:135) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:123) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:119) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:111) at java.awt.EventDispatchThread.run(EventDispatchThread.java:97) On Mon, Jan 16, 2012 at 11:56 PM, Artem Ananiev wrote: > Hi, Sean, > > text components in XToolkit use Swing peers, so this change should better > be reviewed on the swing-dev alias. To save everybody's time, I've asked > Alex and Pavel from the Swing team (in CC) to take a look and they confirm > the fix looks fine. > > Did you consider creating a new regression test for this fix? I'm not sure > it's easy to detect if caret is visible in the text component or not, > though. > > Thanks, > > Artem > > > On 1/16/2012 7:08 AM, Sean Chou wrote: > >> Hi all, >> >> I made a patch for bug 7129742, >> http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7129742. >> The webrev link is : http://cr.openjdk.java.net/~** >> zhouyx/7129742/webrev.00/ >> >> The solution is very simple, just set the cursor visible. >> >> Please have a look and give some comments. Thanks. >> >> -- >> Best Regards, >> Sean Chou >> >> -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120202/d58bf641/attachment.html From anthony.petrov at oracle.com Thu Feb 2 05:49:55 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Thu, 02 Feb 2012 13:49:55 +0000 Subject: hg: jdk8/awt/jdk: 7132194: GtkFileDialog does not point to the correct file(s) is Recent Files are used. Message-ID: <20120202135015.DDA7E4730E@hg.openjdk.java.net> Changeset: 45ce82d366ec Author: anthony Date: 2012-02-02 17:49 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/45ce82d366ec 7132194: GtkFileDialog does not point to the correct file(s) is Recent Files are used. Summary: Handle the file list differently if gtk_file_chooser_get_current_folder() returns NULL Reviewed-by: anthony Contributed-by: Matthew Smith ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c From anthony.petrov at oracle.com Thu Feb 2 05:55:52 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 02 Feb 2012 17:55:52 +0400 Subject: A patch so multiple selected files can have different directories. In-Reply-To: <4F26F4D7.2070205@orangepalantir.org> References: <4F1DC80E.2050707@orangepalantir.org> <4F26B276.2030005@oracle.com> <4F26F4D7.2070205@orangepalantir.org> Message-ID: <4F2A95E8.5010003@oracle.com> Hi Matthew, I've just pushed your fix: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/45ce82d366ec Thanks! -- best regards, Anthony On 01/30/12 23:51, Matthew Smith wrote: > Anthony > > I made the changes suggested and tried it out. Everything seems ok. > > Cheers. > mbs > > On 01/30/2012 10:08 AM, Anthony Petrov wrote: >> Hi Matthew, >> >> I've published a webrev at: >> >> http://cr.openjdk.java.net/~anthony/8-10-GTKFileDialogMultiSelRecentFiles-7132194.0/ >> >> >> I have a few stylistic comments: >> >> 1. Lines 187, 235: please avoid using reverse order for conditionals. >> I.e. (list == NULL) is preferred to (NULL == list). >> >> 2. Line 208: always put the if/else (and while()) statements into >> blocks {} (and add a new line after {.) >> >> 3. Lines 208, 235,236, 240, 246: please use proper spacing (e.g.. "if >> (cond) {", "a = b;", etc.) >> >> 4. (this one is less stylistic): at line 208 what prevents us from >> using "if (entry[0] == '/')"? This seems more simple and robust than >> using strchr() and pointer arithmetics. >> >> Other than that the fix looks fine to me, thank you! Once you fix the >> issues above and send us an updated patch, I can push the fix to the >> repository. >> >> Comments from other AWT team members (and anyone interested) are welcome! >> >> -- >> best regards, >> Anthony >> >> On 01/24/12 00:50, Matthew Smith wrote: >>> openjdk/jdk/src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c >>> >>> This patch is intended to address the issue of newer versions of gtk >>> where the file dialog lets you select files w/out selecting a directory >>> via Search or Recently Used. When this happens the 'current directory' >>> is returned as null, and the Files selected will be returned with the >>> current working directory appended to the path. >>> >>> The .java file will show the incorrect behavior if you run it and use >>> Recently Used to select a file (gnome 3). >>> >>> This patch does not change the behavior when a directory is selected, or >>> when the dialog is canceled. If you select a file from the Recently Used >>> option the directory will be set to the root directory, and the filename >>> will be the complete path and filename. When multiple files are selected >>> from a folder the original behavior occurs. If multiple files are >>> selected from Recently Used then the directory is again set to root, and >>> all of the fiIes have the complete name. >>> >>> This work around can be verified with the .java file provided. >>> >>> Finally this is an updated version of the patch, originally I used >>> 'bool' instead of a 'gboolean' I did compile it and test that it works. >>> >>> Thank you >>> mbs >> > From artem.ananiev at oracle.com Thu Feb 2 08:26:47 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 02 Feb 2012 20:26:47 +0400 Subject: A patch so multiple selected files can have different directories. In-Reply-To: <4F281D82.3040409@oracle.com> References: <4F1DC80E.2050707@orangepalantir.org> <4F26B276.2030005@oracle.com> <4F26F4D7.2070205@orangepalantir.org> <4F281D82.3040409@oracle.com> Message-ID: <4F2AB947.3020209@oracle.com> On 1/31/2012 8:57 PM, Anthony Petrov wrote: > Hi Matthew, > > The updated webrev is available at: > > http://cr.openjdk.java.net/~anthony/8-10-GTKFileDialogMultiSelRecentFiles-7132194.1/ > > Please note that there's still problems with formatting at lines 210-211 > (TABs instead of spaces), 239 (missing spaces), and also an extra empty > line at 248. No need to resend a new patch, I'll fix these myself before > pushing the fix. > > In the future, please pay attention to formatting your code. At first > this issue may seem unimportant, however, it greatly simplifies > maintaining the code, especially as large as OpenJDK. That's why we > require all fixes to follow the common Java Code Conventions and be > properly formatted. You could use the webrev utility [1] to generate > webreves for your code changes. It is easier to spot mis-formatted code > using a HTML view of your changes. > > Having said that, I'm approving the fix. Thank you for the contribution! > If anyone on the mailing list has additional comments, they are welcome. It looks fine. I would explicitly delete the stringCls local ref in the toPathAndFilenamesArray() method, however it's not critical, it will be released by VM later anyway. Thanks, Artem > [1] http://openjdk.java.net/guide/webrevHelp.html > > -- > best regards, > Anthony > > On 1/30/2012 11:51 PM, Matthew Smith wrote: >> Anthony >> >> I made the changes suggested and tried it out. Everything seems ok. >> >> Cheers. >> mbs >> >> On 01/30/2012 10:08 AM, Anthony Petrov wrote: >>> Hi Matthew, >>> >>> I've published a webrev at: >>> >>> http://cr.openjdk.java.net/~anthony/8-10-GTKFileDialogMultiSelRecentFiles-7132194.0/ >>> >>> >>> I have a few stylistic comments: >>> >>> 1. Lines 187, 235: please avoid using reverse order for conditionals. >>> I.e. (list == NULL) is preferred to (NULL == list). >>> >>> 2. Line 208: always put the if/else (and while()) statements into >>> blocks {} (and add a new line after {.) >>> >>> 3. Lines 208, 235,236, 240, 246: please use proper spacing (e.g.. "if >>> (cond) {", "a = b;", etc.) >>> >>> 4. (this one is less stylistic): at line 208 what prevents us from >>> using "if (entry[0] == '/')"? This seems more simple and robust than >>> using strchr() and pointer arithmetics. >>> >>> Other than that the fix looks fine to me, thank you! Once you fix the >>> issues above and send us an updated patch, I can push the fix to the >>> repository. >>> >>> Comments from other AWT team members (and anyone interested) are >>> welcome! >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 01/24/12 00:50, Matthew Smith wrote: >>>> openjdk/jdk/src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c >>>> >>>> This patch is intended to address the issue of newer versions of gtk >>>> where the file dialog lets you select files w/out selecting a directory >>>> via Search or Recently Used. When this happens the 'current directory' >>>> is returned as null, and the Files selected will be returned with the >>>> current working directory appended to the path. >>>> >>>> The .java file will show the incorrect behavior if you run it and use >>>> Recently Used to select a file (gnome 3). >>>> >>>> This patch does not change the behavior when a directory is >>>> selected, or >>>> when the dialog is canceled. If you select a file from the Recently >>>> Used >>>> option the directory will be set to the root directory, and the >>>> filename >>>> will be the complete path and filename. When multiple files are >>>> selected >>>> from a folder the original behavior occurs. If multiple files are >>>> selected from Recently Used then the directory is again set to root, >>>> and >>>> all of the fiIes have the complete name. >>>> >>>> This work around can be verified with the .java file provided. >>>> >>>> Finally this is an updated version of the patch, originally I used >>>> 'bool' instead of a 'gboolean' I did compile it and test that it works. >>>> >>>> Thank you >>>> mbs >>> >> From zhouyx at linux.vnet.ibm.com Fri Feb 3 01:39:20 2012 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Fri, 3 Feb 2012 17:39:20 +0800 Subject: Request review for 7129742 : Unable to view focus in Non-Editable TextArea In-Reply-To: References: <4F1448A5.4050509@oracle.com> Message-ID: Problem resolved, I'll post the testcase later. On Thu, Feb 2, 2012 at 2:31 PM, Sean Chou wrote: > Hi Artem, Alexander and Pavel , > > I'm writing the testcase, but while testing it, I > got IllegalAccessError . > Compilation of the testcase is successful. The spec says > " this error can only occur at run time if the definition of a > class has incompatibly changed." I'm using jdk8 built on > 2012_02_01_17_01 and I changed nothing about that class. > Do you have any idea about the error ? Thanks. > > The test case and error are as follow: > > ////////// includes two classes. > > package sun.awt.X11 ; > import java.awt.TextArea; > import javax.swing.text.Caret; > import javax.swing.JTextArea; > import java.lang.reflect.Field; > > public class XPeerTestHelper extends XTextAreaPeer{ > > public XPeerTestHelper(TextArea target) { > super(target); > } > > public Caret getCaret() { > return jtext.getCaret(); // Exception reported to this line. > } > > } > > ///// > > > import java.awt.FlowLayout; > import java.awt.TextArea; > import java.awt.Toolkit; > > import javax.swing.JButton; > import javax.swing.JFrame; > import javax.swing.JTextField; > import javax.swing.SwingUtilities; > import javax.swing.text.DefaultCaret; > > import sun.awt.SunToolkit; > import sun.awt.X11.XPeerTestHelper; > > public class bug7129742 { > public static boolean passed = false; > > public static JFrame frame = null; > public static JButton button = null; > public static TextArea textArea = null; > > public static DefaultCaret caret = null; > > public static void main(String[] args) throws Exception { > SunToolkit toolkit = (SunToolkit) Toolkit.getDefaultToolkit(); > SwingUtilities.invokeAndWait(new Runnable() { > @Override > public void run() { > frame = new JFrame("Test"); > > button = new JButton("JButton"); > textArea = new TextArea("Non-editable textArea"); > textArea.setEditable(false); > > frame.setLayout(new FlowLayout()); > frame.getContentPane().add(button); > frame.getContentPane().add(textArea); > > frame.pack(); > frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); > frame.setVisible(true); > } > }); > toolkit.realSync(); > > SwingUtilities.invokeAndWait(new Runnable() { > @Override > public void run() { > //caret = (DefaultCaret) > try { > XPeerTestHelper helper = new XPeerTestHelper(textArea); > caret = (DefaultCaret) helper.getCaret(); > } catch (ClassCastException e ){ > // If it is not XTextAreaPeer, the test case is skipped > System.out.println("It is not it is not XTextAreaPeer, > testcase skipped"); > passed = true; > } > } > }); > toolkit.realSync(); > > if (passed){ > SwingUtilities.invokeAndWait(new Runnable() { > @Override > public void run() { > frame.dispose(); > } > }); > toolkit.realSync(); > return; > } > > SwingUtilities.invokeAndWait(new Runnable() { > @Override > public void run() { > button.requestFocusInWindow(); > } > }); > toolkit.realSync(); > > SwingUtilities.invokeAndWait(new Runnable() { > @Override > public void run() { > textArea.requestFocusInWindow(); > } > }); > toolkit.realSync(); > > SwingUtilities.invokeAndWait(new Runnable() { > @Override > public void run() { > passed = caret.isVisible(); > frame.dispose(); > } > }); > toolkit.realSync(); > > if (!passed) { > throw new RuntimeException("The test for bug 71297422 failed"); > } > > } > } > > ///////////////////////// end testcase > > > Error information is: > Exception in thread "main" java.lang.reflect.InvocationTargetException > at java.awt.EventQueue.invokeAndWait(EventQueue.java:1238) > at javax.swing.SwingUtilities.invokeAndWait(SwingUtilities.java:1344) > at bug7129742.main(bug7129742.java:80) > Caused by: java.lang.IllegalAccessError: class sun.awt.X11.XPeerTestHelper > cannot access its superclass sun.awt.X11.XTextAreaPeer > at java.lang.ClassLoader.defineClass1(Native Method) > at java.lang.ClassLoader.defineClass(ClassLoader.java:791) > at > java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) > at java.net.URLClassLoader.defineClass(URLClassLoader.java:442) > at java.net.URLClassLoader.access$100(URLClassLoader.java:64) > at java.net.URLClassLoader$1.run(URLClassLoader.java:354) > at java.net.URLClassLoader$1.run(URLClassLoader.java:348) > at java.security.AccessController.doPrivileged(Native Method) > at java.net.URLClassLoader.findClass(URLClassLoader.java:347) > at java.lang.ClassLoader.loadClass(ClassLoader.java:423) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) > at java.lang.ClassLoader.loadClass(ClassLoader.java:356) > at bug7129742$2.run(bug7129742.java:85) > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:241) > at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:701) > at java.awt.EventQueue.access$000(EventQueue.java:102) > at java.awt.EventQueue$3.run(EventQueue.java:662) > at java.awt.EventQueue$3.run(EventQueue.java:660) > at java.security.AccessController.doPrivileged(Native Method) > at > java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75) > at java.awt.EventQueue.dispatchEvent(EventQueue.java:671) > at > java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:216) > at > java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:135) > at > java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:123) > at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:119) > at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:111) > at java.awt.EventDispatchThread.run(EventDispatchThread.java:97) > > > > > > On Mon, Jan 16, 2012 at 11:56 PM, Artem Ananiev wrote: > >> Hi, Sean, >> >> text components in XToolkit use Swing peers, so this change should better >> be reviewed on the swing-dev alias. To save everybody's time, I've asked >> Alex and Pavel from the Swing team (in CC) to take a look and they confirm >> the fix looks fine. >> >> Did you consider creating a new regression test for this fix? I'm not >> sure it's easy to detect if caret is visible in the text component or not, >> though. >> >> Thanks, >> >> Artem >> >> >> On 1/16/2012 7:08 AM, Sean Chou wrote: >> >>> Hi all, >>> >>> I made a patch for bug 7129742, >>> http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7129742. >>> The webrev link is : http://cr.openjdk.java.net/~** >>> zhouyx/7129742/webrev.00/ >>> >>> The solution is very simple, just set the cursor visible. >>> >>> Please have a look and give some comments. Thanks. >>> >>> -- >>> Best Regards, >>> Sean Chou >>> >>> > > > -- > Best Regards, > Sean Chou > > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120203/b1ab740e/attachment.html From anthony.petrov at oracle.com Fri Feb 3 05:22:09 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 03 Feb 2012 17:22:09 +0400 Subject: Review request for 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash Message-ID: <4F2BDF81.7050805@oracle.com> Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7142120 at: http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.0/ The fix is fairly simple: use NSScreen -frame instead of -visibleFrame. In this case the splash screen is positioned in the geometrical center of the screen. Visually this looks less pleasant (we may want to file an RFE in the future), but makes tests happy which is what we need right now. All the failing tests now pass well with this fix applied. -- best regards, Anthony From pavel.porvatov at oracle.com Fri Feb 3 05:58:06 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Fri, 03 Feb 2012 13:58:06 +0000 Subject: hg: jdk8/awt/jdk: 7141573: JProgressBar resize exception, if setStringPainted in Windows LAF Message-ID: <20120203135829.17C264735A@hg.openjdk.java.net> Changeset: 10fa63972ad5 Author: rupashka Date: 2012-02-03 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/10fa63972ad5 7141573: JProgressBar resize exception, if setStringPainted in Windows LAF Reviewed-by: malenkov ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsProgressBarUI.java + test/javax/swing/JProgressBar/7141573/bug7141573.java From pavel.porvatov at oracle.com Fri Feb 3 06:01:19 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Fri, 03 Feb 2012 14:01:19 +0000 Subject: hg: jdk8/awt/jdk: 7071775: javax/swing/JFileChooser/6396844/TwentyThousandTest.java failed on winxp Message-ID: <20120203140128.EB8054735B@hg.openjdk.java.net> Changeset: 34571be262e9 Author: rupashka Date: 2012-02-03 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/34571be262e9 7071775: javax/swing/JFileChooser/6396844/TwentyThousandTest.java failed on winxp Reviewed-by: alexp ! test/javax/swing/JFileChooser/6396844/TwentyThousandTest.java From oleg.pekhovskiy at oracle.com Fri Feb 3 08:40:45 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Fri, 03 Feb 2012 20:40:45 +0400 Subject: [7u4] Code Review Request for CR 7082294 - nsk/regression/b4265661 crashes on windows Message-ID: <4F2C0E0D.6090906@oracle.com> Hi guys! Here is the description of CR: http://bugs.sun.com/view_bug.do?bug_id=7082294 Patch with changes attached. Description of the fix: Sometimes execution of AwtObjectList::Cleanup() could be delayed by posting WM_AWT_OBJECTLISTCLEANUP message. From the other side this method is called from AwtToolkit::Dispose(). There AwtObjectList::Cleanup() is followed by AwtFont::Cleanup(). Thus, sometimes we could have the situation when AwtFont::Cleanup() is called before the main functionality of AwtObjectList::Cleanup(). It means that all HFONT objects would be deleted from AwtFontCache. So when AwtFont::Dispose() would be called from AwtObjectList::Cleanup() it would not find HFONT in AwtFontCache and would try to delete HFONT (that is deleted in AwtFontCache) once again. There is also a custom message pump in AwtToolkit::Dispose() that allows posted WM_AWT_OBJECTLISTCLEANUP be handled. If we move AwtFont::Cleanup() right after that message pump we guarantee that AwtObjectList::Cleanup() would always be called before AwtFont::Cleanup(). That what my fix is about. PS: I also left my changes in AwtFont to emilinate invalid HFONT usage and access violation probability between AwtFont::Dispose() and AwtFont::~AwtFont() calls. PPS: This implementation is a kind of workaround for 7u4. As for JDK 8 - font caching should be improved. Thanks, Oleg. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120203/42bd1aac/attachment.html -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 7082294.patch Url: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120203/42bd1aac/7082294.patch From swingler at apple.com Fri Feb 3 15:12:37 2012 From: swingler at apple.com (Mike Swingler) Date: Fri, 03 Feb 2012 15:12:37 -0800 Subject: Review request for 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash In-Reply-To: <4F2BDF81.7050805@oracle.com> References: <4F2BDF81.7050805@oracle.com> Message-ID: On Feb 3, 2012, at 5:22 AM, Anthony Petrov wrote: > Hello, > > Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7142120 at: > > http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.0/ > > The fix is fairly simple: use NSScreen -frame instead of -visibleFrame. In this case the splash screen is positioned in the geometrical center of the screen. Visually this looks less pleasant (we may want to file an RFE in the future), but makes tests happy which is what we need right now. > > All the failing tests now pass well with this fix applied. Also [NSScreen mainScreen] gives you the screen that the "main" (aka "active") window is on. You really should use the 0'th screen to get the "primary" screen with the menu bar and the Dock. Regards, Mike Swingler Apple Inc. From chris.hegarty at oracle.com Sat Feb 4 00:05:55 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Sat, 04 Feb 2012 08:05:55 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: References: <4F2A6213.4040707@oracle.com> Message-ID: <4F2CE6E3.103@oracle.com> Michael, Looks good to me. Trivially, the generic type in ComponentBeanInfo could simply be Class, since the actual type is not used. But, what you have is fine. Thanks for this contribution. I'm sure Stuart will do the integration for you. -Chris. On 02/ 4/12 07:48 AM, Michael Barker wrote: >> I see R?mi has suggested a slice& dice but I think that's a bit too much >> work for the changes involved. Instead I would suggest a simple split, send >> the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to >> core-libs-dev. > > Attached is a patch that contains the awt/printing/beans changes from > the LJC hack session. > > Mike. From Alan.Bateman at oracle.com Sat Feb 4 03:12:30 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 04 Feb 2012 11:12:30 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: References: <4F2A6213.4040707@oracle.com> Message-ID: <4F2D129E.7030705@oracle.com> On 04/02/2012 07:48, Michael Barker wrote: >> I see R?mi has suggested a slice& dice but I think that's a bit too much >> work for the changes involved. Instead I would suggest a simple split, send >> the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to >> core-libs-dev. > Attached is a patch that contains the awt/printing/beans changes from > the LJC hack session. > > Mike. I skimmed through this and just wonder about the changes to java.beans.beancontext.BeansSupportContext. It's a public type so adding a type parameter to the protected bcmListeners may be an issue. -Alan. From chris.hegarty at oracle.com Sat Feb 4 04:15:42 2012 From: chris.hegarty at oracle.com (chris hegarty) Date: Sat, 04 Feb 2012 12:15:42 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: <4F2D129E.7030705@oracle.com> References: <4F2A6213.4040707@oracle.com> <4F2D129E.7030705@oracle.com> Message-ID: <4F2D216E.8010605@oracle.com> On 04/02/2012 11:12, Alan Bateman wrote: > .... > I skimmed through this and just wonder about the changes to > java.beans.beancontext.BeansSupportContext. It's a public type so adding > a type parameter to the protected bcmListeners may be an issue. Oh, good catch Alan, I missed this. This part of the change should be reversed ( at least in the context of warnings cleanup ). -Chris. > > -Alan. From chris.hegarty at oracle.com Sat Feb 4 07:48:25 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Sat, 04 Feb 2012 15:48:25 +0000 Subject: Warning Fixes from LJC Hack Session Message-ID: <12yonmlryq6ii4h38gpe1thd.1328370505882@email.android.com> I think you should just drop the changes to this file. -Chris. Michael Barker wrote: >> Oh, good catch Alan, I missed this. This part of the change should be >> reversed ( at least in the context of warnings cleanup ). > >Should I switch it to a wild card (protected transient ArrayList >bcmListeners) or just drop the modifications for that file? > >Mike. From zhouyx at linux.vnet.ibm.com Mon Feb 6 01:31:14 2012 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Mon, 6 Feb 2012 17:31:14 +0800 Subject: Request review for 7129742 : Unable to view focus in Non-Editable TextArea In-Reply-To: <4F1448A5.4050509@oracle.com> References: <4F1448A5.4050509@oracle.com> Message-ID: Hi all, The testcase is added, the new link is http://cr.openjdk.java.net/~zhouyx/7129742/webrev.01/ . Please review and give your comments. When writing the testcase, I found the application would not exit if the caret is set visible. It is caused by the timer thread controlling the blinking of the caret. So I set the caret invisible when disposing the TextArea. More info: The patch is for bug 7129742, http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7129742 . Thanks. On Mon, Jan 16, 2012 at 11:56 PM, Artem Ananiev wrote: > Hi, Sean, > > text components in XToolkit use Swing peers, so this change should better > be reviewed on the swing-dev alias. To save everybody's time, I've asked > Alex and Pavel from the Swing team (in CC) to take a look and they confirm > the fix looks fine. > > Did you consider creating a new regression test for this fix? I'm not sure > it's easy to detect if caret is visible in the text component or not, > though. > > Thanks, > > Artem > > > On 1/16/2012 7:08 AM, Sean Chou wrote: > >> Hi all, >> >> I made a patch for bug 7129742, >> http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7129742. >> The webrev link is : http://cr.openjdk.java.net/~** >> zhouyx/7129742/webrev.00/ >> >> The solution is very simple, just set the cursor visible. >> >> Please have a look and give some comments. Thanks. >> >> -- >> Best Regards, >> Sean Chou >> >> -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120206/e81e8a6a/attachment.html From anthony.petrov at oracle.com Mon Feb 6 03:33:07 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 06 Feb 2012 15:33:07 +0400 Subject: Warning Fixes from LJC Hack Session In-Reply-To: References: <12yonmlryq6ii4h38gpe1thd.1328370505882@email.android.com> Message-ID: <4F2FBA73.2090105@oracle.com> Hi Michael, The changes to List.java and Window.java look fine to me. -- best regards, Anthony On 2/4/2012 8:40 PM, Michael Barker wrote: > Patch with BeanSupportContext changes removed. > > Mike. > > On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote: >> I think you should just drop the changes to this file. >> >> -Chris. >> >> Michael Barker wrote: >> >>>> Oh, good catch Alan, I missed this. This part of the change should be >>>> reversed ( at least in the context of warnings cleanup ). >>> Should I switch it to a wild card (protected transient ArrayList >>> bcmListeners) or just drop the modifications for that file? >>> >>> Mike. From oleg.pekhovskiy at oracle.com Thu Feb 2 05:47:00 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 02 Feb 2012 17:47:00 +0400 Subject: [7u4] Code Review Request for CR 7082294 - nsk/regression/b4265661 crashes on windows In-Reply-To: <4F22DE49.5030908@oracle.com> References: <4F22DE49.5030908@oracle.com> Message-ID: <4F2A93D4.3020908@oracle.com> ??????, ?????, ? ???? ????? ??? ??????? ? ?? ??? ?????, ??? ??? ?? ????????? ?? ??????... ???????, ????. 27.01.2012 21:26, Oleg Pekhovskiy wrote: > Hi guys! > > Here is the description of CR: > http://bt2ws.central.sun.com/CrPrint?id=7082294 > > Patch with changes attached. > > Description of the fix: > Sometimes execution of AwtObjectList::Cleanup() could be delayed by > posting WM_AWT_OBJECTLISTCLEANUP message. > From the other side this method is called from AwtToolkit::Dispose(). > There AwtObjectList::Cleanup() is followed by AwtFont::Cleanup(). > Thus, sometimes we could have the situation when AwtFont::Cleanup() is > called before the main functionality of AwtObjectList::Cleanup(). > It means that all HFONT objects would be deleted from AwtFontCache. > So when AwtFont::Dispose() would be called from AwtObjectList::Cleanup() > it would not find HFONT in AwtFontCache and would try to delete HFONT > (that is deleted in AwtFontCache) once again. > There is also a custom message pump in AwtToolkit::Dispose() that allows > posted WM_AWT_OBJECTLISTCLEANUP be handled. > If we move AwtFont::Cleanup() right after that message pump we guarantee > that AwtObjectList::Cleanup() would always be called before > AwtFont::Cleanup(). > That what my fix is about. > > PS: I also left my changes in AwtFont to emilinate invalid HFONT usage > and access violation probability between AwtFont::Dispose() and > AwtFont::~AwtFont() calls. > > PPS: This implementation is a kind of workaround for 7u4. As for JDK 8 > - font caching should be improved. > > Thanks, > Oleg. From oleg.pekhovskiy at oracle.com Thu Feb 2 08:26:23 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 02 Feb 2012 20:26:23 +0400 Subject: [7u4] Code Review Request for CR 7082294 - nsk/regression/b4265661 crashes on windows Message-ID: <4F2AB92F.3050701@oracle.com> Hi guys! Here is the description of CR: http://bugs.sun.com/view_bug.do?bug_id=7082294 Patch with changes attached. Description of the fix: Sometimes execution of AwtObjectList::Cleanup() could be delayed by posting WM_AWT_OBJECTLISTCLEANUP message. From the other side this method is called from AwtToolkit::Dispose(). There AwtObjectList::Cleanup() is followed by AwtFont::Cleanup(). Thus, sometimes we could have the situation when AwtFont::Cleanup() is called before the main functionality of AwtObjectList::Cleanup(). It means that all HFONT objects would be deleted from AwtFontCache. So when AwtFont::Dispose() would be called from AwtObjectList::Cleanup() it would not find HFONT in AwtFontCache and would try to delete HFONT (that is deleted in AwtFontCache) once again. There is also a custom message pump in AwtToolkit::Dispose() that allows posted WM_AWT_OBJECTLISTCLEANUP be handled. If we move AwtFont::Cleanup() right after that message pump we guarantee that AwtObjectList::Cleanup() would always be called before AwtFont::Cleanup(). That what my fix is about. PS: I also left my changes in AwtFont to emilinate invalid HFONT usage and access violation probability between AwtFont::Dispose() and AwtFont::~AwtFont() calls. PPS: This implementation is a kind of workaround for 7u4. As for JDK 8 - font caching should be improved. Thanks, Oleg. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120202/f5c4524a/attachment.html -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 7082294.patch Url: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120202/f5c4524a/7082294.patch From luchsh at linux.vnet.ibm.com Fri Feb 3 01:29:41 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Fri, 03 Feb 2012 17:29:41 +0800 Subject: Fwd: Re: Problem of using malloc() without including stdlib.h Message-ID: <4F2BA905.1030205@linux.vnet.ibm.com> Copy to 2d-dev & awt-dev list, since some files are from these two modules. Any suggestions? --------- Actually the problem was firstly found on AIX platform, on which sizeof(malloc(1)) without including will always give 4 instead of 8. The symptom was runtime segment error not compiling time warnings, and I suspect there're more failures which were not covered in my application. I've checked the build log of Linux64 platform, as Phil mentioned there's also no such warnings except for the hotspot diagnostic ones. One reason might be that some code inlcudes "malloc.h" instead of , there's one 'extern' definition in malloc.h on Linux 64 platform, but I do not see one on AIX platform. I've also tried to trace the indirect reference relation ship for all the .c/.cpp files using malloc(), still cannot determine a explicit definition of following files. pls fix me if anything wrong, because the list is produced manually :( ./src/share/native/sun/awt/splashscreen/splashscreen_png.c ./src/share/native/sun/awt/splashscreen/java_awt_SplashScreen.c ./src/share/native/sun/awt/splashscreen/splashscreen_gif.c ./src/share/native/sun/awt/splashscreen/splashscreen_impl.c ./src/share/native/sun/awt/image/dither.c ./src/share/native/sun/font/layout/KernTable.cpp ./src/share/native/sun/java2d/cmm/lcms/cmserr.c ./src/share/native/com/sun/media/sound/PlatformMidi.c ./src/share/bin/jli_util.c ./src/share/back/debugInit.c ./src/share/demo/jvmti/hprof/hprof_init.c ./src/share/demo/jvmti/hprof/hprof_table.c ./src/share/demo/jvmti/hprof/hprof_util.c ./src/windows/native/java/lang/ProcessImpl_md.c ./src/windows/native/java/lang/java_props_md.c ./src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c ./src/windows/native/java/io/dirent_md.c ./src/windows/native/java/io/io_util_md.c ./src/windows/native/sun/awt/splashscreen/splashscreen_sys.c ./src/windows/native/sun/tracing/dtrace/jvm_symbols_md.c ./src/windows/native/sun/windows/awt_new.cpp ./src/windows/native/sun/windows/CmdIDList.cpp ./src/windows/native/sun/nio/ch/DatagramDispatcher.c ./src/windows/native/sun/nio/ch/SocketDispatcher.c ./src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_MidiIn.cpp ./src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_Ports.c ./src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_DirectSound.cpp ./src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_Util.c ./src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_MidiOut.c ./src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ./src/solaris/native/sun/java2d/x11/XRBackendNative.c ./src/solaris/native/sun/java2d/x11/X11SurfaceData.c ./src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c ./src/solaris/native/sun/java2d/x11/X11Renderer.c For a simple HelloWorld.c, if we use malloc() without including stdlib.h, it will give warnings like "warning: incompatible implicit declaration of built-in function ?malloc?". No such warning were found from the build log for above files, so I guess there must be some headers has got indirect including or declaration of malloc.h, but I'm worried because I did not see one via manual search. It indeed sounds reasonable to me that if no warnings are produced and the compilation runs OK, we may just leave the code untouched, but it will improve portability if we can explicitly includes standard C library headers in the right place (of cause, the 'right' place is also something need to be discussed), right? And for the 3rd party libraries, for those whose code has been shipped with OpenJDK source, they seem OK to me since malloc() has either been included or redefined. But for some dependency libraries of compilation, such as X11 dev, are they also trustworthy? Best regards! - Jonathan On 01/19/2012 02:31 AM, Kelly O'Hair wrote: > A webrev and a code review from the appropriate teams is indeed needed. > > -kto > > On Jan 18, 2012, at 9:56 AM, Phil Race wrote: > >> Its arguable, whether harmless or not, that each file needs to include it. >> Its not unreasonable for an area of the code to have a header file such as "awt.h" >> that is supposed to be the one that's included by the other files in that area of >> the code, and which takes care of common includes. jni_util.h is not necessarily it. >> There isn't a need for every file to include that. >> Also many files are 3rd party libs and I don't like editing those as the changes >> really belong upstream. >> So a one size fits all approach might be the answer but I'd want to make sure >> of that first. >> >> So I'd like to see the list of files that generate actual warnings as well as the list >> of files that reference malloc but don't include stdlib.h. >> >> We are well aware that returning int as a default is bad in 64 bit .. I'd expect >> instant death so I'd like to see those actual warnings rather than just the >> theoretical ones. >> >> My grep of a current JDK 8 build log for 64 bit Linux shows the only malloc warnings >> are in hotspot management code. So I am waiting for the proof of the real problem >> >> And I can speak for 2d, and if there's 2D files touched I would like to see any changes >> to those files, and the reasoning discussed on 2d-dev .. >> >> -phil. >> >> On 1/18/2012 8:26 AM, Kelly O'Hair wrote: >>> On Jan 18, 2012, at 12:19 AM, Jonathan Lu wrote: >>> >>>> Hi core-libs-dev, >>>> >>>> I found that for some native code of OpenJDK code base, malloc() is used without including header file stdlib.h, such as following files, >>>> ./src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c >>>> ./src/solaris/native/sun/java2d/x11/XRBackendNative.c >>>> .... >>>> >>>> I assume that there's no hacking tricks involved here, right? because this may cause problem for some C compilers, which assumes 'int' as the default return type of a function if it cannot find the function's declaration during compiling. Under such a condition, actual return result of type 'void*' from malloc() will be converted to 'int', which may result in truncated pointers in 64bit platforms. If the application tries to dereference such a broken pointer, error will occur. >>>> >>>> Indeed I found some indirect includes of stdlib.h, but there're still some I do not see a stdlib.h get included from any of the direct/indirect included headers. I think in order to fix this problem, two approaches may be considered here, >>>> a) add "#include" to every missing .c file. >>>> b) add "#include" to a commonly referenced header file, such as jni_util.h. but it would not be easy to find such a file for all and creating one is the same as approach a). >>>> >>> I suggest a) It should be harmless and is the right thing to do. >>> >>> It's been a while since I studied the C standard, but I vaguely recall that there was another standard C include file >>> that would cause the malloc() prototype declaration to show up. >>> Or maybe it wasn't a standard one. In any case, I think your a) approach is correct and I don't see much a need >>> for detailed discussions on this, as long as it builds correctly with no warnings on all platforms. It should be fine and correct. >>> That's my 2 cents. >>> >>> -kto >>> >>>> But both methods need to change many files, any other ideas about how to fix it more elegantly? >>>> >>>> Thanks and best regards! >>>> - Jonathan >>>> From mikeb01 at gmail.com Fri Feb 3 23:48:22 2012 From: mikeb01 at gmail.com (Michael Barker) Date: Sat, 4 Feb 2012 07:48:22 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: <4F2A6213.4040707@oracle.com> References: <4F2A6213.4040707@oracle.com> Message-ID: > I see R?mi has suggested a slice & dice but I think that's a bit too much > work for the changes involved. Instead I would suggest a simple split, send > the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to > core-libs-dev. Attached is a patch that contains the awt/printing/beans changes from the LJC hack session. Mike. -------------- next part -------------- diff -r 55a82eba1986 src/share/classes/java/awt/List.java --- a/src/share/classes/java/awt/List.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/awt/List.java Sat Feb 04 07:37:18 2012 +0000 @@ -115,7 +115,7 @@ * @see #addItem(String) * @see #getItem(int) */ - Vector items = new Vector(); + Vector items = new Vector<>(); /** * This field will represent the number of visible rows in the @@ -306,7 +306,7 @@ // to insure that it cannot be overridden by client subclasses. // DO NOT INVOKE CLIENT CODE ON THIS THREAD! final String getItemImpl(int index) { - return (String)items.elementAt(index); + return items.elementAt(index); } /** @@ -415,7 +415,7 @@ if (peer != null) { peer.removeAll(); } - items = new Vector(); + items = new Vector<>(); selected = new int[0]; } @@ -490,9 +490,9 @@ public synchronized int[] getSelectedIndexes() { ListPeer peer = (ListPeer)this.peer; if (peer != null) { - selected = ((ListPeer)peer).getSelectedIndexes(); + selected = peer.getSelectedIndexes(); } - return (int[])selected.clone(); + return selected.clone(); } /** @@ -908,7 +908,7 @@ * @since 1.4 */ public synchronized ItemListener[] getItemListeners() { - return (ItemListener[])(getListeners(ItemListener.class)); + return getListeners(ItemListener.class); } /** @@ -975,7 +975,7 @@ * @since 1.4 */ public synchronized ActionListener[] getActionListeners() { - return (ActionListener[])(getListeners(ActionListener.class)); + return getListeners(ActionListener.class); } /** diff -r 55a82eba1986 src/share/classes/java/awt/Window.java --- a/src/share/classes/java/awt/Window.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/awt/Window.java Sat Feb 04 07:37:18 2012 +0000 @@ -398,10 +398,10 @@ initIDs(); } - String s = (String) java.security.AccessController.doPrivileged( + String s = java.security.AccessController.doPrivileged( new GetPropertyAction("java.awt.syncLWRequests")); systemSyncLWRequests = (s != null && s.equals("true")); - s = (String) java.security.AccessController.doPrivileged( + s = java.security.AccessController.doPrivileged( new GetPropertyAction("java.awt.Window.locationByPlatform")); locationByPlatformProp = (s != null && s.equals("true")); } @@ -1378,7 +1378,7 @@ // make sure the privileged action is only // for getting the property! We don't want the // above checkTopLevelWindow call to always succeed! - warningString = (String) AccessController.doPrivileged( + warningString = AccessController.doPrivileged( new GetPropertyAction("awt.appletWarning", "Java Applet Window")); } diff -r 55a82eba1986 src/share/classes/java/awt/color/ICC_Profile.java --- a/src/share/classes/java/awt/color/ICC_Profile.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/awt/color/ICC_Profile.java Sat Feb 04 07:37:18 2012 +0000 @@ -921,9 +921,9 @@ */ private static ICC_Profile getStandardProfile(final String name) { - return (ICC_Profile) AccessController.doPrivileged( - new PrivilegedAction() { - public Object run() { + return AccessController.doPrivileged( + new PrivilegedAction() { + public ICC_Profile run() { ICC_Profile p = null; try { p = getInstance (name); diff -r 55a82eba1986 src/share/classes/java/beans/beancontext/BeanContextSupport.java --- a/src/share/classes/java/beans/beancontext/BeanContextSupport.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/beans/beancontext/BeanContextSupport.java Sat Feb 04 07:37:18 2012 +0000 @@ -1068,7 +1068,7 @@ if (serializable > 0 && this.equals(getBeanContextPeer())) readChildren(ois); - deserialize(ois, bcmListeners = new ArrayList(1)); + deserialize(ois, bcmListeners = new ArrayList<>(1)); } } @@ -1291,7 +1291,7 @@ protected synchronized void initialize() { children = new HashMap(serializable + 1); - bcmListeners = new ArrayList(1); + bcmListeners = new ArrayList<>(1); childPCL = new PropertyChangeListener() { @@ -1359,7 +1359,7 @@ * all accesses to the protected ArrayList bcmListeners field * shall be synchronized on that object. */ - protected transient ArrayList bcmListeners; + protected transient ArrayList bcmListeners; // diff -r 55a82eba1986 src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java --- a/src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java Sat Feb 04 07:37:18 2012 +0000 @@ -180,8 +180,7 @@ if (severity == null) { throw new NullPointerException("severity is null"); } - return super.put((PrinterStateReason) reason, - (Severity) severity); + return super.put(reason, severity); } /** diff -r 55a82eba1986 src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java --- a/src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java Sat Feb 04 07:37:18 2012 +0000 @@ -141,7 +141,7 @@ * Returns the string table for class ReferenceUriSchemesSupported. */ protected String[] getStringTable() { - return (String[])myStringTable.clone(); + return myStringTable.clone(); } /** diff -r 55a82eba1986 src/share/classes/sun/beans/infos/ComponentBeanInfo.java --- a/src/share/classes/sun/beans/infos/ComponentBeanInfo.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/sun/beans/infos/ComponentBeanInfo.java Sat Feb 04 07:37:18 2012 +0000 @@ -32,7 +32,7 @@ */ public class ComponentBeanInfo extends SimpleBeanInfo { - private static final Class beanClass = java.awt.Component.class; + private static final Class beanClass = java.awt.Component.class; public PropertyDescriptor[] getPropertyDescriptors() { try { From mikeb01 at gmail.com Sat Feb 4 04:52:02 2012 From: mikeb01 at gmail.com (Michael Barker) Date: Sat, 4 Feb 2012 12:52:02 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: <4F2D216E.8010605@oracle.com> References: <4F2A6213.4040707@oracle.com> <4F2D129E.7030705@oracle.com> <4F2D216E.8010605@oracle.com> Message-ID: > Oh, good catch Alan, I missed this. This part of the change should be > reversed ( at least in the context of warnings cleanup ). Should I switch it to a wild card (protected transient ArrayList bcmListeners) or just drop the modifications for that file? Mike. From mikeb01 at gmail.com Sat Feb 4 08:40:19 2012 From: mikeb01 at gmail.com (Michael Barker) Date: Sat, 4 Feb 2012 16:40:19 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: <12yonmlryq6ii4h38gpe1thd.1328370505882@email.android.com> References: <12yonmlryq6ii4h38gpe1thd.1328370505882@email.android.com> Message-ID: Patch with BeanSupportContext changes removed. Mike. On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote: > I think you should just drop the changes to this file. > > -Chris. > > Michael Barker wrote: > >>> Oh, good catch Alan, I missed this. This part of the change should be >>> reversed ( at least in the context of warnings cleanup ). >> >>Should I switch it to a wild card (protected transient ArrayList >>bcmListeners) or just drop the modifications for that file? >> >>Mike. -------------- next part -------------- diff -r 55a82eba1986 src/share/classes/java/awt/List.java --- a/src/share/classes/java/awt/List.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/awt/List.java Sat Feb 04 16:33:27 2012 +0000 @@ -115,7 +115,7 @@ * @see #addItem(String) * @see #getItem(int) */ - Vector items = new Vector(); + Vector items = new Vector<>(); /** * This field will represent the number of visible rows in the @@ -306,7 +306,7 @@ // to insure that it cannot be overridden by client subclasses. // DO NOT INVOKE CLIENT CODE ON THIS THREAD! final String getItemImpl(int index) { - return (String)items.elementAt(index); + return items.elementAt(index); } /** @@ -415,7 +415,7 @@ if (peer != null) { peer.removeAll(); } - items = new Vector(); + items = new Vector<>(); selected = new int[0]; } @@ -490,9 +490,9 @@ public synchronized int[] getSelectedIndexes() { ListPeer peer = (ListPeer)this.peer; if (peer != null) { - selected = ((ListPeer)peer).getSelectedIndexes(); + selected = peer.getSelectedIndexes(); } - return (int[])selected.clone(); + return selected.clone(); } /** @@ -908,7 +908,7 @@ * @since 1.4 */ public synchronized ItemListener[] getItemListeners() { - return (ItemListener[])(getListeners(ItemListener.class)); + return getListeners(ItemListener.class); } /** @@ -975,7 +975,7 @@ * @since 1.4 */ public synchronized ActionListener[] getActionListeners() { - return (ActionListener[])(getListeners(ActionListener.class)); + return getListeners(ActionListener.class); } /** diff -r 55a82eba1986 src/share/classes/java/awt/Window.java --- a/src/share/classes/java/awt/Window.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/awt/Window.java Sat Feb 04 16:33:27 2012 +0000 @@ -398,10 +398,10 @@ initIDs(); } - String s = (String) java.security.AccessController.doPrivileged( + String s = java.security.AccessController.doPrivileged( new GetPropertyAction("java.awt.syncLWRequests")); systemSyncLWRequests = (s != null && s.equals("true")); - s = (String) java.security.AccessController.doPrivileged( + s = java.security.AccessController.doPrivileged( new GetPropertyAction("java.awt.Window.locationByPlatform")); locationByPlatformProp = (s != null && s.equals("true")); } @@ -1378,7 +1378,7 @@ // make sure the privileged action is only // for getting the property! We don't want the // above checkTopLevelWindow call to always succeed! - warningString = (String) AccessController.doPrivileged( + warningString = AccessController.doPrivileged( new GetPropertyAction("awt.appletWarning", "Java Applet Window")); } diff -r 55a82eba1986 src/share/classes/java/awt/color/ICC_Profile.java --- a/src/share/classes/java/awt/color/ICC_Profile.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/java/awt/color/ICC_Profile.java Sat Feb 04 16:33:27 2012 +0000 @@ -921,9 +921,9 @@ */ private static ICC_Profile getStandardProfile(final String name) { - return (ICC_Profile) AccessController.doPrivileged( - new PrivilegedAction() { - public Object run() { + return AccessController.doPrivileged( + new PrivilegedAction() { + public ICC_Profile run() { ICC_Profile p = null; try { p = getInstance (name); diff -r 55a82eba1986 src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java --- a/src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java Sat Feb 04 16:33:27 2012 +0000 @@ -180,8 +180,7 @@ if (severity == null) { throw new NullPointerException("severity is null"); } - return super.put((PrinterStateReason) reason, - (Severity) severity); + return super.put(reason, severity); } /** diff -r 55a82eba1986 src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java --- a/src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java Sat Feb 04 16:33:27 2012 +0000 @@ -141,7 +141,7 @@ * Returns the string table for class ReferenceUriSchemesSupported. */ protected String[] getStringTable() { - return (String[])myStringTable.clone(); + return myStringTable.clone(); } /** diff -r 55a82eba1986 src/share/classes/sun/beans/infos/ComponentBeanInfo.java --- a/src/share/classes/sun/beans/infos/ComponentBeanInfo.java Wed Feb 01 16:00:39 2012 -0800 +++ b/src/share/classes/sun/beans/infos/ComponentBeanInfo.java Sat Feb 04 16:33:27 2012 +0000 @@ -32,7 +32,7 @@ */ public class ComponentBeanInfo extends SimpleBeanInfo { - private static final Class beanClass = java.awt.Component.class; + private static final Class beanClass = java.awt.Component.class; public PropertyDescriptor[] getPropertyDescriptors() { try { From anthony.petrov at oracle.com Mon Feb 6 04:40:13 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 06 Feb 2012 16:40:13 +0400 Subject: Review request for 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash In-Reply-To: References: <4F2BDF81.7050805@oracle.com> Message-ID: <4F2FCA2D.7030507@oracle.com> Hi Mike, Thanks for the review. Here's an updated fix: http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.1/ -- best regards, Anthony On 2/4/2012 3:12 AM, Mike Swingler wrote: > On Feb 3, 2012, at 5:22 AM, Anthony Petrov wrote: > >> Hello, >> >> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7142120 at: >> >> http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.0/ >> >> The fix is fairly simple: use NSScreen -frame instead of -visibleFrame. In this case the splash screen is positioned in the geometrical center of the screen. Visually this looks less pleasant (we may want to file an RFE in the future), but makes tests happy which is what we need right now. >> >> All the failing tests now pass well with this fix applied. > > Also [NSScreen mainScreen] gives you the screen that the "main" (aka "active") window is on. You really should use the 0'th screen to get the "primary" screen with the menu bar and the Dock. > > Regards, > Mike Swingler > Apple Inc. > From artem.ananiev at oracle.com Mon Feb 6 08:17:37 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 06 Feb 2012 20:17:37 +0400 Subject: Review request for 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash In-Reply-To: <4F2BDF81.7050805@oracle.com> References: <4F2BDF81.7050805@oracle.com> Message-ID: <4F2FFD21.90003@oracle.com> On 2/3/2012 5:22 PM, Anthony Petrov wrote: > Hello, > > Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7142120 at: > > http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.0/ > > The fix is fairly simple: use NSScreen -frame instead of -visibleFrame. > In this case the splash screen is positioned in the geometrical center > of the screen. Visually this looks less pleasant (we may want to file an > RFE in the future), but makes tests happy which is what we need right now. So what exactly do the tests expect? Does the test calculates the expected splashscreen position and compares to the value of SplashScreen.getBounds()? Does the latter method returns an incorrect value? What I see in JavaDoc is just: "The window is positioned at the center of the screen." It's unclear if the center of the screen should or should not include screen insets. Thanks, Artem > All the failing tests now pass well with this fix applied. > > -- > best regards, > Anthony From anthony.petrov at oracle.com Mon Feb 6 08:49:45 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 06 Feb 2012 20:49:45 +0400 Subject: Review request for 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash In-Reply-To: <4F2FFD21.90003@oracle.com> References: <4F2BDF81.7050805@oracle.com> <4F2FFD21.90003@oracle.com> Message-ID: <4F3004A9.6010904@oracle.com> Hi Artem, BTW, the updated webrev is at http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.1/ Please find my comments inline. On 2/6/2012 8:17 PM, Artem Ananiev wrote: > > On 2/3/2012 5:22 PM, Anthony Petrov wrote: >> Hello, >> >> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7142120 >> at: >> >> http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.0/ >> >> The fix is fairly simple: use NSScreen -frame instead of -visibleFrame. >> In this case the splash screen is positioned in the geometrical center >> of the screen. Visually this looks less pleasant (we may want to file an >> RFE in the future), but makes tests happy which is what we need right >> now. > > So what exactly do the tests expect? Does the test calculates the > expected splashscreen position and compares to the value of > SplashScreen.getBounds()? Does the latter method returns an incorrect > value? > > What I see in JavaDoc is just: "The window is positioned at the center > of the screen." It's unclear if the center of the screen should or > should not include screen insets. The test uses a 100x100 pixels image as a splash screen image. It then calls the GraphicsDevice.getDisplayMode().getWidth/Height() methods and expects to find the splash screen in the geometrical center of the screen (using SplashScreen.getBounds()). I.e. the screen insets are ignored. Given that the tests pass on Windows, Linux, and Solaris, it makes sense to implement the same behavior on Mac OS X as well. -- best regards, Anthony > > Thanks, > > Artem > >> All the failing tests now pass well with this fix applied. >> >> -- >> best regards, >> Anthony From oleg.pekhovskiy at oracle.com Mon Feb 6 10:46:16 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Mon, 06 Feb 2012 22:46:16 +0400 Subject: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Message-ID: <4F301FF8.70904@oracle.com> Hi guys, here is the fix for: http://bugs.sun.com/view_bug.do?bug_id=7143070 The main idea was eliminate test freezing on exit. So synchronization between threads on exit was rewritten. Patch with changes attached. Thanks, Oleg -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 7143070.patch Url: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120206/8c560726/7143070.patch From anthony.petrov at oracle.com Mon Feb 6 11:15:53 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 06 Feb 2012 23:15:53 +0400 Subject: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit In-Reply-To: <4F301FF8.70904@oracle.com> References: <4F301FF8.70904@oracle.com> Message-ID: <4F3026E9.3000306@oracle.com> Hi Oleg, Patches are hard to review due to an incomplete context of the changes. Could you please generate a webrev and publish it at http://cr.openjdk.java.net/ ? (see the web-site for more details) -- best regards, Anthony On 2/6/2012 10:46 PM, Oleg Pekhovskiy wrote: > Hi guys, > > here is the fix for: > http://bugs.sun.com/view_bug.do?bug_id=7143070 > > The main idea was eliminate test freezing on exit. > So synchronization between threads on exit was rewritten. > > Patch with changes attached. > > Thanks, > Oleg > From stuart.marks at oracle.com Mon Feb 6 14:53:50 2012 From: stuart.marks at oracle.com (Stuart Marks) Date: Mon, 06 Feb 2012 14:53:50 -0800 Subject: Warning Fixes from LJC Hack Session In-Reply-To: References: <12yonmlryq6ii4h38gpe1thd.1328370505882@email.android.com> Message-ID: <4F3059FE.3010504@oracle.com> Michael, Thanks for splitting up the patches and revising them in response to the review comments. I'm not yet entirely sure how to proceed with pushing these changes. I think Chris assumed that I would push these changes. Since these are in awt, printing, and beans, the changes might need to be pushed through a different forest (2D?) than the forest in which I usually do work (TL). In addition it might benefit from some additional review by members of the appropriate teams. Phil, you saw this go by earlier -- do you have a recommendation for how you'd like to proceed? I'm certainly happy to help out, but I'd end up pushing them into TL. Oh, and Alan, Chris, Anthony, thanks for your reviews and comments. s'marks On 2/4/12 8:40 AM, Michael Barker wrote: > Patch with BeanSupportContext changes removed. > > Mike. > > On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote: >> I think you should just drop the changes to this file. >> >> -Chris. >> >> Michael Barker wrote: >> >>>> Oh, good catch Alan, I missed this. This part of the change should be >>>> reversed ( at least in the context of warnings cleanup ). >>> >>> Should I switch it to a wild card (protected transient ArrayList >>> bcmListeners) or just drop the modifications for that file? >>> >>> Mike. From littlee at linux.vnet.ibm.com Tue Feb 7 01:17:29 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 07 Feb 2012 17:17:29 +0800 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform Message-ID: <4F30EC29.9020006@linux.vnet.ibm.com> Hi guys, Given a simple test case below[1], enableInputMethod(false) does not work. We can always invoke input method. [1] public class MyAWTTest extends JFrame { Component c; public MyAWTTest() { super("Single Frame --- AWT Frame"); setLayout(new FlowLayout()); c = new TextArea("TextArea component(No IM)"); c.enableInputMethods(false); c.setPreferredSize(new Dimension(400, 100)); add(c); c = new TextField("TextField component(No IM)", 52); c.enableInputMethods(false); add(c); setSize(850, 360); setVisible(true); setDefaultCloseOperation(EXIT_ON_CLOSE); } public static void main(String[] args) { SwingUtilities.invokeLater(new Runnable() { public void run() { new MyAWTTest(); } }); } } Patch @ http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.00/ The patch is mainly about: 1. Add a new method in the ComponentAccessor which help to escape the package restraints. Please check the changes in Component and AWTAccessor. 2. Remove the enableInputMethod(true) in the XTextAreaPeer and XTextFieldPeer and use areInputMethodEnabled to set jtext correctly. Please check the changes in XTextAreaPeer and XTextFieldPeer. I know it may not be a beautiful fix, but anyone interests in it? -- Yours Charles From anthony.petrov at oracle.com Tue Feb 7 03:29:32 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 07 Feb 2012 15:29:32 +0400 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F30EC29.9020006@linux.vnet.ibm.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> Message-ID: <4F310B1C.8080606@oracle.com> Hi Charles, The general idea of the fix is OK and the fix looks fine to me. However, there's still a problem if an app enables or disables Input Methods dynamically during the app's execution. The updated status of the property needs to be propagated to the jtext or xtext somehow. -- best regards, Anthony On 2/7/2012 1:17 PM, Charles Lee wrote: > Hi guys, > > Given a simple test case below[1], enableInputMethod(false) does not > work. We can always invoke input method. > [1] > public class MyAWTTest extends JFrame { > Component c; > > public MyAWTTest() { > super("Single Frame --- AWT Frame"); > > setLayout(new FlowLayout()); > > c = new TextArea("TextArea component(No IM)"); > c.enableInputMethods(false); > c.setPreferredSize(new Dimension(400, 100)); > add(c); > > c = new TextField("TextField component(No IM)", 52); > c.enableInputMethods(false); > add(c); > > setSize(850, 360); > setVisible(true); > > setDefaultCloseOperation(EXIT_ON_CLOSE); > } > > public static void main(String[] args) { > SwingUtilities.invokeLater(new Runnable() { > public void run() { > new MyAWTTest(); > } > }); > > } > } > > Patch @ http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.00/ > > > The patch is mainly about: > 1. Add a new method in the ComponentAccessor which help to escape the > package restraints. Please check the changes in Component and AWTAccessor. > 2. Remove the enableInputMethod(true) in the XTextAreaPeer and > XTextFieldPeer and use areInputMethodEnabled to set jtext correctly. > Please check the changes in XTextAreaPeer and XTextFieldPeer. > > I know it may not be a beautiful fix, but anyone interests in it? > From pavel.porvatov at oracle.com Wed Feb 8 04:16:29 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Wed, 08 Feb 2012 12:16:29 +0000 Subject: hg: jdk8/awt/jdk: 7138665: JOptionPane.getValue() unexpected change between JRE 1.6 and JRE 1.7 Message-ID: <20120208121658.262F9473E5@hg.openjdk.java.net> Changeset: 1880e8cc89b8 Author: rupashka Date: 2012-02-08 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1880e8cc89b8 7138665: JOptionPane.getValue() unexpected change between JRE 1.6 and JRE 1.7 Reviewed-by: alexp ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java + test/javax/swing/JOptionPane/7138665/bug7138665.java From oleg.pekhovskiy at oracle.com Wed Feb 8 04:56:50 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 08 Feb 2012 16:56:50 +0400 Subject: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Message-ID: <4F327112.2000808@oracle.com> Hi guys, here is the fix for: http://bugs.sun.com/view_bug.do?bug_id=7143070 webrev: http://cr.openjdk.java.net/~denis/7143070/webrev.03/ The main idea was eliminate test freezing on exit for some systems. So synchronization between threads on exit was rewritten. Thanks, Oleg From anthony.petrov at oracle.com Wed Feb 8 05:32:03 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 08 Feb 2012 17:32:03 +0400 Subject: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit In-Reply-To: <4F327112.2000808@oracle.com> References: <4F327112.2000808@oracle.com> Message-ID: <4F327953.9020208@oracle.com> Hi Oleg, Thanks for the webrev! > 60 if(!ret) > 61 throw new RuntimeException("Test failed!"); Please add a space after 'if' and put the throw statement into a {} block. Otherwise the fix looks good to me. -- best regards, Anthony On 2/8/2012 4:56 PM, Oleg Pekhovskiy wrote: > Hi guys, > > here is the fix for: > http://bugs.sun.com/view_bug.do?bug_id=7143070 > > webrev: > http://cr.openjdk.java.net/~denis/7143070/webrev.03/ > > > The main idea was eliminate test freezing on exit for some systems. > So synchronization between threads on exit was rewritten. > > Thanks, > Oleg From denis.fokin at sun.com Wed Feb 8 06:34:26 2012 From: denis.fokin at sun.com (denis.fokin at sun.com) Date: Wed, 08 Feb 2012 14:34:26 +0000 Subject: hg: jdk8/awt/jdk: 7132367: [macosx] ChoiceMouseWheelTest should be adapted for mac toolkit Message-ID: <20120208143447.615D3473E9@hg.openjdk.java.net> Changeset: d2e067142112 Author: bagiras Date: 2012-02-08 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d2e067142112 7132367: [macosx] ChoiceMouseWheelTest should be adapted for mac toolkit Reviewed-by: art ! test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java From oleg.pekhovskiy at oracle.com Wed Feb 8 07:55:46 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 08 Feb 2012 19:55:46 +0400 Subject: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Message-ID: <4F329B02.4030202@oracle.com> Hi guys, Please review the fix for CR: http://bugs.sun.com/view_bug.do?bug_id=7143070 webrev: http://cr.openjdk.java.net/~denis/7143070/webrev.04/ Added changes according to Anthony's comments: > 60 if(!ret) > 61 throw new RuntimeException("Test failed!"); Please add a space after 'if' and put the throw statement into a {} block. Thanks, Oleg -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120208/1dd5b9f4/attachment.html From anthony.petrov at oracle.com Wed Feb 8 09:02:17 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 08 Feb 2012 21:02:17 +0400 Subject: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit In-Reply-To: <4F329B02.4030202@oracle.com> References: <4F329B02.4030202@oracle.com> Message-ID: <4F32AA99.2070601@oracle.com> Looks great. Thanks! -- best regards, Anthony On 2/8/2012 7:55 PM, Oleg Pekhovskiy wrote: > Hi guys, > > Please review the fix for CR: > http://bugs.sun.com/view_bug.do?bug_id=7143070 > > webrev: > http://cr.openjdk.java.net/~denis/7143070/webrev.04/ > > > Added changes according to Anthony's comments: >> 60 if(!ret) >> 61 throw new RuntimeException("Test failed!"); > Please add a space after 'if' and put the throw statement into a {} block. > > > Thanks, > Oleg > > > From littlee at linux.vnet.ibm.com Wed Feb 8 22:18:48 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Thu, 09 Feb 2012 14:18:48 +0800 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F310B1C.8080606@oracle.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> <4F310B1C.8080606@oracle.com> Message-ID: <4F336548.3010506@linux.vnet.ibm.com> Hi Anthony, Thank you for your review. I have changed the test case a little, which will include a button to change the input method enable[1]. Is it the dynamic thing in your mind? This test case can work well on my original patch, but I found something interesting: Enable or disable jtext/xtext input method will have nothing to do with input method. Only enableInputMethod of target has influence. I was doing some code reading about this and find that (Please correct me if wrong) : 1. jtext/xtext process InputMethodEvent from XComponentPeer.handleEvent, and eventually goes to Component.processInputMethodEvent and JTextComponent.processInputMethodEvent. There are no route for input method enable check. 2. So when input method is enabled in TextArea/TextField, jtext should be work well. 3. And when input method is disabled by enableInputMethod(false), input context will be removed from notification, and there will be no more InputMethodEvent put into queue. So peer.handleEvent will never be invoked since e is KeyEvent in the dispatchEventImpl method of Component. So I conclude that set enable input method of jtext/xtext will have no effect and my original patch can be reduced a very simple one. Just remove the target.enableInputMethod(true) in both XTextFieldPeer and XTextAreaPeer. P.S. Why there is a jtext(JTextArea) in the XTextAreaPeer? I am missing some history here :-) [1] public class MyAWTTest extends JFrame { private final TextArea ta; private final TextField tf; private final AtomicBoolean flag; public MyAWTTest() { super("Single Frame --- AWT Frame"); setLayout(new FlowLayout()); ta = new TextArea("TextArea component(No IM)"); ta.enableInputMethods(false); ta.setPreferredSize(new Dimension(400, 100)); add(ta); tf = new TextField("TextField component(No IM)", 52); tf.enableInputMethods(false); add(tf); flag = new AtomicBoolean(false); Button button = new Button("Click me, change the world"); add(button); button.addActionListener(new ActionListener() { @Override public void actionPerformed(ActionEvent e) { if (!flag.get()) { ta.setText("TextArea component"); tf.setText("TextField component"); ta.enableInputMethods(true); tf.enableInputMethods(true); flag.set(true); } else { ta.setText("TextArea component (NO IM)"); tf.setText("TextField component (NO IM)"); ta.enableInputMethods(false); tf.enableInputMethods(false); flag.set(false); } } }); setSize(850, 360); setVisible(true); setDefaultCloseOperation(EXIT_ON_CLOSE); } public static void main(String[] args) { SwingUtilities.invokeLater(new Runnable() { public void run() { new MyAWTTest(); } }); } } On 02/07/2012 07:29 PM, Anthony Petrov wrote: > Hi Charles, > > The general idea of the fix is OK and the fix looks fine to me. > > However, there's still a problem if an app enables or disables Input > Methods dynamically during the app's execution. The updated status of > the property needs to be propagated to the jtext or xtext somehow. > > -- > best regards, > Anthony > > On 2/7/2012 1:17 PM, Charles Lee wrote: >> Hi guys, >> >> Given a simple test case below[1], enableInputMethod(false) does not >> work. We can always invoke input method. >> [1] >> public class MyAWTTest extends JFrame { >> Component c; >> >> public MyAWTTest() { >> super("Single Frame --- AWT Frame"); >> >> setLayout(new FlowLayout()); >> >> c = new TextArea("TextArea component(No IM)"); >> c.enableInputMethods(false); >> c.setPreferredSize(new Dimension(400, 100)); >> add(c); >> >> c = new TextField("TextField component(No IM)", 52); >> c.enableInputMethods(false); >> add(c); >> >> setSize(850, 360); >> setVisible(true); >> >> setDefaultCloseOperation(EXIT_ON_CLOSE); >> } >> >> public static void main(String[] args) { >> SwingUtilities.invokeLater(new Runnable() { >> public void run() { >> new MyAWTTest(); >> } >> }); >> >> } >> } >> >> Patch @ http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.00/ >> >> >> The patch is mainly about: >> 1. Add a new method in the ComponentAccessor which help to escape the >> package restraints. Please check the changes in Component and >> AWTAccessor. >> 2. Remove the enableInputMethod(true) in the XTextAreaPeer and >> XTextFieldPeer and use areInputMethodEnabled to set jtext correctly. >> Please check the changes in XTextAreaPeer and XTextFieldPeer. >> >> I know it may not be a beautiful fix, but anyone interests in it? >> > -- Yours Charles From pavel.porvatov at oracle.com Thu Feb 9 02:23:00 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Thu, 09 Feb 2012 10:23:00 +0000 Subject: hg: jdk8/awt/jdk: 7143857: Memory leak in javax.swing.plaf.synth.SynthTreeUI Message-ID: <20120209102402.3E4A04740C@hg.openjdk.java.net> Changeset: d43447758eba Author: rupashka Date: 2012-02-09 14:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d43447758eba 7143857: Memory leak in javax.swing.plaf.synth.SynthTreeUI Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java From alexey.utkin at oracle.com Thu Feb 9 04:37:57 2012 From: alexey.utkin at oracle.com (Alexey Utkin) Date: Thu, 09 Feb 2012 16:37:57 +0400 Subject: [7u4] Code Review Request for CR 7082294 - nsk/regression/b4265661 crashes on windows - approved In-Reply-To: <4F2C0E0D.6090906@oracle.com> References: <4F2C0E0D.6090906@oracle.com> Message-ID: <4F33BE25.9040304@oracle.com> Looks good for me. -uta On 2/3/2012 20:40, Oleg Pekhovskiy wrote: > Hi guys! > > Here is the description of CR: > http://bugs.sun.com/view_bug.do?bug_id=7082294 > > Patch with changes attached. > > Description of the fix: > Sometimes execution of AwtObjectList::Cleanup() could be delayed by > posting WM_AWT_OBJECTLISTCLEANUP message. > From the other side this method is called from AwtToolkit::Dispose(). > There AwtObjectList::Cleanup() is followed by AwtFont::Cleanup(). > Thus, sometimes we could have the situation when AwtFont::Cleanup() is > called before the main functionality of AwtObjectList::Cleanup(). > It means that all HFONT objects would be deleted from AwtFontCache. > So when AwtFont::Dispose() would be called from AwtObjectList::Cleanup() > it would not find HFONT in AwtFontCache and would try to delete HFONT > (that is deleted in AwtFontCache) once again. > There is also a custom message pump in AwtToolkit::Dispose() that allows > posted WM_AWT_OBJECTLISTCLEANUP be handled. > If we move AwtFont::Cleanup() right after that message pump we guarantee > that AwtObjectList::Cleanup() would always be called before > AwtFont::Cleanup(). > That what my fix is about. > > PS: I also left my changes in AwtFont to emilinate invalid HFONT usage > and access violation probability between AwtFont::Dispose() and > AwtFont::~AwtFont() calls. > > PPS: This implementation is a kind of workaround for 7u4. As for JDK 8 > - font caching should be improved. > > Thanks, > Oleg. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120209/d5552e69/attachment.html From pavel.porvatov at oracle.com Thu Feb 9 06:28:03 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Thu, 09 Feb 2012 14:28:03 +0000 Subject: hg: jdk8/awt/jdk: 7142955: DefaultTreeCellRenderer doesn't honor 'Tree.rendererFillBackground' LAF property Message-ID: <20120209142830.C55234740F@hg.openjdk.java.net> Changeset: 403e3bb8a162 Author: rupashka Date: 2012-02-09 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/403e3bb8a162 7142955: DefaultTreeCellRenderer doesn't honor 'Tree.rendererFillBackground' LAF property Reviewed-by: malenkov ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java + test/javax/swing/tree/DefaultTreeCellRenderer/7142955/bug7142955.java From chris.hegarty at oracle.com Fri Feb 10 04:46:53 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 10 Feb 2012 12:46:53 +0000 Subject: hg: jdk8/awt/jdk: 7144475: fix some warnings in java.awt, javax.print.attribute.standard, and sun.beans.infos Message-ID: <20120210124713.2F2FE4745A@hg.openjdk.java.net> Changeset: a3b50244bd10 Author: chegar Date: 2012-02-10 11:03 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a3b50244bd10 7144475: fix some warnings in java.awt, javax.print.attribute.standard, and sun.beans.infos Reviewed-by: chegar, prr, alanb, anthony Contributed-by: Prasannaa , Martijn Verburg , Goerge Albrecht , Graham Allan , Iordanis Giannakakis , Jose Llarena , Abrahamn Marin Perez ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java ! src/share/classes/sun/beans/infos/ComponentBeanInfo.java From chris.hegarty at oracle.com Fri Feb 10 05:46:46 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 10 Feb 2012 13:46:46 +0000 Subject: Warning Fixes from LJC Hack Session In-Reply-To: References: <4F2A6213.4040707@oracle.com> <4F2CE850.9090604@oracle.com> <4F348ACC.7020707@oracle.com> Message-ID: <4F351FC6.4040307@oracle.com> On 02/10/12 03:58 AM, Michael Barker wrote: > Hi Stuart, > > Thank you for the reviewing the patches. I forgot about the > Contributed-by header, sorry about that. That's one I'll put on the > list to make sure I have sorted next time. I've split the > contributors up according to the two patches supplied. See below: > > AWT, beans& printing: To close the loop on this, I pushed the AWT/bean/print changes to the jdk8/awt/tl repo. http://mail.openjdk.java.net/pipermail/awt-dev/2012-February/002252.html It looks like Stuart will take care of the ones going through jdk8/tl/jdk. -Chris. > > Contributed-by: Prasannaa, Martijn Verburg > , Goerge Albrecht, > Graham Allan, Iordanis Giannakakis > , Jose Llarena, > Abraham Mar?n P?rez > > For all of the remaining code: > > Contributed-by: Mani Sarkar, Michael Barker > , Carl Jokl, Dinuk > Weerasinghe, Markus Stoy > , Tom Anderson > > I hope these patches are providing value for the OpenJDK team as we > plan to do more. I know that there is a bit of a cost for you guys > in terms of reviewing and merging. I'm starting to get a better > picture of the type of changes that will go in smoothly and those that > will require updates to the patches. > > Mike. > > On Fri, Feb 10, 2012 at 3:11 AM, Stuart Marks wrote: >> Hi Mike, >> >> I finally got back to this. These fixes look pretty good and knock off 100+ >> additional warnings! I've filed bug 7143230 [1] to track this. I took a look >> through the code and I took the liberty of fixing up a few very minor >> things: >> >> 1. Removed unnecessary casts to ZipEntry in JarVerifier.java, suggested by >> Chirs Hegarty [2]. (These aren't strictly redundant casts, and don't cause >> warnings, as the origin types are and JarEntry. >> However, they are unnecessary.) >> >> 2. Fixed typo in unrelated comment at line 50 in SignatureFile.java that I >> happened to notice. >> >> 3. Removed parentheses from expressions in MemoryMonitor.java lines 216, 219 >> which are now unnecessary since the cast has been removed. >> >> No need to issue another patch; I'll just include these changes when I push >> the changeset. >> >> Which brings me to the topic that we discussed before when I pushed LJC's >> previous round of warnings fixes, that is, how the Contributed-by line in >> the commit message should be formatted. (See [3] for the requirements.) For >> reference, here's what the changeset comment for the previous set of LJC >> fixes ended up looking like: >> >> >> changeset: 4802:4f0f9f9c4892 >> user: smarks >> date: Wed Dec 07 12:12:50 2011 -0800 >> description: >> 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip >> Reviewed-by: alanb, dholmes, forax, sherman, smarks >> Contributed-by: Prasannaa, Martijn Verburg >> , Goerge_Albrecht, >> Graham Allan, Michael Barker >> >> >> >> It looks like a different set of people contributed to this round of fixes. >> If you could send me the list of names and email addresses, I can format >> them into the commit message and push the fix. >> >> Thanks! >> >> s'marks >> >> >> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143230 >> >> [2] >> http://mail.openjdk.java.net/pipermail/jdk8-dev/2012-February/000715.html >> >> [3] http://openjdk.java.net/guide/producingChangeset.html >> >> >> On 2/4/12 12:12 AM, Chris Hegarty wrote: >>> >>> Thanks for this, looks great. >>> >>> Good to see JarVerifier getting some much needed TLC. >>> >>> -Chris. >>> >>> >>> On 02/ 4/12 07:50 AM, Michael Barker wrote: >>>>> >>>>> I see R?mi has suggested a slice& dice but I think that's a bit too much >>>>> work for the changes involved. Instead I would suggest a simple split, >>>>> send >>>>> the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else >>>>> to >>>>> core-libs-dev. >>>> >>>> >>>> Attached is the patch that contains "everthing else" from LJC warning >>>> fixes hack session. >>>> >>>> Mike. From alexandr.scherbatiy at oracle.com Fri Feb 10 06:34:19 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Fri, 10 Feb 2012 14:34:19 +0000 Subject: hg: jdk8/awt/jdk: 7109991: SwingUtilities.isXMouseButton behaves unexpectedly starting from JDK8 b08 Message-ID: <20120210143438.A9D534745B@hg.openjdk.java.net> Changeset: 55adee49df8e Author: alexsch Date: 2012-02-10 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/55adee49df8e 7109991: SwingUtilities.isXMouseButton behaves unexpectedly starting from JDK8 b08 Reviewed-by: rupashka ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/MouseEvent.java From lana.steuck at oracle.com Fri Feb 10 10:36:26 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:36:26 +0000 Subject: hg: jdk8/awt: 5 new changesets Message-ID: <20120210183626.DA7564745F@hg.openjdk.java.net> Changeset: 5350cd6e0cc0 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/5350cd6e0cc0 Added tag jdk8-b24 for changeset 1a5f1d6b98d6 ! .hgtags Changeset: 0f653ee93477 Author: alanb Date: 2012-01-24 09:08 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/rev/0f653ee93477 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties Changeset: bd3fcc98c5d2 Author: lana Date: 2012-01-28 20:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/bd3fcc98c5d2 Merge Changeset: 221a378e06a3 Author: lana Date: 2012-02-07 10:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/221a378e06a3 Merge Changeset: 2accafff224a Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/2accafff224a Added tag jdk8-b25 for changeset 221a378e06a3 ! .hgtags From lana.steuck at oracle.com Fri Feb 10 10:36:28 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:36:28 +0000 Subject: hg: jdk8/awt/jaxp: 2 new changesets Message-ID: <20120210183628.C1B9547460@hg.openjdk.java.net> Changeset: bb694c151fc7 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/bb694c151fc7 Added tag jdk8-b24 for changeset 7836655e2495 ! .hgtags Changeset: dbb7283c197b Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/dbb7283c197b Added tag jdk8-b25 for changeset bb694c151fc7 ! .hgtags From lana.steuck at oracle.com Fri Feb 10 10:36:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:36:24 +0000 Subject: hg: jdk8/awt/corba: 2 new changesets Message-ID: <20120210183631.0C27C47461@hg.openjdk.java.net> Changeset: e45d6b406d5f Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/e45d6b406d5f Added tag jdk8-b24 for changeset b98f0e6dddf9 ! .hgtags Changeset: 79f709a099f4 Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/79f709a099f4 Added tag jdk8-b25 for changeset e45d6b406d5f ! .hgtags From lana.steuck at oracle.com Fri Feb 10 10:36:32 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:36:32 +0000 Subject: hg: jdk8/awt/jaxws: 2 new changesets Message-ID: <20120210183633.0030447462@hg.openjdk.java.net> Changeset: b376d901e006 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/b376d901e006 Added tag jdk8-b24 for changeset e0d90803439b ! .hgtags Changeset: 3518639eab6c Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/3518639eab6c Added tag jdk8-b25 for changeset b376d901e006 ! .hgtags From lana.steuck at oracle.com Fri Feb 10 10:36:37 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:36:37 +0000 Subject: hg: jdk8/awt/langtools: 8 new changesets Message-ID: <20120210183718.6824B47463@hg.openjdk.java.net> Changeset: 5a784dab75f1 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/5a784dab75f1 Added tag jdk8-b24 for changeset 6c9d21ca92c4 ! .hgtags Changeset: 51fb17abfc32 Author: mcimadamore Date: 2012-01-24 17:52 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check routine Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java Changeset: ac36176b7de0 Author: jjh Date: 2012-01-24 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/ac36176b7de0 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/main/Main.java + test/tools/javah/T7126832/T7126832.java + test/tools/javah/T7126832/java.java Changeset: d16b464e742c Author: jjh Date: 2012-01-24 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d16b464e742c 7129225: javac fails to run annotation processors when star import of package of gensrc Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/7129225/Anno.java + test/tools/javac/7129225/AnnoProcessor.java + test/tools/javac/7129225/NegTest.ref + test/tools/javac/7129225/TestImportStar.java + test/tools/javac/7129225/TestImportStar.ref Changeset: 332dfa0f91df Author: jjh Date: 2012-01-25 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/332dfa0f91df 7133314: The regression test for 7129225 fails when run with jtreg -samevm or jtreg -agentvm Reviewed-by: jjg ! test/tools/javac/7129225/AnnoProcessor.java ! test/tools/javac/7129225/NegTest.ref ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref Changeset: 7d412606d641 Author: lana Date: 2012-01-28 20:42 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/7d412606d641 Merge Changeset: 520c30f85bb5 Author: lana Date: 2012-02-07 10:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/520c30f85bb5 Merge Changeset: b556aa8a99c3 Author: katleman Date: 2012-02-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b556aa8a99c3 Added tag jdk8-b25 for changeset 520c30f85bb5 ! .hgtags From lana.steuck at oracle.com Fri Feb 10 10:37:09 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:37:09 +0000 Subject: hg: jdk8/awt/hotspot: 74 new changesets Message-ID: <20120210184055.55F9447464@hg.openjdk.java.net> Changeset: 5f3fcd591768 Author: amurillo Date: 2012-01-20 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5f3fcd591768 7131979: new hotspot build - hs23-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 53a127075045 Author: kvn Date: 2012-01-20 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/53a127075045 7131302: connode.cpp:205 Error: ShouldNotReachHere() Summary: Add Value() methods to short and byte Load nodes to truncate constants which does not fit. Reviewed-by: jrose ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 9164b8236699 Author: iveresov Date: 2012-01-20 15:02 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9164b8236699 7131028: Switch statement takes wrong path Summary: Pass correct type to branch in LIRGenerator::do_SwitchRanges() Reviewed-by: kvn, never ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: a81f60ddab06 Author: never Date: 2012-01-22 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a81f60ddab06 7130676: Tiered: assert(bci == 0 || 0<= bci && bciis_loaded() Summary: handle not loaded array klass in Parse::do_checkcast(). Reviewed-by: kvn, never ! src/share/vm/opto/parseHelper.cpp Changeset: 5dbed2f542ff Author: bdelsart Date: 2012-01-26 16:49 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5dbed2f542ff 7120468: SPARC/x86: use frame::describe to enhance trace_method_handle Summary: improvements of TraceMethodHandles for JSR292 Reviewed-by: never, twisti ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/zero/vm/frame_zero.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp Changeset: 20334ed5ed3c Author: iveresov Date: 2012-01-26 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/20334ed5ed3c 7131259: compile_method and CompilationPolicy::event shouldn't be declared TRAPS Summary: Make sure that CompilationPolicy::event() doesn't throw exceptions Reviewed-by: kvn, never ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp ! src/share/vm/utilities/exceptions.hpp Changeset: 072384a61312 Author: jrose Date: 2012-01-26 19:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/072384a61312 Merge Changeset: 2e966d967c5c Author: johnc Date: 2012-01-13 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2e966d967c5c 7121547: G1: High number mispredicted branches while iterating over the marking bitmap Summary: There is a high number of mispredicted branches associated with calling BitMap::iteratate() from within CMBitMapRO::iterate(). Implement a version of CMBitMapRO::iterate() directly using inline-able routines. Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/utilities/bitMap.inline.hpp Changeset: 851b58c26def Author: brutisso Date: 2012-01-16 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/851b58c26def 7130334: G1: Change comments and error messages that refer to CMS in g1/concurrentMark.cpp/hpp Summary: Removed references to CMS in the concurrentMark.cpp/hpp files. Reviewed-by: tonyp, jmasa, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 9509c20bba28 Author: brutisso Date: 2012-01-16 22:10 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9509c20bba28 6976060: G1: humongous object allocations should initiate marking cycles when necessary Reviewed-by: tonyp, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 0b3d1ec6eaee Author: tonyp Date: 2012-01-18 10:30 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0b3d1ec6eaee 7097586: G1: improve the per-space output when using jmap -heap Summary: Extend the jmap -heap output for G1 to include some more G1-specific information. Reviewed-by: brutisso, johnc, poonam ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1CollectedHeap.java ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1MonitoringSupport.java + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/HeapRegionSetBase.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp Changeset: 7ca7be5a6a0b Author: johnc Date: 2012-01-17 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7ca7be5a6a0b 7129271: G1: Interference from multiple threads in PrintGC/PrintGCDetails output Summary: During an initial mark pause, signal the Concurrent Mark thread after the pause output from PrintGC/PrintGCDetails is complete. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: a8a126788ea0 Author: tonyp Date: 2012-01-19 09:13 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a8a126788ea0 7078465: G1: Don't use the undefined value (-1) for the G1 old memory pool max size Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp ! src/share/vm/services/g1MemoryPool.hpp Changeset: 57025542827f Author: brutisso Date: 2012-01-20 18:01 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/57025542827f 7131791: G1: Asserts in nightly testing due to 6976060 Summary: Create a handle and fake an object to make sure that we don't loose the memory we just allocated Reviewed-by: tonyp, stefank ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 6a78aa6ac1ff Author: brutisso Date: 2012-01-23 20:36 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6a78aa6ac1ff 7132311: G1: assert((s == klass->oop_size(this)) || (Universe::heap()->is_gc_active() && ((is_typeArray()... Summary: Move the check for when to call collect() to before we do a humongous object allocation Reviewed-by: stefank, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 877914d90c57 Author: tonyp Date: 2012-01-24 17:08 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/877914d90c57 7132398: G1: java.lang.IllegalArgumentException: Invalid threshold: 9223372036854775807 > max (1073741824) Summary: Was not passing the right old pool max to the memory pool constructor in the fix for 7078465. Reviewed-by: brutisso, johnc ! src/share/vm/services/g1MemoryPool.cpp Changeset: d30fa85f9994 Author: johnc Date: 2012-01-12 00:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d30fa85f9994 6484965: G1: piggy-back liveness accounting phase on marking Summary: Remove the separate counting phase of concurrent marking by tracking the amount of marked bytes and the cards spanned by marked objects in marking task/worker thread local data structures, which are updated as individual objects are marked. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: eff609af17d7 Author: tonyp Date: 2012-01-25 12:58 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/eff609af17d7 7127706: G1: re-enable survivors during the initial-mark pause Summary: Re-enable survivors during the initial-mark pause. Afterwards, the concurrent marking threads have to scan them and mark everything reachable from them. The next GC will have to wait for the survivors to be scanned. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: a5244e07b761 Author: jcoomes Date: 2012-01-25 21:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a5244e07b761 7112413: JVM Crash, possibly GC-related Summary: disable UseAdaptiveSizePolicy with the CMS and ParNew Reviewed-by: johnc, brutisso ! src/share/vm/runtime/arguments.cpp Changeset: b4ebad3520bb Author: johnc Date: 2012-01-26 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b4ebad3520bb 7133038: G1: Some small profile based optimizations Summary: Some minor profile based optimizations. Reduce the number of branches and branch mispredicts by removing some virtual calls, through closure specalization, and refactoring some conditional statements. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp Changeset: 0a10d80352d5 Author: brutisso Date: 2012-01-27 09:04 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0a10d80352d5 Merge - src/os/bsd/vm/decoder_bsd.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: af739d5ab23c Author: bpittore Date: 2012-01-21 23:02 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/af739d5ab23c 6972759: Step over not working after thrown exception and Pop Summary: reset jvmtithreadstate exception state after frame pop and forceearlyreturn processed Reviewed-by: minqi, dholmes, dlong Contributed-by: bill.pittore at oracle.com ! src/share/vm/prims/jvmtiThreadState.cpp ! src/share/vm/prims/jvmtiThreadState.hpp Changeset: 583b428aa858 Author: coleenp Date: 2012-01-23 17:45 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/583b428aa858 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: d6660fedbab5 Author: phh Date: 2012-01-24 14:07 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d6660fedbab5 7126732: MAC: Require Mac OS X builds/tests for JPRT integrate jobs for HotSpot Summary: Modify jprt.properties to run OSX builds and tests. Reviewed-by: dcubed, kamg, ohair, dholmes Contributed-by: james.melvin at oracle.com ! make/jprt.properties Changeset: bf864f701a4a Author: dsamersoff Date: 2012-01-25 02:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bf864f701a4a 7066129: GarbageCollectorMXBean#getLastGcInfo leaks native memory Summary: Make GCStatInfo a resource object Reviewed-by: phh, coleenp ! src/share/vm/services/gcNotifier.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryManager.hpp Changeset: df88f58f3b61 Author: dsamersoff Date: 2012-01-24 20:15 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/df88f58f3b61 Merge Changeset: e8a4934564b2 Author: phh Date: 2012-01-24 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e8a4934564b2 7125793: MAC: test_gamma should always work Summary: Fix gamma launcher on Mac OS X and reconcile test_gamma script on Unix platforms Reviewed-by: dcubed, ohair, jcoomes, dholmes, ksrini Contributed-by: james.melvin at oracle.com ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/buildtree.make ! make/solaris/makefiles/buildtree.make ! src/os/bsd/vm/os_bsd.cpp ! src/os/posix/launcher/java_md.c Changeset: 78dadb7b16ab Author: phh Date: 2012-01-25 01:16 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/78dadb7b16ab Merge Changeset: d708a8cdd022 Author: kamg Date: 2012-01-25 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d708a8cdd022 Merge Changeset: 520830f632e7 Author: fparain Date: 2012-01-25 10:32 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/520830f632e7 7131346: Parsing of boolean arguments to diagnostic commands is broken Reviewed-by: dholmes, dcubed ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 24ec1a6d6ef3 Author: fparain Date: 2012-01-25 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/24ec1a6d6ef3 Merge Changeset: a42c07c38c47 Author: dsamersoff Date: 2012-01-25 21:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a42c07c38c47 7132515: Add dcmd to manage UnlockingCommercialFeature flag Summary: Added dcmd to unlock or check status of UnlockingCommercialFeature flag Reviewed-by: fparain, rottenha ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp + src/share/vm/services/diagnosticCommand_ext.hpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/management.cpp Changeset: 6d00795f99a1 Author: dsamersoff Date: 2012-01-25 15:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6d00795f99a1 Merge Changeset: 6db63e782d3d Author: dsamersoff Date: 2012-01-25 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6db63e782d3d Merge Changeset: de268c8a8075 Author: phh Date: 2012-01-26 20:06 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/de268c8a8075 7082553: Interpret Thread.setPriority(Thread.MAX_PRIORITY) to mean FX60 on Solaris 10 and 11 Summary: Add CriticalPriority == MaxPriority+1 and enable scheduling class as well as thread priority to change on Solaris. Reviewed-by: dholmes, dcubed ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp Changeset: bf5da1648543 Author: kamg Date: 2012-01-27 10:42 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bf5da1648543 Merge ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp Changeset: 9e177d44b10f Author: amurillo Date: 2012-01-27 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9e177d44b10f Merge Changeset: a80fd4f45d7a Author: amurillo Date: 2012-01-27 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a80fd4f45d7a Added tag hs23-b12 for changeset 9e177d44b10f ! .hgtags Changeset: 905945c5913e Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/905945c5913e Added tag jdk8-b24 for changeset a80fd4f45d7a ! .hgtags Changeset: 9f1c2b7cdfb6 Author: amurillo Date: 2012-01-27 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9f1c2b7cdfb6 7135385: new hotspot build - hs23-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 34e2e90e7182 Author: rbackman Date: 2012-01-24 14:48 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/34e2e90e7182 7130476: Remove use of #ifdef TRACE_DEFINE_KLASS_TRACE_ID from klass.hpp Reviewed-by: kamg, phh, dsamersoff Contributed-by: Rickard Backman ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/trace/traceMacros.hpp Changeset: 26a08cbbf042 Author: stefank Date: 2012-01-27 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/26a08cbbf042 7022100: Method annotations are incorrectly set when redefining classes Summary: Changed to the correct annotation arrays Reviewed-by: kamg, dholmes, sla ! src/share/vm/oops/instanceKlass.hpp Changeset: f457154eee8b Author: brutisso Date: 2012-01-30 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f457154eee8b 7140882: Don't return booleans from methods returning pointers Summary: Changed "return false" to "return NULL" Reviewed-by: dholmes, rottenha Contributed-by: dbhole at redhat.com ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/opto/loopnode.cpp Changeset: d96c130c9399 Author: brutisso Date: 2012-01-30 05:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d96c130c9399 Merge Changeset: b2cd0ee8f778 Author: acorn Date: 2012-01-30 23:27 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b2cd0ee8f778 7114376: Make system dictionary hashtable bucket array size configurable Summary: 7u4 new experimental flag -XX:PredictedClassLoadedCount=# Reviewed-by: dholmes, phh, dcubed ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/hashtable.hpp Changeset: 481a9443f721 Author: phh Date: 2012-02-01 15:01 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/481a9443f721 7123386: RFE: Preserve universal builds of HotSpot on Mac OS X Summary: Add support for packaging HotSpot JVM builds in universal binaries Reviewed-by: dholmes, kamg, dcubed, phh Contributed-by: james.melvin at oracle.com ! make/Makefile ! make/bsd/makefiles/defs.make + make/bsd/makefiles/universal.gmk ! make/defs.make Changeset: 527cf36f4a20 Author: fparain Date: 2012-02-03 14:04 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/527cf36f4a20 Merge ! src/share/vm/runtime/globals.hpp Changeset: 1a2723f7ad8e Author: never Date: 2012-01-29 16:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1a2723f7ad8e 7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale Reviewed-by: kvn, iveresov, dholmes ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5f17b16b3219 Author: iveresov Date: 2012-01-30 19:37 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5f17b16b3219 7141059: 7116795 broke pure c2 builds Summary: Fix pure c2 builds Reviewed-by: kvn, brutisso, never ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5ed8f599a788 Author: kvn Date: 2012-01-31 07:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5ed8f599a788 7140924: SIGSEGV in compiled code for sun.awt.X11.XDecoratedPeer.updateMinSizeHints Summary: Use unknown_obj instead of empty_map for NULL or Constant Pool object constants in bytecode Escape Analyzer. Reviewed-by: iveresov, never ! src/share/vm/ci/bcEscapeAnalyzer.cpp Changeset: 2f5980b127e3 Author: twisti Date: 2012-01-31 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2f5980b127e3 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f067b4e0e04b Author: roland Date: 2012-02-01 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f067b4e0e04b 7090976: Eclipse/CDT causes a JVM crash while indexing C++ code Summary: too optimistic inlining decision confuses local value numbering. Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_ValueMap.cpp + test/compiler/7090976/Test7090976.java Changeset: aa3d708d67c4 Author: never Date: 2012-02-01 07:59 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/aa3d708d67c4 7141200: log some interesting information in ring buffers for crashes Reviewed-by: kvn, jrose, kevinw, brutisso, twisti, jmasa ! src/os/windows/vm/os_windows.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 0382d2b469b2 Author: never Date: 2012-02-01 16:57 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0382d2b469b2 7013347: allow crypto functions to be called inline to enhance performance Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/nativeLookup.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 392a3f07d567 Author: twisti Date: 2012-02-02 09:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/392a3f07d567 7141637: JSR 292: MH spread invoker crashes with NULL argument on x86_32 Reviewed-by: twisti Contributed-by: Volker Simonis ! src/cpu/x86/vm/methodHandles_x86.cpp + test/compiler/7141637/SpreadNullArg.java Changeset: 379b22e03c32 Author: jcoomes Date: 2012-02-03 12:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/379b22e03c32 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/globals.hpp Changeset: be649fefcdc2 Author: stefank Date: 2012-01-27 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/be649fefcdc2 7134655: Crash in reference processing when doing single-threaded remarking Summary: Temporarily disabled multi-threaded reference discovery when entering a single-threaded remark phase. Reviewed-by: brutisso, tonyp, jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: c03e06373b47 Author: stefank Date: 2012-01-28 01:15 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c03e06373b47 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: 2eeebe4b4213 Author: brutisso Date: 2012-01-30 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2eeebe4b4213 7140909: Visual Studio project builds broken: need to define INCLUDE_TRACE Summary: Add define of INCLUDE_TRACE Reviewed-by: sla, kamg ! src/share/tools/ProjectCreator/BuildConfig.java Changeset: 24cae3e4cbaa Author: jcoomes Date: 2012-02-02 16:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/24cae3e4cbaa 6679764: enable parallel compaction by default Reviewed-by: phh, jmasa ! src/share/vm/runtime/arguments.cpp Changeset: 5ab44ceb4d57 Author: jcoomes Date: 2012-02-03 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5ab44ceb4d57 Merge Changeset: b22de8247499 Author: amurillo Date: 2012-02-03 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b22de8247499 Merge Changeset: 4e9b30938cbf Author: amurillo Date: 2012-02-03 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4e9b30938cbf Added tag hs23-b13 for changeset b22de8247499 ! .hgtags Changeset: 1f22b536808b Author: amurillo Date: 2012-02-03 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1f22b536808b 7142393: new hotspot build - hs23-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 585feefad374 Author: phh Date: 2012-02-06 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/585feefad374 7142852: MAC: Comment out JPRT jbb tests on Mac OS X until 7142850 is resolved Summary: Comment out JPRT jbb tests on Mac OS X until GUI hang can be fixed Reviewed-by: dholmes, brutisso, phh Contributed-by: james.melvin at oracle.com ! make/jprt.properties Changeset: 64b46f975ab8 Author: phh Date: 2012-02-06 14:02 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/64b46f975ab8 7142616: MAC: Honor ALT_EXPORT_PATH overrides from JDK control builds Summary: Fix EXPORT_PATH overrides on Mac OS X and only change default. Reviewed-by: phh, dcubed Contributed-by: james.melvin at oracle.com ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/universal.gmk Changeset: 9ad8feb5afbd Author: amurillo Date: 2012-02-06 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9ad8feb5afbd Added tag hs23-b14 for changeset 64b46f975ab8 ! .hgtags Changeset: aaceb8ddf2e2 Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/aaceb8ddf2e2 Added tag jdk8-b25 for changeset 9ad8feb5afbd ! .hgtags From lana.steuck at oracle.com Fri Feb 10 10:37:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:37:24 +0000 Subject: hg: jdk8/awt/jdk: 35 new changesets Message-ID: <20120210184439.562064746A@hg.openjdk.java.net> Changeset: 8da468cf037b Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8da468cf037b Added tag jdk8-b24 for changeset 34029a0c69bb ! .hgtags Changeset: ad9f1c8970da Author: prr Date: 2012-01-19 12:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ad9f1c8970da 7131153: GetDC called way too many times - causes bad performance. Reviewed-by: igor, jgodinez ! src/windows/native/sun/font/fontpath.c Changeset: f7dda4bbf1f9 Author: lana Date: 2012-01-28 22:47 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f7dda4bbf1f9 Merge - test/java/io/File/BlockIsDirectory.java Changeset: 363086137375 Author: lana Date: 2012-01-31 19:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/363086137375 Merge Changeset: 313da5d059bf Author: valeriep Date: 2012-01-19 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/313da5d059bf 7092825: javax.crypto.Cipher.Transform.patternCache is synchronizedMap and became scalability bottleneck. Summary: Changed patternCache from synchronizedMap to ConcurrentHashMap. Reviewed-by: mullan ! src/share/classes/javax/crypto/Cipher.java Changeset: 71200c517524 Author: darcy Date: 2012-01-20 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/71200c517524 4504839: Java libraries should provide support for unsigned integer arithmetic 4215269: Some Integer.toHexString(int) results cannot be decoded back to an int 6322074: Converting integers to string as if unsigned Reviewed-by: mduigou, emcmanus, flar ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java + test/java/lang/Integer/Unsigned.java + test/java/lang/Long/Unsigned.java Changeset: d383b5d128e3 Author: xuelei Date: 2012-01-23 04:44 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d383b5d128e3 7132248: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java Changeset: 3df0bd3ed880 Author: mullan Date: 2012-01-23 12:17 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3df0bd3ed880 7131084: XMLDSig XPathFilter2Transform regression involving intersect filter Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath2Filter.java ! test/javax/xml/crypto/dsig/KeySelectors.java ! test/javax/xml/crypto/dsig/ValidationTests.java ! test/javax/xml/crypto/dsig/X509KeySelector.java + test/javax/xml/crypto/dsig/data/xmldsig-xfilter2.xml Changeset: 5e1ad6ad41b7 Author: mullan Date: 2012-01-23 13:23 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5e1ad6ad41b7 Merge Changeset: 914711cccc60 Author: darcy Date: 2012-01-23 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/914711cccc60 7132338: Use @code friendly idiom for '\' in javadoc Reviewed-by: alanb ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/LineNumberInputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/share/classes/java/io/StreamTokenizer.java ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/Properties.java Changeset: 237319a01a9a Author: alanb Date: 2012-01-24 09:09 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/237319a01a9a 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties ! test/ProblemList.txt Changeset: 718bca4e685f Author: rbackman Date: 2012-01-17 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/718bca4e685f 7132386: makefile support for tracing/Java Flight Recorder framework phase I Reviewed-by: ohair, dholmes, rottenha Contributed-by: Markus Gronlund , Erik Gahlin , Nils Loodin , Rickard Backman , Staffan Larsen ! make/com/oracle/Makefile + make/com/oracle/jfr/Makefile ! make/common/Defs.gmk ! make/common/Release.gmk Changeset: f64ea40293db Author: ksrini Date: 2012-01-24 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f64ea40293db 7132270: tools/launcher/DefaultLocaleTestRun.java failing (win) Reviewed-by: alanb, chegar ! test/tools/launcher/DefaultLocaleTestRun.java ! test/tools/launcher/TestHelper.java Changeset: 303b67074666 Author: lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java Changeset: ceab7e149581 Author: peytoia Date: 2012-01-26 17:06 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ceab7e149581 7017458: (cal) Multithreaded deserialization of Calendar leads to ClassCastException Reviewed-by: okutsu ! src/share/classes/java/util/Calendar.java + test/java/util/Calendar/Bug7017458.java Changeset: 350971f50949 Author: rbackman Date: 2012-01-26 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/350971f50949 7133124: Remove redundant packages from JAR command line Reviewed-by: acorn, alanb, dholmes, rottenha ! make/common/Release.gmk Changeset: b518b160607f Author: lancea Date: 2012-01-26 19:41 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b518b160607f 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl Reviewed-by: forax ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java Changeset: 5ee30ab905db Author: wetmore Date: 2012-01-26 17:16 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5ee30ab905db 7126889: Incorrect SSLEngine debug output Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/EngineArgs.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh Changeset: 7aa5ddfa3c9d Author: okutsu Date: 2012-01-27 14:58 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7aa5ddfa3c9d 7130335: Problem with timezone in a SimpleDateFormat Reviewed-by: peytoia ! src/share/classes/java/text/SimpleDateFormat.java + test/java/text/Format/DateFormat/Bug7130335.java Changeset: ff24779c147f Author: valeriep Date: 2012-01-27 15:25 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ff24779c147f 7136538: typo in test/Makefile under the jdk_security3 target Summary: Fixed the typo of "secrity". Reviewed-by: wetmore ! test/Makefile Changeset: 7dbc129d8e5c Author: ksrini Date: 2012-01-28 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7dbc129d8e5c 7127906: (launcher) convert the launcher regression tests to java Reviewed-by: darcy, naoto ! test/tools/launcher/Arrrghs.java + test/tools/launcher/ChangeDataModel.java - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java ! test/tools/launcher/DefaultLocaleTestRun.java ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/I18NJarTest.java + test/tools/launcher/I18NTest.java ! test/tools/launcher/MiscTests.java ! test/tools/launcher/Settings.java - test/tools/launcher/SomeException.java ! test/tools/launcher/Test7029048.java ! test/tools/launcher/TestHelper.java - test/tools/launcher/UnicodeCleanup.java ! test/tools/launcher/UnicodeTest.java - test/tools/launcher/UnicodeTest.sh ! test/tools/launcher/UnresolvedExceptions.java - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 7a25b72b3644 Author: lana Date: 2012-01-28 20:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7a25b72b3644 Merge Changeset: f9fb8c4b4550 Author: dl Date: 2012-01-30 11:44 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f9fb8c4b4550 7132378: Race in FutureTask if used with explicit set ( not Runnable ) Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/FutureTask.java + test/java/util/concurrent/FutureTask/DoneTimedGetLoops.java + test/java/util/concurrent/FutureTask/ExplicitSet.java Changeset: 863a20b0bf08 Author: ngmr Date: 2012-01-10 00:07 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/863a20b0bf08 7123229: (coll) EnumMap.containsValue(null) returns true Summary: java.util.EnumMap.NULL equals() must only be true for itself Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/UniqueNullValue.java Changeset: 13978750cb87 Author: ngmr Date: 2012-01-31 10:31 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/13978750cb87 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/java/lang/UNIXProcess_md.c Changeset: 431bc327f34a Author: sla Date: 2012-01-31 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/431bc327f34a 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms Summary: Make sure HotSpot and JDK looks for well-known files in the same location Reviewed-by: dholmes, dsamersoff ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java ! test/ProblemList.txt Changeset: 663a6333105d Author: sla Date: 2012-01-31 04:57 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/663a6333105d Merge Changeset: 533bc0a10233 Author: lana Date: 2012-01-31 19:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/533bc0a10233 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: ce62fb7aa1b8 Author: lana Date: 2012-02-07 10:38 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ce62fb7aa1b8 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 1a99dad28223 Author: yhuang Date: 2012-02-06 18:56 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1a99dad28223 7129382: change minor unit of VND to 0 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/tablea1.txt Changeset: 930756e55285 Author: yhuang Date: 2012-02-06 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/930756e55285 Merge Changeset: ec17fbe5b8fb Author: katleman Date: 2012-02-08 19:13 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ec17fbe5b8fb Merge Changeset: 5aca406e87cb Author: katleman Date: 2012-02-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5aca406e87cb Added tag jdk8-b25 for changeset ec17fbe5b8fb ! .hgtags Changeset: de74d3310e96 Author: lana Date: 2012-02-09 23:17 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/de74d3310e96 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 081a44952699 Author: lana Date: 2012-02-10 10:23 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/081a44952699 Merge From littlee at linux.vnet.ibm.com Mon Feb 13 00:16:35 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 13 Feb 2012 16:16:35 +0800 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F336548.3010506@linux.vnet.ibm.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> <4F310B1C.8080606@oracle.com> <4F336548.3010506@linux.vnet.ibm.com> Message-ID: <4F38C6E3.60804@linux.vnet.ibm.com> Hi guys, Here, I want propose a even easier patch to fix this issue. Please check here: http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.01/ The patch is mainly about remove enableInputMethod in two places in XTextAreaPeer and XTextFieldPeer. If it does the right thing, would anyone help to review the patch? On 02/09/2012 02:18 PM, Charles Lee wrote: > Hi Anthony, > > Thank you for your review. I have changed the test case a little, > which will include a button to change the input method enable[1]. Is > it the dynamic thing in your mind? > > This test case can work well on my original patch, but I found > something interesting: > Enable or disable jtext/xtext input method will have nothing to do > with input method. Only enableInputMethod of target has influence. I > was doing some code reading about this and find that (Please correct > me if wrong) : > 1. jtext/xtext process InputMethodEvent from > XComponentPeer.handleEvent, and eventually goes to > Component.processInputMethodEvent and > JTextComponent.processInputMethodEvent. There are no route for input > method enable check. > 2. So when input method is enabled in TextArea/TextField, jtext should > be work well. > 3. And when input method is disabled by enableInputMethod(false), > input context will be removed from notification, and there will be no > more InputMethodEvent put into queue. So peer.handleEvent will never > be invoked since e is KeyEvent in the dispatchEventImpl method of > Component. > > So I conclude that set enable input method of jtext/xtext will have no > effect and my original patch can be reduced a very simple one. Just > remove the target.enableInputMethod(true) in both XTextFieldPeer and > XTextAreaPeer. > > > P.S. Why there is a jtext(JTextArea) in the XTextAreaPeer? I am > missing some history here :-) > > > > [1] > public class MyAWTTest extends JFrame { > private final TextArea ta; > private final TextField tf; > private final AtomicBoolean flag; > > public MyAWTTest() { > super("Single Frame --- AWT Frame"); > > setLayout(new FlowLayout()); > > ta = new TextArea("TextArea component(No IM)"); > ta.enableInputMethods(false); > ta.setPreferredSize(new Dimension(400, 100)); > add(ta); > > tf = new TextField("TextField component(No IM)", 52); > tf.enableInputMethods(false); > add(tf); > > flag = new AtomicBoolean(false); > > Button button = new Button("Click me, change the world"); > add(button); > > button.addActionListener(new ActionListener() { > @Override > public void actionPerformed(ActionEvent e) { > if (!flag.get()) { > ta.setText("TextArea component"); > tf.setText("TextField component"); > > ta.enableInputMethods(true); > tf.enableInputMethods(true); > > flag.set(true); > } else { > ta.setText("TextArea component (NO IM)"); > tf.setText("TextField component (NO IM)"); > > ta.enableInputMethods(false); > tf.enableInputMethods(false); > > flag.set(false); > } > } > > }); > > setSize(850, 360); > setVisible(true); > > setDefaultCloseOperation(EXIT_ON_CLOSE); > } > > public static void main(String[] args) { > SwingUtilities.invokeLater(new Runnable() { > public void run() { > new MyAWTTest(); > } > }); > > } > } > > On 02/07/2012 07:29 PM, Anthony Petrov wrote: >> Hi Charles, >> >> The general idea of the fix is OK and the fix looks fine to me. >> >> However, there's still a problem if an app enables or disables Input >> Methods dynamically during the app's execution. The updated status of >> the property needs to be propagated to the jtext or xtext somehow. >> >> -- >> best regards, >> Anthony >> >> On 2/7/2012 1:17 PM, Charles Lee wrote: >>> Hi guys, >>> >>> Given a simple test case below[1], enableInputMethod(false) does not >>> work. We can always invoke input method. >>> [1] >>> public class MyAWTTest extends JFrame { >>> Component c; >>> >>> public MyAWTTest() { >>> super("Single Frame --- AWT Frame"); >>> >>> setLayout(new FlowLayout()); >>> >>> c = new TextArea("TextArea component(No IM)"); >>> c.enableInputMethods(false); >>> c.setPreferredSize(new Dimension(400, 100)); >>> add(c); >>> >>> c = new TextField("TextField component(No IM)", 52); >>> c.enableInputMethods(false); >>> add(c); >>> >>> setSize(850, 360); >>> setVisible(true); >>> >>> setDefaultCloseOperation(EXIT_ON_CLOSE); >>> } >>> >>> public static void main(String[] args) { >>> SwingUtilities.invokeLater(new Runnable() { >>> public void run() { >>> new MyAWTTest(); >>> } >>> }); >>> >>> } >>> } >>> >>> Patch @ http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.00/ >>> >>> >>> The patch is mainly about: >>> 1. Add a new method in the ComponentAccessor which help to escape >>> the package restraints. Please check the changes in Component and >>> AWTAccessor. >>> 2. Remove the enableInputMethod(true) in the XTextAreaPeer and >>> XTextFieldPeer and use areInputMethodEnabled to set jtext correctly. >>> Please check the changes in XTextAreaPeer and XTextFieldPeer. >>> >>> I know it may not be a beautiful fix, but anyone interests in it? >>> >> > > -- Yours Charles From denis.fokin at sun.com Mon Feb 13 05:56:52 2012 From: denis.fokin at sun.com (denis.fokin at sun.com) Date: Mon, 13 Feb 2012 13:56:52 +0000 Subject: hg: jdk8/awt/jdk: 7143070: test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Message-ID: <20120213135725.4C437474A1@hg.openjdk.java.net> Changeset: 3f4701d08418 Author: bagiras Date: 2012-02-13 17:49 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3f4701d08418 7143070: test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Reviewed-by: anthony ! test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java From anthony.petrov at oracle.com Mon Feb 13 06:53:32 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 13 Feb 2012 18:53:32 +0400 Subject: Review request for 7132692: [macosx] Class com.apple.eawt not functioning Message-ID: <4F3923EC.8090201@oracle.com> Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7132692 at: http://cr.openjdk.java.net/~anthony/x-16-eawt-7132692.0/ With this fix we postpone the initializing of an instance of the ApplicationDelegate class and setting the delegate to the NSApp until after the application itself has been fully initialized. The QueuingApplicationDelegate in libosxapp.dylib will queue all incoming notifications and resend them to the real ApplicationDelegate once it's installed. Note that it is still not completely clear to me why we must postpone creating the delegate. It seems that it may be somehow related to loading the nib file which is happening in NSApplicationAWT -finishLaunching: method. Given that: 1) the QAD ensures we don't miss any notifications, 2) the test application starts working correctly after this patch (i.e. the About, Preferences, and Quit menu items generate the expected eawt events), and 3) there doesn't appear to be an obvious requirement for the ApplicationDelegate to be initialized earlier, I consider this fix is OK. Also, it seems that the fix resolves 7130377 ([macosx] Adding Preferences menu results in NPE) as well. -- best regards, Anthony From anthony.petrov at oracle.com Tue Feb 14 05:25:15 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 14 Feb 2012 17:25:15 +0400 Subject: Review request for 7132692: [macosx] Class com.apple.eawt not functioning In-Reply-To: <4F3923EC.8090201@oracle.com> References: <4F3923EC.8090201@oracle.com> Message-ID: <4F3A60BB.2040200@oracle.com> Could anyone please review the fix? -- best regards, Anthony On 2/13/2012 6:53 PM, Anthony Petrov wrote: > Hello, > > Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7132692 at: > > http://cr.openjdk.java.net/~anthony/x-16-eawt-7132692.0/ > > With this fix we postpone the initializing of an instance of the > ApplicationDelegate class and setting the delegate to the NSApp until > after the application itself has been fully initialized. The > QueuingApplicationDelegate in libosxapp.dylib will queue all incoming > notifications and resend them to the real ApplicationDelegate once it's > installed. > > Note that it is still not completely clear to me why we must postpone > creating the delegate. It seems that it may be somehow related to > loading the nib file which is happening in NSApplicationAWT > -finishLaunching: method. > > Given that: > > 1) the QAD ensures we don't miss any notifications, > 2) the test application starts working correctly after this patch (i.e. > the About, Preferences, and Quit menu items generate the expected eawt > events), and > 3) there doesn't appear to be an obvious requirement for the > ApplicationDelegate to be initialized earlier, > > I consider this fix is OK. Also, it seems that the fix resolves 7130377 > ([macosx] Adding Preferences menu results in NPE) as well. > > -- > best regards, > Anthony From alexandr.scherbatiy at oracle.com Tue Feb 14 06:44:38 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 14 Feb 2012 14:44:38 +0000 Subject: hg: jdk8/awt/jdk: 7133577: [macosx] closed/javax/swing/JTree/4314199/bug4314199.java fails on MacOS Message-ID: <20120214144520.09F0D474C4@hg.openjdk.java.net> Changeset: a1dc74291966 Author: alexsch Date: 2012-02-14 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a1dc74291966 7133577: [macosx] closed/javax/swing/JTree/4314199/bug4314199.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JTree/4314199/bug4314199.html + test/javax/swing/JTree/4314199/bug4314199.java From anthony.petrov at oracle.com Wed Feb 15 05:15:33 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 15 Feb 2012 17:15:33 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames Message-ID: <4F3BAFF5.4090002@oracle.com> Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7124553 at: http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ With this fix we constrain the size used for setBounds() and setMinMaxSize() operations so that it always includes the size of window decorations and the grow box when they're enabled. The size of (1, 1) is considered as the smallest possible size for a window in any case. -- best regards, Anthony From sergey.bylokhov at oracle.com Wed Feb 15 05:36:04 2012 From: sergey.bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 15 Feb 2012 17:36:04 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames In-Reply-To: <4F3BAFF5.4090002@oracle.com> References: <4F3BAFF5.4090002@oracle.com> Message-ID: <4F3BB4C4.8040701@oracle.com> Hi, Anthony. What happens if small decorated nonresizable window became resizable(growbox will be shown). As far I understand window should increase its size? Correct? 15.02.2012 17:15, Anthony Petrov wrote: > Hello, > > Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7124553 > at: > > http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ > > With this fix we constrain the size used for setBounds() and > setMinMaxSize() operations so that it always includes the size of > window decorations and the grow box when they're enabled. The size of > (1, 1) is considered as the smallest possible size for a window in any > case. > > -- > best regards, > Anthony -- Best regards, Sergey. From anthony.petrov at oracle.com Wed Feb 15 06:01:56 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 15 Feb 2012 18:01:56 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames In-Reply-To: <4F3BB4C4.8040701@oracle.com> References: <4F3BAFF5.4090002@oracle.com> <4F3BB4C4.8040701@oracle.com> Message-ID: <4F3BBAD4.7010105@oracle.com> Hi Sergey, Thanks for the review. Indeed, the size constraints must be re-applied in this case. Please find an updated fix here: http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.1/ -- best regards, Anthony On 2/15/2012 5:36 PM, Sergey Bylokhov wrote: > Hi, Anthony. > What happens if small decorated nonresizable window became > resizable(growbox will be shown). As far I understand window should > increase its size? Correct? > > 15.02.2012 17:15, Anthony Petrov wrote: >> Hello, >> >> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7124553 >> at: >> >> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ >> >> With this fix we constrain the size used for setBounds() and >> setMinMaxSize() operations so that it always includes the size of >> window decorations and the grow box when they're enabled. The size of >> (1, 1) is considered as the smallest possible size for a window in any >> case. >> >> -- >> best regards, >> Anthony > > From sergey.bylokhov at oracle.com Wed Feb 15 06:13:45 2012 From: sergey.bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 15 Feb 2012 18:13:45 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames In-Reply-To: <4F3BBAD4.7010105@oracle.com> References: <4F3BAFF5.4090002@oracle.com> <4F3BB4C4.8040701@oracle.com> <4F3BBAD4.7010105@oracle.com> Message-ID: <4F3BBD99.6020009@oracle.com> 15.02.2012 18:01, Anthony Petrov ?????: > Hi Sergey, > > Thanks for the review. Indeed, the size constraints must be re-applied > in this case. Please find an updated fix here: > > http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.1/ I guess we should use peers bounds in line 596 Rectangle bounds = target.getBounds(); Is it possible to do it in the native part in the nativeSetNSWindowBounds? > > -- > best regards, > Anthony > > On 2/15/2012 5:36 PM, Sergey Bylokhov wrote: >> Hi, Anthony. >> What happens if small decorated nonresizable window became >> resizable(growbox will be shown). As far I understand window should >> increase its size? Correct? >> >> 15.02.2012 17:15, Anthony Petrov wrote: >>> Hello, >>> >>> Please review a fix for >>> http://bugs.sun.com/view_bug.do?bug_id=7124553 at: >>> >>> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ >>> >>> With this fix we constrain the size used for setBounds() and >>> setMinMaxSize() operations so that it always includes the size of >>> window decorations and the grow box when they're enabled. The size >>> of (1, 1) is considered as the smallest possible size for a window >>> in any case. >>> >>> -- >>> best regards, >>> Anthony >> >> -- Best regards, Sergey. From anthony.petrov at oracle.com Wed Feb 15 06:23:41 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 15 Feb 2012 18:23:41 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames In-Reply-To: <4F3BBD99.6020009@oracle.com> References: <4F3BAFF5.4090002@oracle.com> <4F3BB4C4.8040701@oracle.com> <4F3BBAD4.7010105@oracle.com> <4F3BBD99.6020009@oracle.com> Message-ID: <4F3BBFED.9050406@oracle.com> Hi Sergey, Yes, this is a good suggestion. Here's the latest version of the fix: http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.2/ Regarding doing this in native: everything is possible to do in native code. However, Java code is easier to maintain, and as such it's best to keep as much code in Java peers as possible. The reason I put the constrainBounds: in native is because it relies on -shouldShowGrowBox which checks for the version of the OS and is available in native code only. And there's no practical reason to expose it in Java. -- best regards, Anthony On 2/15/2012 6:13 PM, Sergey Bylokhov wrote: > 15.02.2012 18:01, Anthony Petrov ?????: >> Hi Sergey, >> >> Thanks for the review. Indeed, the size constraints must be re-applied >> in this case. Please find an updated fix here: >> >> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.1/ > I guess we should use peers bounds in line > 596 Rectangle bounds = target.getBounds(); > Is it possible to do it in the native part in the nativeSetNSWindowBounds? >> >> -- >> best regards, >> Anthony >> >> On 2/15/2012 5:36 PM, Sergey Bylokhov wrote: >>> Hi, Anthony. >>> What happens if small decorated nonresizable window became >>> resizable(growbox will be shown). As far I understand window should >>> increase its size? Correct? >>> >>> 15.02.2012 17:15, Anthony Petrov wrote: >>>> Hello, >>>> >>>> Please review a fix for >>>> http://bugs.sun.com/view_bug.do?bug_id=7124553 at: >>>> >>>> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ >>>> >>>> With this fix we constrain the size used for setBounds() and >>>> setMinMaxSize() operations so that it always includes the size of >>>> window decorations and the grow box when they're enabled. The size >>>> of (1, 1) is considered as the smallest possible size for a window >>>> in any case. >>>> >>>> -- >>>> best regards, >>>> Anthony >>> >>> > > From sergey.bylokhov at oracle.com Wed Feb 15 06:40:08 2012 From: sergey.bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 15 Feb 2012 18:40:08 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames In-Reply-To: <4F3BBFED.9050406@oracle.com> References: <4F3BAFF5.4090002@oracle.com> <4F3BB4C4.8040701@oracle.com> <4F3BBAD4.7010105@oracle.com> <4F3BBD99.6020009@oracle.com> <4F3BBFED.9050406@oracle.com> Message-ID: <4F3BC3C8.3040003@oracle.com> 15.02.2012 18:23, Anthony Petrov wrote: > Hi Sergey, > > Yes, this is a good suggestion. Here's the latest version of the fix: > > http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.2/ Looks good. > > Regarding doing this in native: everything is possible to do in native > code. However, Java code is easier to maintain, and as such it's best > to keep as much code in Java peers as possible. The reason I put the > constrainBounds: in native is because it relies on -shouldShowGrowBox > which checks for the version of the OS and is available in native code > only. And there's no practical reason to expose it in Java. > > -- > best regards, > Anthony > > On 2/15/2012 6:13 PM, Sergey Bylokhov wrote: >> 15.02.2012 18:01, Anthony Petrov ?????: >>> Hi Sergey, >>> >>> Thanks for the review. Indeed, the size constraints must be >>> re-applied in this case. Please find an updated fix here: >>> >>> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.1/ >> I guess we should use peers bounds in line >> 596 Rectangle bounds = target.getBounds(); >> Is it possible to do it in the native part in the >> nativeSetNSWindowBounds? >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 2/15/2012 5:36 PM, Sergey Bylokhov wrote: >>>> Hi, Anthony. >>>> What happens if small decorated nonresizable window became >>>> resizable(growbox will be shown). As far I understand window should >>>> increase its size? Correct? >>>> >>>> 15.02.2012 17:15, Anthony Petrov wrote: >>>>> Hello, >>>>> >>>>> Please review a fix for >>>>> http://bugs.sun.com/view_bug.do?bug_id=7124553 at: >>>>> >>>>> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ >>>>> >>>>> With this fix we constrain the size used for setBounds() and >>>>> setMinMaxSize() operations so that it always includes the size of >>>>> window decorations and the grow box when they're enabled. The size >>>>> of (1, 1) is considered as the smallest possible size for a window >>>>> in any case. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>> >>>> >> >> -- Best regards, Sergey. From anthony.petrov at oracle.com Wed Feb 15 06:42:39 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 15 Feb 2012 18:42:39 +0400 Subject: Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames In-Reply-To: <4F3BC3C8.3040003@oracle.com> References: <4F3BAFF5.4090002@oracle.com> <4F3BB4C4.8040701@oracle.com> <4F3BBAD4.7010105@oracle.com> <4F3BBD99.6020009@oracle.com> <4F3BBFED.9050406@oracle.com> <4F3BC3C8.3040003@oracle.com> Message-ID: <4F3BC45F.6050505@oracle.com> Thank you! -- best regards, Anthony On 2/15/2012 6:40 PM, Sergey Bylokhov wrote: > 15.02.2012 18:23, Anthony Petrov wrote: >> Hi Sergey, >> >> Yes, this is a good suggestion. Here's the latest version of the fix: >> >> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.2/ > Looks good. >> >> Regarding doing this in native: everything is possible to do in native >> code. However, Java code is easier to maintain, and as such it's best >> to keep as much code in Java peers as possible. The reason I put the >> constrainBounds: in native is because it relies on -shouldShowGrowBox >> which checks for the version of the OS and is available in native code >> only. And there's no practical reason to expose it in Java. >> >> -- >> best regards, >> Anthony >> >> On 2/15/2012 6:13 PM, Sergey Bylokhov wrote: >>> 15.02.2012 18:01, Anthony Petrov ?????: >>>> Hi Sergey, >>>> >>>> Thanks for the review. Indeed, the size constraints must be >>>> re-applied in this case. Please find an updated fix here: >>>> >>>> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.1/ >>> I guess we should use peers bounds in line >>> 596 Rectangle bounds = target.getBounds(); >>> Is it possible to do it in the native part in the >>> nativeSetNSWindowBounds? >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 2/15/2012 5:36 PM, Sergey Bylokhov wrote: >>>>> Hi, Anthony. >>>>> What happens if small decorated nonresizable window became >>>>> resizable(growbox will be shown). As far I understand window should >>>>> increase its size? Correct? >>>>> >>>>> 15.02.2012 17:15, Anthony Petrov wrote: >>>>>> Hello, >>>>>> >>>>>> Please review a fix for >>>>>> http://bugs.sun.com/view_bug.do?bug_id=7124553 at: >>>>>> >>>>>> http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.0/ >>>>>> >>>>>> With this fix we constrain the size used for setBounds() and >>>>>> setMinMaxSize() operations so that it always includes the size of >>>>>> window decorations and the grow box when they're enabled. The size >>>>>> of (1, 1) is considered as the smallest possible size for a window >>>>>> in any case. >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>> >>>>> >>> >>> > > From artem.ananiev at oracle.com Thu Feb 16 02:32:00 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 16 Feb 2012 14:32:00 +0400 Subject: Review request for 7132692: [macosx] Class com.apple.eawt not functioning In-Reply-To: <4F3A60BB.2040200@oracle.com> References: <4F3923EC.8090201@oracle.com> <4F3A60BB.2040200@oracle.com> Message-ID: <4F3CDB20.4060406@oracle.com> Hi, Anthony, On 2/14/2012 5:25 PM, Anthony Petrov wrote: > Could anyone please review the fix? I'm not the right person to review, so probably a stupid question. In AWTStarter -start:swtMode:swtModeForWebStart method, if onMainThread is YES, we call [st starter:args]. It in turn synchronously calls [NSApplicationAWT runAWTLoopWithApp: app], which should never return. So when the application delegate set in this case? Thanks, Artem > -- > best regards, > Anthony > > On 2/13/2012 6:53 PM, Anthony Petrov wrote: >> Hello, >> >> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7132692 >> at: >> >> http://cr.openjdk.java.net/~anthony/x-16-eawt-7132692.0/ >> >> With this fix we postpone the initializing of an instance of the >> ApplicationDelegate class and setting the delegate to the NSApp until >> after the application itself has been fully initialized. The >> QueuingApplicationDelegate in libosxapp.dylib will queue all incoming >> notifications and resend them to the real ApplicationDelegate once >> it's installed. >> >> Note that it is still not completely clear to me why we must postpone >> creating the delegate. It seems that it may be somehow related to >> loading the nib file which is happening in NSApplicationAWT >> -finishLaunching: method. >> >> Given that: >> >> 1) the QAD ensures we don't miss any notifications, >> 2) the test application starts working correctly after this patch >> (i.e. the About, Preferences, and Quit menu items generate the >> expected eawt events), and >> 3) there doesn't appear to be an obvious requirement for the >> ApplicationDelegate to be initialized earlier, >> >> I consider this fix is OK. Also, it seems that the fix resolves >> 7130377 ([macosx] Adding Preferences menu results in NPE) as well. >> >> -- >> best regards, >> Anthony From anthony.petrov at oracle.com Thu Feb 16 04:30:16 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 16 Feb 2012 16:30:16 +0400 Subject: Review request for 7132692: [macosx] Class com.apple.eawt not functioning In-Reply-To: <4F3CDB20.4060406@oracle.com> References: <4F3923EC.8090201@oracle.com> <4F3A60BB.2040200@oracle.com> <4F3CDB20.4060406@oracle.com> Message-ID: <4F3CF6D8.5020604@oracle.com> Hi Artem, Thanks for taking a look at the fix. On 02/16/12 14:32, Artem Ananiev wrote: > On 2/14/2012 5:25 PM, Anthony Petrov wrote: >> Could anyone please review the fix? > > I'm not the right person to review, so probably a stupid question. In > AWTStarter -start:swtMode:swtModeForWebStart method, if onMainThread is > YES, we call [st starter:args]. It in turn synchronously calls > [NSApplicationAWT runAWTLoopWithApp: app], which should never return. So > when the application delegate set in this case? If onMainThread is YES, then we must be running in the swt_compatible mode (see a check for this at line 430). In this case AWT must be initialized only *after* SWT has started its event loop. Indeed, how else could we possibly start AWT from the main thread if there were not an event loop spinning yet? This leads to the [app isRunning] returning YES at line 356, and as such we don't start up our own event loop but rather follow the 'else' branch of the if statement, and subsequently return from -starter:. After that the +start: will install our application delegate correctly. -- best regards, Anthony > > Thanks, > > Artem > >> -- >> best regards, >> Anthony >> >> On 2/13/2012 6:53 PM, Anthony Petrov wrote: >>> Hello, >>> >>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7132692 >>> at: >>> >>> http://cr.openjdk.java.net/~anthony/x-16-eawt-7132692.0/ >>> >>> With this fix we postpone the initializing of an instance of the >>> ApplicationDelegate class and setting the delegate to the NSApp until >>> after the application itself has been fully initialized. The >>> QueuingApplicationDelegate in libosxapp.dylib will queue all incoming >>> notifications and resend them to the real ApplicationDelegate once >>> it's installed. >>> >>> Note that it is still not completely clear to me why we must postpone >>> creating the delegate. It seems that it may be somehow related to >>> loading the nib file which is happening in NSApplicationAWT >>> -finishLaunching: method. >>> >>> Given that: >>> >>> 1) the QAD ensures we don't miss any notifications, >>> 2) the test application starts working correctly after this patch >>> (i.e. the About, Preferences, and Quit menu items generate the >>> expected eawt events), and >>> 3) there doesn't appear to be an obvious requirement for the >>> ApplicationDelegate to be initialized earlier, >>> >>> I consider this fix is OK. Also, it seems that the fix resolves >>> 7130377 ([macosx] Adding Preferences menu results in NPE) as well. >>> >>> -- >>> best regards, >>> Anthony From pavel.porvatov at oracle.com Thu Feb 16 05:44:22 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Thu, 16 Feb 2012 13:44:22 +0000 Subject: hg: jdk8/awt/jdk: 7089914: Focus on image icons are not visible in javaws cache with high contrast mode Message-ID: <20120216134451.41DD24751C@hg.openjdk.java.net> Changeset: 362867d5caa4 Author: rupashka Date: 2012-02-16 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/362867d5caa4 7089914: Focus on image icons are not visible in javaws cache with high contrast mode Reviewed-by: rupashka Contributed-by: Sean Chou ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI.java + test/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI/7089914/bug7089914.java From anthony.petrov at oracle.com Fri Feb 17 04:01:20 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 17 Feb 2012 16:01:20 +0400 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F38C6E3.60804@linux.vnet.ibm.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> <4F310B1C.8080606@oracle.com> <4F336548.3010506@linux.vnet.ibm.com> <4F38C6E3.60804@linux.vnet.ibm.com> Message-ID: <4F3E4190.1070006@oracle.com> Hi Charles, The latest fix looks reasonable. Basically, by removing the enableInputMethod(true) call from peers' constructors we ensure we don't override the enable/disable state set by user code. I've filed a CR: http://bugs.sun.com/view_bug.do?bug_id=7146572 Let's wait a couple more days in case anyone else wants to comment on this fix. If no further comments come, I'll push the fix next week. Thanks for the contribution! -- best regards, Anthony On 2/13/2012 12:16 PM, Charles Lee wrote: > Hi guys, > > Here, I want propose a even easier patch to fix this issue. Please check > here: http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.01/ > > > The patch is mainly about remove enableInputMethod in two places in > XTextAreaPeer and XTextFieldPeer. > > If it does the right thing, would anyone help to review the patch? > > On 02/09/2012 02:18 PM, Charles Lee wrote: >> Hi Anthony, >> >> Thank you for your review. I have changed the test case a little, >> which will include a button to change the input method enable[1]. Is >> it the dynamic thing in your mind? >> >> This test case can work well on my original patch, but I found >> something interesting: >> Enable or disable jtext/xtext input method will have nothing to do >> with input method. Only enableInputMethod of target has influence. I >> was doing some code reading about this and find that (Please correct >> me if wrong) : >> 1. jtext/xtext process InputMethodEvent from >> XComponentPeer.handleEvent, and eventually goes to >> Component.processInputMethodEvent and >> JTextComponent.processInputMethodEvent. There are no route for input >> method enable check. >> 2. So when input method is enabled in TextArea/TextField, jtext should >> be work well. >> 3. And when input method is disabled by enableInputMethod(false), >> input context will be removed from notification, and there will be no >> more InputMethodEvent put into queue. So peer.handleEvent will never >> be invoked since e is KeyEvent in the dispatchEventImpl method of >> Component. >> >> So I conclude that set enable input method of jtext/xtext will have no >> effect and my original patch can be reduced a very simple one. Just >> remove the target.enableInputMethod(true) in both XTextFieldPeer and >> XTextAreaPeer. >> >> >> P.S. Why there is a jtext(JTextArea) in the XTextAreaPeer? I am >> missing some history here :-) >> >> >> >> [1] >> public class MyAWTTest extends JFrame { >> private final TextArea ta; >> private final TextField tf; >> private final AtomicBoolean flag; >> >> public MyAWTTest() { >> super("Single Frame --- AWT Frame"); >> >> setLayout(new FlowLayout()); >> >> ta = new TextArea("TextArea component(No IM)"); >> ta.enableInputMethods(false); >> ta.setPreferredSize(new Dimension(400, 100)); >> add(ta); >> >> tf = new TextField("TextField component(No IM)", 52); >> tf.enableInputMethods(false); >> add(tf); >> >> flag = new AtomicBoolean(false); >> >> Button button = new Button("Click me, change the world"); >> add(button); >> >> button.addActionListener(new ActionListener() { >> @Override >> public void actionPerformed(ActionEvent e) { >> if (!flag.get()) { >> ta.setText("TextArea component"); >> tf.setText("TextField component"); >> >> ta.enableInputMethods(true); >> tf.enableInputMethods(true); >> >> flag.set(true); >> } else { >> ta.setText("TextArea component (NO IM)"); >> tf.setText("TextField component (NO IM)"); >> >> ta.enableInputMethods(false); >> tf.enableInputMethods(false); >> >> flag.set(false); >> } >> } >> >> }); >> >> setSize(850, 360); >> setVisible(true); >> >> setDefaultCloseOperation(EXIT_ON_CLOSE); >> } >> >> public static void main(String[] args) { >> SwingUtilities.invokeLater(new Runnable() { >> public void run() { >> new MyAWTTest(); >> } >> }); >> >> } >> } >> >> On 02/07/2012 07:29 PM, Anthony Petrov wrote: >>> Hi Charles, >>> >>> The general idea of the fix is OK and the fix looks fine to me. >>> >>> However, there's still a problem if an app enables or disables Input >>> Methods dynamically during the app's execution. The updated status of >>> the property needs to be propagated to the jtext or xtext somehow. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 2/7/2012 1:17 PM, Charles Lee wrote: >>>> Hi guys, >>>> >>>> Given a simple test case below[1], enableInputMethod(false) does not >>>> work. We can always invoke input method. >>>> [1] >>>> public class MyAWTTest extends JFrame { >>>> Component c; >>>> >>>> public MyAWTTest() { >>>> super("Single Frame --- AWT Frame"); >>>> >>>> setLayout(new FlowLayout()); >>>> >>>> c = new TextArea("TextArea component(No IM)"); >>>> c.enableInputMethods(false); >>>> c.setPreferredSize(new Dimension(400, 100)); >>>> add(c); >>>> >>>> c = new TextField("TextField component(No IM)", 52); >>>> c.enableInputMethods(false); >>>> add(c); >>>> >>>> setSize(850, 360); >>>> setVisible(true); >>>> >>>> setDefaultCloseOperation(EXIT_ON_CLOSE); >>>> } >>>> >>>> public static void main(String[] args) { >>>> SwingUtilities.invokeLater(new Runnable() { >>>> public void run() { >>>> new MyAWTTest(); >>>> } >>>> }); >>>> >>>> } >>>> } >>>> >>>> Patch @ http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.00/ >>>> >>>> >>>> The patch is mainly about: >>>> 1. Add a new method in the ComponentAccessor which help to escape >>>> the package restraints. Please check the changes in Component and >>>> AWTAccessor. >>>> 2. Remove the enableInputMethod(true) in the XTextAreaPeer and >>>> XTextFieldPeer and use areInputMethodEnabled to set jtext correctly. >>>> Please check the changes in XTextAreaPeer and XTextFieldPeer. >>>> >>>> I know it may not be a beautiful fix, but anyone interests in it? >>>> >>> >> >> > > From anthony.petrov at oracle.com Fri Feb 17 04:05:48 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 17 Feb 2012 16:05:48 +0400 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F336548.3010506@linux.vnet.ibm.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> <4F310B1C.8080606@oracle.com> <4F336548.3010506@linux.vnet.ibm.com> Message-ID: <4F3E429C.6030608@oracle.com> On 2/9/2012 10:18 AM, Charles Lee wrote: > P.S. Why there is a jtext(JTextArea) in the XTextAreaPeer? I am missing > some history here :-) XToolkit doesn't use any native GUI component toolkit (such as e.g. Motif which was used in MToolkit). Text components themselves are quite complex in behavior. To avoid inventing the wheel we decided to reuse Swing text components when implementing the XToolkit. -- best regards, Anthony From littlee at linux.vnet.ibm.com Mon Feb 20 00:44:14 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 20 Feb 2012 16:44:14 +0800 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F3E4190.1070006@oracle.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> <4F310B1C.8080606@oracle.com> <4F336548.3010506@linux.vnet.ibm.com> <4F38C6E3.60804@linux.vnet.ibm.com> <4F3E4190.1070006@oracle.com> Message-ID: <4F4207DE.1070107@linux.vnet.ibm.com> Hi Anthony, That's great. Thank you very much :-) On 02/17/2012 08:01 PM, Anthony Petrov wrote: > Hi Charles, > > The latest fix looks reasonable. Basically, by removing the > enableInputMethod(true) call from peers' constructors we ensure we > don't override the enable/disable state set by user code. > > I've filed a CR: http://bugs.sun.com/view_bug.do?bug_id=7146572 > > Let's wait a couple more days in case anyone else wants to comment on > this fix. If no further comments come, I'll push the fix next week. > > Thanks for the contribution! > > -- > best regards, > Anthony > > On 2/13/2012 12:16 PM, Charles Lee wrote: >> Hi guys, >> >> Here, I want propose a even easier patch to fix this issue. Please >> check here: http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.01/ >> >> >> The patch is mainly about remove enableInputMethod in two places in >> XTextAreaPeer and XTextFieldPeer. >> >> If it does the right thing, would anyone help to review the patch? >> >> On 02/09/2012 02:18 PM, Charles Lee wrote: >>> Hi Anthony, >>> >>> Thank you for your review. I have changed the test case a little, >>> which will include a button to change the input method enable[1]. Is >>> it the dynamic thing in your mind? >>> >>> This test case can work well on my original patch, but I found >>> something interesting: >>> Enable or disable jtext/xtext input method will have nothing to do >>> with input method. Only enableInputMethod of target has influence. I >>> was doing some code reading about this and find that (Please correct >>> me if wrong) : >>> 1. jtext/xtext process InputMethodEvent from >>> XComponentPeer.handleEvent, and eventually goes to >>> Component.processInputMethodEvent and >>> JTextComponent.processInputMethodEvent. There are no route for input >>> method enable check. >>> 2. So when input method is enabled in TextArea/TextField, jtext >>> should be work well. >>> 3. And when input method is disabled by enableInputMethod(false), >>> input context will be removed from notification, and there will be >>> no more InputMethodEvent put into queue. So peer.handleEvent will >>> never be invoked since e is KeyEvent in the dispatchEventImpl method >>> of Component. >>> >>> So I conclude that set enable input method of jtext/xtext will have >>> no effect and my original patch can be reduced a very simple one. >>> Just remove the target.enableInputMethod(true) in both >>> XTextFieldPeer and XTextAreaPeer. >>> >>> >>> P.S. Why there is a jtext(JTextArea) in the XTextAreaPeer? I am >>> missing some history here :-) >>> >>> >>> >>> [1] >>> public class MyAWTTest extends JFrame { >>> private final TextArea ta; >>> private final TextField tf; >>> private final AtomicBoolean flag; >>> >>> public MyAWTTest() { >>> super("Single Frame --- AWT Frame"); >>> >>> setLayout(new FlowLayout()); >>> >>> ta = new TextArea("TextArea component(No IM)"); >>> ta.enableInputMethods(false); >>> ta.setPreferredSize(new Dimension(400, 100)); >>> add(ta); >>> >>> tf = new TextField("TextField component(No IM)", 52); >>> tf.enableInputMethods(false); >>> add(tf); >>> >>> flag = new AtomicBoolean(false); >>> >>> Button button = new Button("Click me, change the world"); >>> add(button); >>> >>> button.addActionListener(new ActionListener() { >>> @Override >>> public void actionPerformed(ActionEvent e) { >>> if (!flag.get()) { >>> ta.setText("TextArea component"); >>> tf.setText("TextField component"); >>> >>> ta.enableInputMethods(true); >>> tf.enableInputMethods(true); >>> >>> flag.set(true); >>> } else { >>> ta.setText("TextArea component (NO IM)"); >>> tf.setText("TextField component (NO IM)"); >>> >>> ta.enableInputMethods(false); >>> tf.enableInputMethods(false); >>> >>> flag.set(false); >>> } >>> } >>> >>> }); >>> >>> setSize(850, 360); >>> setVisible(true); >>> >>> setDefaultCloseOperation(EXIT_ON_CLOSE); >>> } >>> >>> public static void main(String[] args) { >>> SwingUtilities.invokeLater(new Runnable() { >>> public void run() { >>> new MyAWTTest(); >>> } >>> }); >>> >>> } >>> } >>> >>> On 02/07/2012 07:29 PM, Anthony Petrov wrote: >>>> Hi Charles, >>>> >>>> The general idea of the fix is OK and the fix looks fine to me. >>>> >>>> However, there's still a problem if an app enables or disables >>>> Input Methods dynamically during the app's execution. The updated >>>> status of the property needs to be propagated to the jtext or xtext >>>> somehow. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 2/7/2012 1:17 PM, Charles Lee wrote: >>>>> Hi guys, >>>>> >>>>> Given a simple test case below[1], enableInputMethod(false) does >>>>> not work. We can always invoke input method. >>>>> [1] >>>>> public class MyAWTTest extends JFrame { >>>>> Component c; >>>>> >>>>> public MyAWTTest() { >>>>> super("Single Frame --- AWT Frame"); >>>>> >>>>> setLayout(new FlowLayout()); >>>>> >>>>> c = new TextArea("TextArea component(No IM)"); >>>>> c.enableInputMethods(false); >>>>> c.setPreferredSize(new Dimension(400, 100)); >>>>> add(c); >>>>> >>>>> c = new TextField("TextField component(No IM)", 52); >>>>> c.enableInputMethods(false); >>>>> add(c); >>>>> >>>>> setSize(850, 360); >>>>> setVisible(true); >>>>> >>>>> setDefaultCloseOperation(EXIT_ON_CLOSE); >>>>> } >>>>> >>>>> public static void main(String[] args) { >>>>> SwingUtilities.invokeLater(new Runnable() { >>>>> public void run() { >>>>> new MyAWTTest(); >>>>> } >>>>> }); >>>>> >>>>> } >>>>> } >>>>> >>>>> Patch @ http://cr.openjdk.java.net/~littlee/OJDK-124/webrev.00/ >>>>> >>>>> >>>>> The patch is mainly about: >>>>> 1. Add a new method in the ComponentAccessor which help to escape >>>>> the package restraints. Please check the changes in Component and >>>>> AWTAccessor. >>>>> 2. Remove the enableInputMethod(true) in the XTextAreaPeer and >>>>> XTextFieldPeer and use areInputMethodEnabled to set jtext >>>>> correctly. Please check the changes in XTextAreaPeer and >>>>> XTextFieldPeer. >>>>> >>>>> I know it may not be a beautiful fix, but anyone interests in it? >>>>> >>>> >>> >>> >> >> > -- Yours Charles From littlee at linux.vnet.ibm.com Mon Feb 20 00:46:05 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 20 Feb 2012 16:46:05 +0800 Subject: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform In-Reply-To: <4F3E429C.6030608@oracle.com> References: <4F30EC29.9020006@linux.vnet.ibm.com> <4F310B1C.8080606@oracle.com> <4F336548.3010506@linux.vnet.ibm.com> <4F3E429C.6030608@oracle.com> Message-ID: <4F42084D.8000205@linux.vnet.ibm.com> On 02/17/2012 08:05 PM, Anthony Petrov wrote: > On 2/9/2012 10:18 AM, Charles Lee wrote: >> P.S. Why there is a jtext(JTextArea) in the XTextAreaPeer? I am >> missing some history here :-) > > XToolkit doesn't use any native GUI component toolkit (such as e.g. > Motif which was used in MToolkit). Text components themselves are > quite complex in behavior. To avoid inventing the wheel we decided to > reuse Swing text components when implementing the XToolkit. > > -- > best regards, > Anthony > I see. Thanks Anthony. -- Yours Charles From peter.brunet at oracle.com Mon Feb 20 10:22:26 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 20 Feb 2012 12:22:26 -0600 Subject: hang when doing a fastdebug build Message-ID: <4F428F62.6010602@oracle.com> There is something about a patch I am working on that results in a hang when exiting an app with a fastdebug build but not with a product build. The results of ctrl+break follow. Could someone look at this and give me a hint as to what the deadlock is? Thanks, Pete Full thread dump OpenJDK Client VM (23.0-b11-fastdebug mixed mode): "Thread-0" daemon prio=6 tid=0x0863ac00 nid=0x10c8 runnable [0x07d5f000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_in_native Thread: 0x0863ac00 [0x10c8] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_in_native at sun.awt.windows.WToolkit.shutdown(Native Method) at sun.awt.windows.WToolkit.access$200(WToolkit.java:67) at sun.awt.windows.WToolkit$2$1.run(WToolkit.java:275) at java.lang.Thread.run(Thread.java:722) "SwingWorker-pool-1-thread-1" daemon prio=6 tid=0x088c3800 nid=0x166c waiting on condition [0x09d2f000] java.lang.Thread.State: WAITING (parking) JavaThread state: _thread_blocked Thread: 0x088c3800 [0x166c] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x15ffc1e0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043) at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) at java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1045) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1103) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) "DestroyJavaVM" prio=6 tid=0x00ec9000 nid=0xfa0 waiting on condition [0x00000000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_blocked Thread: 0x00ec9000 [0xfa0] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked "AWT-EventQueue-0" prio=6 tid=0x0581f800 nid=0x125c in Object.wait() [0x084de000] java.lang.Thread.State: WAITING (on object monitor) JavaThread state: _thread_blocked Thread: 0x0581f800 [0x125c] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at java.lang.Object.wait(Native Method) - waiting on <0x155c77e0> (a java.lang.Thread) at java.lang.Thread.join(Thread.java:1258) - locked <0x155c77e0> (a java.lang.Thread) at java.lang.Thread.join(Thread.java:1332) at java.lang.ApplicationShutdownHooks.runHooks(ApplicationShutdownHooks.java:106) at java.lang.ApplicationShutdownHooks$1.run(ApplicationShutdownHooks.java:46) at java.lang.Shutdown.runHooks(Shutdown.java:123) at java.lang.Shutdown.sequence(Shutdown.java:167) at java.lang.Shutdown.exit(Shutdown.java:212) - locked <0x156be6b8> (a java.lang.Class for java.lang.Shutdown) at java.lang.Runtime.exit(Runtime.java:107) at java.lang.System.exit(System.java:961) at javax.swing.JFrame.processWindowEvent(JFrame.java:312) at java.awt.Window.processEvent(Window.java:2003) at java.awt.Component.dispatchEventImpl(Component.java:4866) at java.awt.Container.dispatchEventImpl(Container.java:2287) at java.awt.Window.dispatchEventImpl(Window.java:2713) at java.awt.Component.dispatchEvent(Component.java:4691) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:703) at java.awt.EventQueue.access$000(EventQueue.java:102) at java.awt.EventQueue$3.run(EventQueue.java:662) at java.awt.EventQueue$3.run(EventQueue.java:660) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75) at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:86) at java.awt.EventQueue$4.run(EventQueue.java:676) at java.awt.EventQueue$4.run(EventQueue.java:674) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75) at java.awt.EventQueue.dispatchEvent(EventQueue.java:673) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:216) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:135) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:123) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:119) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:111) at java.awt.EventDispatchThread.run(EventDispatchThread.java:97) "AWT-Shutdown" prio=6 tid=0x0581f400 nid=0x1bb0 in Object.wait() [0x0837f000] java.lang.Thread.State: WAITING (on object monitor) JavaThread state: _thread_blocked Thread: 0x0581f400 [0x1bb0] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at java.lang.Object.wait(Native Method) - waiting on <0x15596128> (a java.lang.Object) at java.lang.Object.wait(Object.java:502) at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:290) - locked <0x15596128> (a java.lang.Object) at java.lang.Thread.run(Thread.java:722) "TimerQueue" daemon prio=6 tid=0x04df5400 nid=0x18a4 waiting on condition [0x0862f000] java.lang.Thread.State: WAITING (parking) JavaThread state: _thread_blocked Thread: 0x04df5400 [0x18a4] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x15684668> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043) at java.util.concurrent.DelayQueue.take(DelayQueue.java:209) at javax.swing.TimerQueue.run(TimerQueue.java:171) at java.lang.Thread.run(Thread.java:722) "AWT-Windows" daemon prio=6 tid=0x056d7c00 nid=0x1658 runnable [0x05cff000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_blocked Thread: 0x056d7c00 [0x1658] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at sun.awt.windows.WToolkit.eventLoop(Native Method) at sun.awt.windows.WToolkit.run(WToolkit.java:299) at java.lang.Thread.run(Thread.java:722) "Java2D Disposer" daemon prio=10 tid=0x04e04400 nid=0x478 in Object.wait() [0x05b0f000] java.lang.Thread.State: WAITING (on object monitor) JavaThread state: _thread_blocked Thread: 0x04e04400 [0x478] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at java.lang.Object.wait(Native Method) - waiting on <0x156847b0> (a java.lang.ref.ReferenceQueue$Lock) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:135) - locked <0x156847b0> (a java.lang.ref.ReferenceQueue$Lock) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:151) at sun.java2d.Disposer.run(Disposer.java:145) at java.lang.Thread.run(Thread.java:722) "Service Thread" daemon prio=6 tid=0x04cf8800 nid=0x1bb8 runnable [0x00000000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_blocked Thread: 0x04cf8800 [0x1bb8] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked "C1 CompilerThread0" daemon prio=10 tid=0x04cf2800 nid=0x598 waiting on condition [0x00000000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_blocked Thread: 0x04cf2800 [0x598] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked "Attach Listener" daemon prio=10 tid=0x04cee000 nid=0x108 runnable [0x00000000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_blocked Thread: 0x04cee000 [0x108] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked "Signal Dispatcher" daemon prio=10 tid=0x04ceac00 nid=0x1678 waiting on condition [0x00000000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_blocked Thread: 0x04ceac00 [0x1678] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked "Finalizer" daemon prio=8 tid=0x04c35c00 nid=0x12b4 in Object.wait() [0x04fef000] java.lang.Thread.State: WAITING (on object monitor) JavaThread state: _thread_blocked Thread: 0x04c35c00 [0x12b4] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at java.lang.Object.wait(Native Method) - waiting on <0x15684a78> (a java.lang.ref.ReferenceQueue$Lock) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:135) - locked <0x15684a78> (a java.lang.ref.ReferenceQueue$Lock) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:151) at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:177) "Reference Handler" daemon prio=10 tid=0x04c30c00 nid=0xd48 in Object.wait() [0x0100f000] java.lang.Thread.State: WAITING (on object monitor) JavaThread state: _thread_blocked Thread: 0x04c30c00 [0xd48] State: _at_safepoint _has_called_back 0 _at_poll_safepoint 0 JavaThread state: _thread_blocked at java.lang.Object.wait(Native Method) - waiting on <0x15684b00> (a java.lang.ref.Reference$Lock) at java.lang.Object.wait(Object.java:502) at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:142) - locked <0x15684b00> (a java.lang.ref.Reference$Lock) "VM Thread" prio=10 tid=0x00f9fc00 nid=0x1a38 runnable "VM Periodic Task Thread" prio=10 tid=0x04d09c00 nid=0x1aa0 waiting on condition Compiler thread printing unimplemented. JNI global references: 569 Heap def new generation total 13952K, used 13140K [0x10030000, 0x10f50000, 0x15580000) eden space 12416K, 98% used [0x10030000, 0x10c2e050, 0x10c50000) from space 1536K, 56% used [0x10c50000, 0x10d27328, 0x10dd0000) to space 1536K, 0% used [0x10dd0000, 0x10dd0000, 0x10f50000) tenured generation total 30860K, used 19177K [0x15580000, 0x173a3000, 0x20030000) the space 30860K, 62% used [0x15580000, 0x1683a478, 0x1683a600, 0x173a3000) compacting perm gen total 12288K, used 11265K [0x20030000, 0x20c30000, 0x24030000) the space 12288K, 91% used [0x20030000, 0x20b30568, 0x20b30600, 0x20c30000) No shared spaces configured. C:\OpenJDK\jdk8\build\windows-i586-fastdebug> From david.holmes at oracle.com Mon Feb 20 15:29:31 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 Feb 2012 09:29:31 +1000 Subject: hang when doing a fastdebug build In-Reply-To: <4F428F62.6010602@oracle.com> References: <4F428F62.6010602@oracle.com> Message-ID: <4F42D75B.3010402@oracle.com> The AWT eventqueue thread has called System.exit and is waiting for a shutdown hook thread to complete. I'm guessing that thread is Thread-0, which is currently out in native code executing WToolkit.shutdown. So from the Java stacks there is no way to tell what that thread is doing (ie whether it is making progress). David On 21/02/2012 4:22 AM, Pete Brunet wrote: > There is something about a patch I am working on that results in a hang > when exiting an app with a fastdebug build but not with a product > build. The results of ctrl+break follow. Could someone look at this > and give me a hint as to what the deadlock is? Thanks, Pete > > Full thread dump OpenJDK Client VM (23.0-b11-fastdebug mixed mode): > > "Thread-0" daemon prio=6 tid=0x0863ac00 nid=0x10c8 runnable [0x07d5f000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_in_native > Thread: 0x0863ac00 [0x10c8] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_in_native > at sun.awt.windows.WToolkit.shutdown(Native Method) > at sun.awt.windows.WToolkit.access$200(WToolkit.java:67) > at sun.awt.windows.WToolkit$2$1.run(WToolkit.java:275) > at java.lang.Thread.run(Thread.java:722) > > "SwingWorker-pool-1-thread-1" daemon prio=6 tid=0x088c3800 nid=0x166c > waiting on condition [0x09d2f000] > java.lang.Thread.State: WAITING (parking) > JavaThread state: _thread_blocked > Thread: 0x088c3800 [0x166c] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at sun.misc.Unsafe.park(Native Method) > - parking to wait for<0x15ffc1e0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1045) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1103) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) > at java.lang.Thread.run(Thread.java:722) > > "DestroyJavaVM" prio=6 tid=0x00ec9000 nid=0xfa0 waiting on condition > [0x00000000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_blocked > Thread: 0x00ec9000 [0xfa0] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > > "AWT-EventQueue-0" prio=6 tid=0x0581f800 nid=0x125c in Object.wait() > [0x084de000] > java.lang.Thread.State: WAITING (on object monitor) > JavaThread state: _thread_blocked > Thread: 0x0581f800 [0x125c] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at java.lang.Object.wait(Native Method) > - waiting on<0x155c77e0> (a java.lang.Thread) > at java.lang.Thread.join(Thread.java:1258) > - locked<0x155c77e0> (a java.lang.Thread) > at java.lang.Thread.join(Thread.java:1332) > at > java.lang.ApplicationShutdownHooks.runHooks(ApplicationShutdownHooks.java:106) > at > java.lang.ApplicationShutdownHooks$1.run(ApplicationShutdownHooks.java:46) > at java.lang.Shutdown.runHooks(Shutdown.java:123) > at java.lang.Shutdown.sequence(Shutdown.java:167) > at java.lang.Shutdown.exit(Shutdown.java:212) > - locked<0x156be6b8> (a java.lang.Class for java.lang.Shutdown) > at java.lang.Runtime.exit(Runtime.java:107) > at java.lang.System.exit(System.java:961) > at javax.swing.JFrame.processWindowEvent(JFrame.java:312) > at java.awt.Window.processEvent(Window.java:2003) > at java.awt.Component.dispatchEventImpl(Component.java:4866) > at java.awt.Container.dispatchEventImpl(Container.java:2287) > at java.awt.Window.dispatchEventImpl(Window.java:2713) > at java.awt.Component.dispatchEvent(Component.java:4691) > at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:703) > at java.awt.EventQueue.access$000(EventQueue.java:102) > at java.awt.EventQueue$3.run(EventQueue.java:662) > at java.awt.EventQueue$3.run(EventQueue.java:660) > at java.security.AccessController.doPrivileged(Native Method) > at > java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75) > at > java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:86) > at java.awt.EventQueue$4.run(EventQueue.java:676) > at java.awt.EventQueue$4.run(EventQueue.java:674) > at java.security.AccessController.doPrivileged(Native Method) > at > java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75) > at java.awt.EventQueue.dispatchEvent(EventQueue.java:673) > at > java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:216) > at > java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:135) > at > java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:123) > at > java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:119) > at > java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:111) > at java.awt.EventDispatchThread.run(EventDispatchThread.java:97) > > "AWT-Shutdown" prio=6 tid=0x0581f400 nid=0x1bb0 in Object.wait() > [0x0837f000] > java.lang.Thread.State: WAITING (on object monitor) > JavaThread state: _thread_blocked > Thread: 0x0581f400 [0x1bb0] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at java.lang.Object.wait(Native Method) > - waiting on<0x15596128> (a java.lang.Object) > at java.lang.Object.wait(Object.java:502) > at sun.awt.AWTAutoShutdown.run(AWTAutoShutdown.java:290) > - locked<0x15596128> (a java.lang.Object) > at java.lang.Thread.run(Thread.java:722) > > "TimerQueue" daemon prio=6 tid=0x04df5400 nid=0x18a4 waiting on > condition [0x0862f000] > java.lang.Thread.State: WAITING (parking) > JavaThread state: _thread_blocked > Thread: 0x04df5400 [0x18a4] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at sun.misc.Unsafe.park(Native Method) > - parking to wait for<0x15684668> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043) > at java.util.concurrent.DelayQueue.take(DelayQueue.java:209) > at javax.swing.TimerQueue.run(TimerQueue.java:171) > at java.lang.Thread.run(Thread.java:722) > > "AWT-Windows" daemon prio=6 tid=0x056d7c00 nid=0x1658 runnable [0x05cff000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_blocked > Thread: 0x056d7c00 [0x1658] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at sun.awt.windows.WToolkit.eventLoop(Native Method) > at sun.awt.windows.WToolkit.run(WToolkit.java:299) > at java.lang.Thread.run(Thread.java:722) > > "Java2D Disposer" daemon prio=10 tid=0x04e04400 nid=0x478 in > Object.wait() [0x05b0f000] > java.lang.Thread.State: WAITING (on object monitor) > JavaThread state: _thread_blocked > Thread: 0x04e04400 [0x478] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at java.lang.Object.wait(Native Method) > - waiting on<0x156847b0> (a java.lang.ref.ReferenceQueue$Lock) > at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:135) > - locked<0x156847b0> (a java.lang.ref.ReferenceQueue$Lock) > at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:151) > at sun.java2d.Disposer.run(Disposer.java:145) > at java.lang.Thread.run(Thread.java:722) > > "Service Thread" daemon prio=6 tid=0x04cf8800 nid=0x1bb8 runnable > [0x00000000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_blocked > Thread: 0x04cf8800 [0x1bb8] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > > "C1 CompilerThread0" daemon prio=10 tid=0x04cf2800 nid=0x598 waiting on > condition [0x00000000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_blocked > Thread: 0x04cf2800 [0x598] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > > "Attach Listener" daemon prio=10 tid=0x04cee000 nid=0x108 runnable > [0x00000000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_blocked > Thread: 0x04cee000 [0x108] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > > "Signal Dispatcher" daemon prio=10 tid=0x04ceac00 nid=0x1678 waiting on > condition [0x00000000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_blocked > Thread: 0x04ceac00 [0x1678] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > > "Finalizer" daemon prio=8 tid=0x04c35c00 nid=0x12b4 in Object.wait() > [0x04fef000] > java.lang.Thread.State: WAITING (on object monitor) > JavaThread state: _thread_blocked > Thread: 0x04c35c00 [0x12b4] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at java.lang.Object.wait(Native Method) > - waiting on<0x15684a78> (a java.lang.ref.ReferenceQueue$Lock) > at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:135) > - locked<0x15684a78> (a java.lang.ref.ReferenceQueue$Lock) > at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:151) > at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:177) > > "Reference Handler" daemon prio=10 tid=0x04c30c00 nid=0xd48 in > Object.wait() [0x0100f000] > java.lang.Thread.State: WAITING (on object monitor) > JavaThread state: _thread_blocked > Thread: 0x04c30c00 [0xd48] State: _at_safepoint _has_called_back 0 > _at_poll_safepoint 0 > JavaThread state: _thread_blocked > at java.lang.Object.wait(Native Method) > - waiting on<0x15684b00> (a java.lang.ref.Reference$Lock) > at java.lang.Object.wait(Object.java:502) > at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:142) > - locked<0x15684b00> (a java.lang.ref.Reference$Lock) > > "VM Thread" prio=10 tid=0x00f9fc00 nid=0x1a38 runnable > > "VM Periodic Task Thread" prio=10 tid=0x04d09c00 nid=0x1aa0 waiting on > condition > > > Compiler thread printing unimplemented. > > JNI global references: 569 > > Heap > def new generation total 13952K, used 13140K [0x10030000, 0x10f50000, > 0x15580000) > eden space 12416K, 98% used [0x10030000, 0x10c2e050, 0x10c50000) > from space 1536K, 56% used [0x10c50000, 0x10d27328, 0x10dd0000) > to space 1536K, 0% used [0x10dd0000, 0x10dd0000, 0x10f50000) > tenured generation total 30860K, used 19177K [0x15580000, 0x173a3000, > 0x20030000) > the space 30860K, 62% used [0x15580000, 0x1683a478, 0x1683a600, > 0x173a3000) > compacting perm gen total 12288K, used 11265K [0x20030000, 0x20c30000, > 0x24030000) > the space 12288K, 91% used [0x20030000, 0x20b30568, 0x20b30600, > 0x20c30000) > No shared spaces configured. > > > C:\OpenJDK\jdk8\build\windows-i586-fastdebug> From alexandr.scherbatiy at oracle.com Tue Feb 21 02:19:27 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 21 Feb 2012 10:19:27 +0000 Subject: hg: jdk8/awt/jdk: 7133566: [macosx] closed/javax/swing/JTable/4220171/bug4220171.java fails on MacOS Message-ID: <20120221101959.A9D84475B1@hg.openjdk.java.net> Changeset: 36b5f46264b3 Author: alexsch Date: 2012-02-21 14:19 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/36b5f46264b3 7133566: [macosx] closed/javax/swing/JTable/4220171/bug4220171.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JTable/4220171/bug4220171.java From alexandr.scherbatiy at oracle.com Tue Feb 21 03:02:55 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 21 Feb 2012 11:02:55 +0000 Subject: hg: jdk8/awt/jdk: 7133571: [macosx] closed/javax/swing/JToolBar/4247996/bug4247996.java fails on MacOS Message-ID: <20120221110335.31365475B2@hg.openjdk.java.net> Changeset: 927f1dac21cd Author: alexsch Date: 2012-02-21 15:03 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/927f1dac21cd 7133571: [macosx] closed/javax/swing/JToolBar/4247996/bug4247996.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JToolBar/4247996/bug4247996.java From alexandr.scherbatiy at oracle.com Tue Feb 21 03:33:52 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 21 Feb 2012 11:33:52 +0000 Subject: hg: jdk8/awt/jdk: 7133581: [macosx] closed/javax/swing/JTree/4330357/bug4330357.java fails on MacOS Message-ID: <20120221113402.97CDB475B3@hg.openjdk.java.net> Changeset: 314441d960c0 Author: alexsch Date: 2012-02-21 15:34 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/314441d960c0 7133581: [macosx] closed/javax/swing/JTree/4330357/bug4330357.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JTree/4330357/bug4330357.java From anthony.petrov at oracle.com Tue Feb 21 06:15:34 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Tue, 21 Feb 2012 14:15:34 +0000 Subject: hg: jdk8/awt/jdk: 7146572: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform Message-ID: <20120221141544.BC619475B6@hg.openjdk.java.net> Changeset: 04bc6f65d9ce Author: anthony Date: 2012-02-21 18:15 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/04bc6f65d9ce 7146572: enableInputMethod(false) does not work in the TextArea and TextField on the linux platform Summary: Peers' constructors shouldn't override user's enableInputMethod() settings Reviewed-by: anthony Contributed-by: Charles Lee ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java From pavel.porvatov at oracle.com Wed Feb 22 02:31:58 2012 From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com) Date: Wed, 22 Feb 2012 10:31:58 +0000 Subject: hg: jdk8/awt/jdk: 7107099: JScrollBar does not show up even if there are enough lebgth of textstring in textField Message-ID: <20120222103318.174BC47628@hg.openjdk.java.net> Changeset: 13a4490cba63 Author: rupashka Date: 2012-02-22 14:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/13a4490cba63 7107099: JScrollBar does not show up even if there are enough lebgth of textstring in textField Reviewed-by: alexp ! src/share/classes/javax/swing/JViewport.java + test/javax/swing/JViewport/7107099/bug7107099.java From oleg.pekhovskiy at oracle.com Wed Feb 22 04:57:52 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 22 Feb 2012 16:57:52 +0400 Subject: Code Review Request for CR 7145980 - Dispose method of window.java takes long Message-ID: <4F44E650.1020306@oracle.com> Hi guys, Please review the fix for CR: http://bugs.sun.com/view_bug.do?bug_id=7145980 webrev: http://cr.openjdk.java.net/~bagiras/7145980/webrev/ The main idea is to skip recalculation of component visible region when a top-level window is disposing. Thanks, Oleg -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120222/66cf80cf/attachment.html From anthony.petrov at oracle.com Wed Feb 22 05:26:24 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 22 Feb 2012 17:26:24 +0400 Subject: Code Review Request for CR 7145980 - Dispose method of window.java takes long In-Reply-To: <4F44E650.1020306@oracle.com> References: <4F44E650.1020306@oracle.com> Message-ID: <4F44ED00.3010502@oracle.com> Hi Oleg, The correct link to the webrev should be http://cr.openjdk.java.net/~bagiras/7145980/webrev/ Anyways, I suggest to make isMixingNeeded() return false if the containing window (a reference to which is already obtained in that method) is currently disposing. This way we avoid a double call to getContainingWindow(), and also will prevent any other mixing-related code from execution when the window is being disposed. In Window.java I suggest to use the following pattern: disposing = true; try { // do stuff } finally { disposing = false; } to ensure we don't leave the flag in 'true' state if some exceptions are thrown. -- best regards, Anthony On 2/22/2012 4:57 PM, Oleg Pekhovskiy wrote: > Hi guys, > > Please review the fix for CR: > http://bugs.sun.com/view_bug.do?bug_id=7145980 > > webrev: > http://cr.openjdk.java.net/~bagiras/7145980/webrev/ > > > The main idea is to skip recalculation of component visible region when > a top-level window is disposing. > > Thanks, > Oleg From oleg.pekhovskiy at oracle.com Wed Feb 22 08:15:57 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 22 Feb 2012 20:15:57 +0400 Subject: Code Review Request for CR 7145980 - Dispose method of window.java takes long In-Reply-To: <4F44ED00.3010502@oracle.com> References: <4F44E650.1020306@oracle.com> <4F44ED00.3010502@oracle.com> Message-ID: <4F4514BD.2090105@oracle.com> Hi Anthony, thanks for the review, I've prepared the next version of fix according to your proposals: http://cr.openjdk.java.net/~bagiras/7145980.2/ Thanks, Oleg 2/22/2012 5:26 PM, Anthony Petrov wrote: > Hi Oleg, > > The correct link to the webrev should be > http://cr.openjdk.java.net/~bagiras/7145980/webrev/ > > Anyways, I suggest to make isMixingNeeded() return false if the > containing window (a reference to which is already obtained in that > method) is currently disposing. This way we avoid a double call to > getContainingWindow(), and also will prevent any other mixing-related > code from execution when the window is being disposed. > > In Window.java I suggest to use the following pattern: > > disposing = true; > try { > // do stuff > } finally { > disposing = false; > } > > to ensure we don't leave the flag in 'true' state if some exceptions > are thrown. > > -- > best regards, > Anthony > > On 2/22/2012 4:57 PM, Oleg Pekhovskiy wrote: >> Hi guys, >> >> Please review the fix for CR: >> http://bugs.sun.com/view_bug.do?bug_id=7145980 >> >> webrev: >> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >> >> >> The main idea is to skip recalculation of component visible region >> when a top-level window is disposing. >> >> Thanks, >> Oleg From anthony.petrov at oracle.com Wed Feb 22 12:27:29 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 23 Feb 2012 00:27:29 +0400 Subject: Code Review Request for CR 7145980 - Dispose method of window.java takes long In-Reply-To: <4F4514BD.2090105@oracle.com> References: <4F44E650.1020306@oracle.com> <4F44ED00.3010502@oracle.com> <4F4514BD.2090105@oracle.com> Message-ID: <4F454FB1.8070605@oracle.com> Hi Oleg, The fix looks good. I'd also add the isDisposing() value to the logger output statement in isMixingNeeded() (in addition to the numbers of hw and lw descendants) to make sure the mixing log provides complete information about the reason isMixingNeeded() returns false. -- best regards, Anthony On 2/22/2012 8:15 PM, Oleg Pekhovskiy wrote: > Hi Anthony, > > thanks for the review, I've prepared the next version of fix according > to your proposals: > http://cr.openjdk.java.net/~bagiras/7145980.2/ > > > Thanks, > Oleg > > 2/22/2012 5:26 PM, Anthony Petrov wrote: >> Hi Oleg, >> >> The correct link to the webrev should be >> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >> >> Anyways, I suggest to make isMixingNeeded() return false if the >> containing window (a reference to which is already obtained in that >> method) is currently disposing. This way we avoid a double call to >> getContainingWindow(), and also will prevent any other mixing-related >> code from execution when the window is being disposed. >> >> In Window.java I suggest to use the following pattern: >> >> disposing = true; >> try { >> // do stuff >> } finally { >> disposing = false; >> } >> >> to ensure we don't leave the flag in 'true' state if some exceptions >> are thrown. >> >> -- >> best regards, >> Anthony >> >> On 2/22/2012 4:57 PM, Oleg Pekhovskiy wrote: >>> Hi guys, >>> >>> Please review the fix for CR: >>> http://bugs.sun.com/view_bug.do?bug_id=7145980 >>> >>> webrev: >>> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >>> >>> >>> The main idea is to skip recalculation of component visible region >>> when a top-level window is disposing. >>> >>> Thanks, >>> Oleg > From oleg.pekhovskiy at oracle.com Thu Feb 23 13:48:39 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Fri, 24 Feb 2012 01:48:39 +0400 Subject: Code Review Request for CR 7145980 - Dispose method of window.java takes long In-Reply-To: <4F454FB1.8070605@oracle.com> References: <4F44E650.1020306@oracle.com> <4F44ED00.3010502@oracle.com> <4F4514BD.2090105@oracle.com> <4F454FB1.8070605@oracle.com> Message-ID: <4F46B437.4060803@oracle.com> Hi Anthony, good idea, I added logging of isDisposing() method there: http://cr.openjdk.java.net/~bagiras/7145980.3/ Thanks, Oleg 23.02.2012 0:27, Anthony Petrov wrote: > Hi Oleg, > > The fix looks good. I'd also add the isDisposing() value to the logger > output statement in isMixingNeeded() (in addition to the numbers of hw > and lw descendants) to make sure the mixing log provides complete > information about the reason isMixingNeeded() returns false. > > -- > best regards, > Anthony > > On 2/22/2012 8:15 PM, Oleg Pekhovskiy wrote: >> Hi Anthony, >> >> thanks for the review, I've prepared the next version of fix >> according to your proposals: >> http://cr.openjdk.java.net/~bagiras/7145980.2/ >> >> >> Thanks, >> Oleg >> >> 2/22/2012 5:26 PM, Anthony Petrov wrote: >>> Hi Oleg, >>> >>> The correct link to the webrev should be >>> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >>> >>> Anyways, I suggest to make isMixingNeeded() return false if the >>> containing window (a reference to which is already obtained in that >>> method) is currently disposing. This way we avoid a double call to >>> getContainingWindow(), and also will prevent any other >>> mixing-related code from execution when the window is being disposed. >>> >>> In Window.java I suggest to use the following pattern: >>> >>> disposing = true; >>> try { >>> // do stuff >>> } finally { >>> disposing = false; >>> } >>> >>> to ensure we don't leave the flag in 'true' state if some exceptions >>> are thrown. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 2/22/2012 4:57 PM, Oleg Pekhovskiy wrote: >>>> Hi guys, >>>> >>>> Please review the fix for CR: >>>> http://bugs.sun.com/view_bug.do?bug_id=7145980 >>>> >>>> webrev: >>>> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >>>> >>>> >>>> The main idea is to skip recalculation of component visible region >>>> when a top-level window is disposing. >>>> >>>> Thanks, >>>> Oleg >> From anthony.petrov at oracle.com Thu Feb 23 13:54:32 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 24 Feb 2012 01:54:32 +0400 Subject: Code Review Request for CR 7145980 - Dispose method of window.java takes long In-Reply-To: <4F46B437.4060803@oracle.com> References: <4F44E650.1020306@oracle.com> <4F44ED00.3010502@oracle.com> <4F4514BD.2090105@oracle.com> <4F454FB1.8070605@oracle.com> <4F46B437.4060803@oracle.com> Message-ID: <4F46B598.10402@oracle.com> The fix looks fine. Thank you! -- best regards, Anthony On 2/24/2012 1:48 AM, Oleg Pekhovskiy wrote: > Hi Anthony, > > good idea, I added logging of isDisposing() method there: > http://cr.openjdk.java.net/~bagiras/7145980.3/ > > Thanks, > Oleg > > 23.02.2012 0:27, Anthony Petrov wrote: >> Hi Oleg, >> >> The fix looks good. I'd also add the isDisposing() value to the logger >> output statement in isMixingNeeded() (in addition to the numbers of hw >> and lw descendants) to make sure the mixing log provides complete >> information about the reason isMixingNeeded() returns false. >> >> -- >> best regards, >> Anthony >> >> On 2/22/2012 8:15 PM, Oleg Pekhovskiy wrote: >>> Hi Anthony, >>> >>> thanks for the review, I've prepared the next version of fix >>> according to your proposals: >>> http://cr.openjdk.java.net/~bagiras/7145980.2/ >>> >>> >>> Thanks, >>> Oleg >>> >>> 2/22/2012 5:26 PM, Anthony Petrov wrote: >>>> Hi Oleg, >>>> >>>> The correct link to the webrev should be >>>> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >>>> >>>> Anyways, I suggest to make isMixingNeeded() return false if the >>>> containing window (a reference to which is already obtained in that >>>> method) is currently disposing. This way we avoid a double call to >>>> getContainingWindow(), and also will prevent any other >>>> mixing-related code from execution when the window is being disposed. >>>> >>>> In Window.java I suggest to use the following pattern: >>>> >>>> disposing = true; >>>> try { >>>> // do stuff >>>> } finally { >>>> disposing = false; >>>> } >>>> >>>> to ensure we don't leave the flag in 'true' state if some exceptions >>>> are thrown. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 2/22/2012 4:57 PM, Oleg Pekhovskiy wrote: >>>>> Hi guys, >>>>> >>>>> Please review the fix for CR: >>>>> http://bugs.sun.com/view_bug.do?bug_id=7145980 >>>>> >>>>> webrev: >>>>> http://cr.openjdk.java.net/~bagiras/7145980/webrev/ >>>>> >>>>> >>>>> The main idea is to skip recalculation of component visible region >>>>> when a top-level window is disposing. >>>>> >>>>> Thanks, >>>>> Oleg >>> > From lana.steuck at oracle.com Thu Feb 23 14:13:22 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:13:22 +0000 Subject: hg: jdk8/awt: Added tag jdk8-b26 for changeset 2accafff224a Message-ID: <20120223221322.9EFE447675@hg.openjdk.java.net> Changeset: 1533dfab9903 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/1533dfab9903 Added tag jdk8-b26 for changeset 2accafff224a ! .hgtags From lana.steuck at oracle.com Thu Feb 23 14:13:20 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:13:20 +0000 Subject: hg: jdk8/awt/corba: Added tag jdk8-b26 for changeset 79f709a099f4 Message-ID: <20120223221324.9F66947676@hg.openjdk.java.net> Changeset: 4fffe75e4edd Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/4fffe75e4edd Added tag jdk8-b26 for changeset 79f709a099f4 ! .hgtags From lana.steuck at oracle.com Thu Feb 23 14:13:27 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:13:27 +0000 Subject: hg: jdk8/awt/jaxp: Added tag jdk8-b26 for changeset dbb7283c197b Message-ID: <20120223221327.38C1247677@hg.openjdk.java.net> Changeset: 80c47eb83d24 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/80c47eb83d24 Added tag jdk8-b26 for changeset dbb7283c197b ! .hgtags From lana.steuck at oracle.com Thu Feb 23 14:13:29 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:13:29 +0000 Subject: hg: jdk8/awt/jaxws: 5 new changesets Message-ID: <20120223221330.3A1B647678@hg.openjdk.java.net> Changeset: 329ace7198ac Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/329ace7198ac Added tag jdk8-b26 for changeset 3518639eab6c ! .hgtags Changeset: 6a8f54fb5f15 Author: alanb Date: 2012-02-05 12:07 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/6a8f54fb5f15 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com ! build-defs.xml ! jaxws.properties Changeset: 65977d8d348e Author: lana Date: 2012-02-09 22:53 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/65977d8d348e Merge Changeset: b962e9c3eba2 Author: alanb Date: 2012-02-15 17:32 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/b962e9c3eba2 7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle builds) Reviewed-by: ohair ! jaxws.properties Changeset: 38c037af4127 Author: lana Date: 2012-02-18 16:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/38c037af4127 Merge From lana.steuck at oracle.com Thu Feb 23 14:13:37 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:13:37 +0000 Subject: hg: jdk8/awt/langtools: 8 new changesets Message-ID: <20120223221359.1AD6B47679@hg.openjdk.java.net> Changeset: fba3cbee0fa3 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/fba3cbee0fa3 Added tag jdk8-b26 for changeset b556aa8a99c3 ! .hgtags Changeset: 2360c8213989 Author: darcy Date: 2012-02-05 21:59 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2360c8213989 7041249: Remove apt tool and API from the JDK Reviewed-by: jjg, ohair ! make/Makefile-classic ! make/build.properties ! make/build.xml ! make/netbeans/README - make/test/lib/apt.sh ! make/test/lib/src.gold.txt - src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java - src/share/classes/com/sun/mirror/apt/Filer.java - src/share/classes/com/sun/mirror/apt/Messager.java - src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java - src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java - src/share/classes/com/sun/mirror/apt/RoundState.java - src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationValue.java - src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java - src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java - src/share/classes/com/sun/mirror/declaration/Declaration.java - src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java - src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java - src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java - src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java - src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java - src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java - src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java - src/share/classes/com/sun/mirror/declaration/Modifier.java - src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java - src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/overview.html - src/share/classes/com/sun/mirror/type/AnnotationType.java - src/share/classes/com/sun/mirror/type/ArrayType.java - src/share/classes/com/sun/mirror/type/ClassType.java - src/share/classes/com/sun/mirror/type/DeclaredType.java - src/share/classes/com/sun/mirror/type/EnumType.java - src/share/classes/com/sun/mirror/type/InterfaceType.java - src/share/classes/com/sun/mirror/type/MirroredTypeException.java - src/share/classes/com/sun/mirror/type/MirroredTypesException.java - src/share/classes/com/sun/mirror/type/PrimitiveType.java - src/share/classes/com/sun/mirror/type/ReferenceType.java - src/share/classes/com/sun/mirror/type/TypeMirror.java - src/share/classes/com/sun/mirror/type/TypeVariable.java - src/share/classes/com/sun/mirror/type/VoidType.java - src/share/classes/com/sun/mirror/type/WildcardType.java - src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/util/DeclarationFilter.java - src/share/classes/com/sun/mirror/util/DeclarationScanner.java - src/share/classes/com/sun/mirror/util/DeclarationVisitor.java - src/share/classes/com/sun/mirror/util/DeclarationVisitors.java - src/share/classes/com/sun/mirror/util/Declarations.java - src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java - src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java - src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java - src/share/classes/com/sun/mirror/util/SourcePosition.java - src/share/classes/com/sun/mirror/util/TypeVisitor.java - src/share/classes/com/sun/mirror/util/Types.java - src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/tools/apt/Main.java - src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java - src/share/classes/com/sun/tools/apt/comp/Apt.java - src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java - src/share/classes/com/sun/tools/apt/comp/PrintAP.java - src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java - src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/CommandLine.java - src/share/classes/com/sun/tools/apt/main/Main.java - src/share/classes/com/sun/tools/apt/mirror/AptEnv.java - src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeElementDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationValueImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ClassDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ConstructorDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumConstantDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ExecutableDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/FieldDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/InterfaceDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MemberDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MethodDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/PackageDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/AnnotationTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ArrayTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ClassTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/DeclaredTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/EnumTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/PrimitiveTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMaker.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/VoidTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/WildcardTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/DeclarationsImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/TypesImpl.java - src/share/classes/com/sun/tools/apt/resources/apt.properties - src/share/classes/com/sun/tools/apt/resources/apt_ja.properties - src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties - src/share/classes/com/sun/tools/apt/util/Bark.java - test/tools/apt/Basics/Aggregate.java - test/tools/apt/Basics/ClassAnnotations.java - test/tools/apt/Basics/FreshnessApf.java - test/tools/apt/Basics/GenClass.java - test/tools/apt/Basics/Indirect.java - test/tools/apt/Basics/Lacuna.java - test/tools/apt/Basics/MethodAnnotations.java - test/tools/apt/Basics/Milk.java - test/tools/apt/Basics/MisMatch.java - test/tools/apt/Basics/Misc.java - test/tools/apt/Basics/MyMarker.java - test/tools/apt/Basics/MySimple.java - test/tools/apt/Basics/NestedClassAnnotations.java - test/tools/apt/Basics/ParameterAnnotations.java - test/tools/apt/Basics/StaticFieldAnnotations.java - test/tools/apt/Basics/StaticMethodAnnotations.java - test/tools/apt/Basics/TestGetPackageApf.java - test/tools/apt/Basics/TestGetTypeDeclarationApf.java - test/tools/apt/Basics/annot/AnnotMarker.java - test/tools/apt/Basics/annot/AnnotShangri_la.java - test/tools/apt/Basics/annot/AnnotSimple.java - test/tools/apt/Basics/annot/annot2/AnnotMarker2.java - test/tools/apt/Basics/annot/annot2/AnnotSimple2.java ! test/tools/apt/Basics/apt.sh - test/tools/apt/Basics/com.sun.mirror.apt.AnnotationProcessorFactory - test/tools/apt/Basics/foo/bar/Baz.java - test/tools/apt/Basics/foo/bar/Quux.java - test/tools/apt/Basics/golden.txt - test/tools/apt/Basics/goldenAggregate.txt - test/tools/apt/Basics/p1/p2.java - test/tools/apt/Basics/p1/p2/C1.java - test/tools/apt/Basics/print.sh - test/tools/apt/Compile/ClassDeclApf.java - test/tools/apt/Compile/ClassDeclApf2.java - test/tools/apt/Compile/Dummy1.java - test/tools/apt/Compile/ErrorAPF.java - test/tools/apt/Compile/HelloAnnotation.java - test/tools/apt/Compile/HelloWorld.java - test/tools/apt/Compile/Round1Apf.java - test/tools/apt/Compile/Round2Apf.java - test/tools/apt/Compile/Round3Apf.java - test/tools/apt/Compile/Round4Apf.java - test/tools/apt/Compile/Rounds.java - test/tools/apt/Compile/StaticApf.java - test/tools/apt/Compile/WarnAPF.java - test/tools/apt/Compile/WrappedStaticApf.java - test/tools/apt/Compile/compile.sh - test/tools/apt/Compile/golden.txt - test/tools/apt/Compile/goldenFactory.txt - test/tools/apt/Compile/goldenWarn.txt - test/tools/apt/Compile/servicesRound1 - test/tools/apt/Compile/servicesRound2 - test/tools/apt/Compile/servicesRound3 - test/tools/apt/Compile/servicesRound4 - test/tools/apt/Compile/servicesStaticApf - test/tools/apt/Compile/src/AhOneClass.java - test/tools/apt/Compile/src/AndAhTwoClass.java - test/tools/apt/Compile/src/Round1Class.java - test/tools/apt/Discovery/Dee.java - test/tools/apt/Discovery/Dum.java - test/tools/apt/Discovery/Empty.java - test/tools/apt/Discovery/PhantomTouch.java - test/tools/apt/Discovery/PhantomUpdate.java - test/tools/apt/Discovery/Touch.java - test/tools/apt/Discovery/discovery.sh - test/tools/apt/Discovery/servicesBadTouch - test/tools/apt/Discovery/servicesPhantomTouch - test/tools/apt/Discovery/servicesTouch - test/tools/apt/Discovery/servicesTweedle - test/tools/apt/Misc/Marked.java - test/tools/apt/Misc/Marker.java - test/tools/apt/Misc/Misc.java - test/tools/apt/Misc/misc.sh - test/tools/apt/Misc/servicesMisc - test/tools/apt/Options/Marked.java - test/tools/apt/Options/Marker.java - test/tools/apt/Options/OptionChecker.java - test/tools/apt/Options/options.sh - test/tools/apt/Options/servicesOptions - test/tools/apt/Scanners/Counter.java - test/tools/apt/Scanners/MemberOrderApf.java - test/tools/apt/Scanners/Order.java - test/tools/apt/Scanners/Scanner.java - test/tools/apt/Scanners/TestEnum.java - test/tools/apt/Scanners/VisitOrder.java - test/tools/apt/Scanners/scanner.sh - test/tools/apt/Scanners/servicesScanner - test/tools/apt/lib/Ignore.java - test/tools/apt/lib/Test.java - test/tools/apt/lib/TestProcessor.java - test/tools/apt/lib/TestProcessorFactory.java - test/tools/apt/lib/Tester.java - test/tools/apt/mirror/declaration/AnnoMirror.java - test/tools/apt/mirror/declaration/AnnoTypeDecl.java - test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java - test/tools/apt/mirror/declaration/AnnoVal.java - test/tools/apt/mirror/declaration/ClassDecl.java - test/tools/apt/mirror/declaration/ConstExpr.java - test/tools/apt/mirror/declaration/ConstructorDecl.java - test/tools/apt/mirror/declaration/EnumDecl.java - test/tools/apt/mirror/declaration/FieldDecl.java - test/tools/apt/mirror/declaration/GetAnno.java - test/tools/apt/mirror/declaration/InterfaceDecl.java - test/tools/apt/mirror/declaration/MethodDecl.java - test/tools/apt/mirror/declaration/PackageDecl.java - test/tools/apt/mirror/declaration/ParameterDecl.java - test/tools/apt/mirror/declaration/pkg1/AClass.java - test/tools/apt/mirror/declaration/pkg1/AnAnnoType.java - test/tools/apt/mirror/declaration/pkg1/AnEnum.java - test/tools/apt/mirror/declaration/pkg1/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/package-info.java - test/tools/apt/mirror/declaration/pkg1/pkg2/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/pkg2/package.html - test/tools/apt/mirror/type/AnnoTyp.java - test/tools/apt/mirror/type/ArrayTyp.java - test/tools/apt/mirror/type/ClassTyp.java - test/tools/apt/mirror/type/EnumTyp.java - test/tools/apt/mirror/type/InterfaceTyp.java - test/tools/apt/mirror/type/PrimitiveTyp.java - test/tools/apt/mirror/type/TypeVar.java - test/tools/apt/mirror/type/WildcardTyp.java - test/tools/apt/mirror/util/Overrides.java - test/tools/apt/mirror/util/TypeCreation.java Changeset: 2ac31f40741d Author: lana Date: 2012-02-09 22:56 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2ac31f40741d Merge Changeset: cd5ca700da4c Author: jjg Date: 2012-02-12 16:44 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/cd5ca700da4c 7144979: incorrect path separator in make/build.xml for Windows when running jtreg tests Reviewed-by: jjg Contributed-by: jan.valenta at oracle.com ! make/build.xml Changeset: 237198ef45f5 Author: jjh Date: 2012-02-13 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/237198ef45f5 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/T7142672/AnnoProcessor.java + test/tools/javac/T7142672/Bug.java + test/tools/javac/T7142672/Test2.java + test/tools/javac/T7142672/Test3.java Changeset: 84b61130cbed Author: mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to MethodSymbol.overrides Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/7142086/T7142086.java Changeset: e127334a64fe Author: darcy Date: 2012-02-17 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/e127334a64fe 7143910: test/tools/apt/Basics/apt.sh fails with 'real' sh Reviewed-by: darcy Contributed-by: sonali.goel at oracle.com ! test/tools/apt/Basics/apt.sh Changeset: be456f9c64e8 Author: lana Date: 2012-02-18 16:12 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/be456f9c64e8 Merge - make/test/lib/apt.sh - src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java - src/share/classes/com/sun/mirror/apt/Filer.java - src/share/classes/com/sun/mirror/apt/Messager.java - src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java - src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java - src/share/classes/com/sun/mirror/apt/RoundState.java - src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationValue.java - src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java - src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java - src/share/classes/com/sun/mirror/declaration/Declaration.java - src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java - src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java - src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java - src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java - src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java - src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java - src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java - src/share/classes/com/sun/mirror/declaration/Modifier.java - src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java - src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/overview.html - src/share/classes/com/sun/mirror/type/AnnotationType.java - src/share/classes/com/sun/mirror/type/ArrayType.java - src/share/classes/com/sun/mirror/type/ClassType.java - src/share/classes/com/sun/mirror/type/DeclaredType.java - src/share/classes/com/sun/mirror/type/EnumType.java - src/share/classes/com/sun/mirror/type/InterfaceType.java - src/share/classes/com/sun/mirror/type/MirroredTypeException.java - src/share/classes/com/sun/mirror/type/MirroredTypesException.java - src/share/classes/com/sun/mirror/type/PrimitiveType.java - src/share/classes/com/sun/mirror/type/ReferenceType.java - src/share/classes/com/sun/mirror/type/TypeMirror.java - src/share/classes/com/sun/mirror/type/TypeVariable.java - src/share/classes/com/sun/mirror/type/VoidType.java - src/share/classes/com/sun/mirror/type/WildcardType.java - src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/util/DeclarationFilter.java - src/share/classes/com/sun/mirror/util/DeclarationScanner.java - src/share/classes/com/sun/mirror/util/DeclarationVisitor.java - src/share/classes/com/sun/mirror/util/DeclarationVisitors.java - src/share/classes/com/sun/mirror/util/Declarations.java - src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java - src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java - src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java - src/share/classes/com/sun/mirror/util/SourcePosition.java - src/share/classes/com/sun/mirror/util/TypeVisitor.java - src/share/classes/com/sun/mirror/util/Types.java - src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/tools/apt/Main.java - src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java - src/share/classes/com/sun/tools/apt/comp/Apt.java - src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java - src/share/classes/com/sun/tools/apt/comp/PrintAP.java - src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java - src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/CommandLine.java - src/share/classes/com/sun/tools/apt/main/Main.java - src/share/classes/com/sun/tools/apt/mirror/AptEnv.java - src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeElementDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationValueImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ClassDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ConstructorDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumConstantDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ExecutableDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/FieldDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/InterfaceDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MemberDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MethodDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/PackageDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/AnnotationTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ArrayTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ClassTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/DeclaredTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/EnumTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/PrimitiveTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMaker.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/VoidTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/WildcardTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/DeclarationsImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/TypesImpl.java - src/share/classes/com/sun/tools/apt/resources/apt.properties - src/share/classes/com/sun/tools/apt/resources/apt_ja.properties - src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties - src/share/classes/com/sun/tools/apt/util/Bark.java - test/tools/apt/Basics/Aggregate.java - test/tools/apt/Basics/ClassAnnotations.java - test/tools/apt/Basics/FreshnessApf.java - test/tools/apt/Basics/GenClass.java - test/tools/apt/Basics/Indirect.java - test/tools/apt/Basics/Lacuna.java - test/tools/apt/Basics/MethodAnnotations.java - test/tools/apt/Basics/Milk.java - test/tools/apt/Basics/MisMatch.java - test/tools/apt/Basics/Misc.java - test/tools/apt/Basics/MyMarker.java - test/tools/apt/Basics/MySimple.java - test/tools/apt/Basics/NestedClassAnnotations.java - test/tools/apt/Basics/ParameterAnnotations.java - test/tools/apt/Basics/StaticFieldAnnotations.java - test/tools/apt/Basics/StaticMethodAnnotations.java - test/tools/apt/Basics/TestGetPackageApf.java - test/tools/apt/Basics/TestGetTypeDeclarationApf.java - test/tools/apt/Basics/annot/AnnotMarker.java - test/tools/apt/Basics/annot/AnnotShangri_la.java - test/tools/apt/Basics/annot/AnnotSimple.java - test/tools/apt/Basics/annot/annot2/AnnotMarker2.java - test/tools/apt/Basics/annot/annot2/AnnotSimple2.java - test/tools/apt/Basics/com.sun.mirror.apt.AnnotationProcessorFactory - test/tools/apt/Basics/foo/bar/Baz.java - test/tools/apt/Basics/foo/bar/Quux.java - test/tools/apt/Basics/golden.txt - test/tools/apt/Basics/goldenAggregate.txt - test/tools/apt/Basics/p1/p2.java - test/tools/apt/Basics/p1/p2/C1.java - test/tools/apt/Basics/print.sh - test/tools/apt/Compile/ClassDeclApf.java - test/tools/apt/Compile/ClassDeclApf2.java - test/tools/apt/Compile/Dummy1.java - test/tools/apt/Compile/ErrorAPF.java - test/tools/apt/Compile/HelloAnnotation.java - test/tools/apt/Compile/HelloWorld.java - test/tools/apt/Compile/Round1Apf.java - test/tools/apt/Compile/Round2Apf.java - test/tools/apt/Compile/Round3Apf.java - test/tools/apt/Compile/Round4Apf.java - test/tools/apt/Compile/Rounds.java - test/tools/apt/Compile/StaticApf.java - test/tools/apt/Compile/WarnAPF.java - test/tools/apt/Compile/WrappedStaticApf.java - test/tools/apt/Compile/compile.sh - test/tools/apt/Compile/golden.txt - test/tools/apt/Compile/goldenFactory.txt - test/tools/apt/Compile/goldenWarn.txt - test/tools/apt/Compile/servicesRound1 - test/tools/apt/Compile/servicesRound2 - test/tools/apt/Compile/servicesRound3 - test/tools/apt/Compile/servicesRound4 - test/tools/apt/Compile/servicesStaticApf - test/tools/apt/Compile/src/AhOneClass.java - test/tools/apt/Compile/src/AndAhTwoClass.java - test/tools/apt/Compile/src/Round1Class.java - test/tools/apt/Discovery/Dee.java - test/tools/apt/Discovery/Dum.java - test/tools/apt/Discovery/Empty.java - test/tools/apt/Discovery/PhantomTouch.java - test/tools/apt/Discovery/PhantomUpdate.java - test/tools/apt/Discovery/Touch.java - test/tools/apt/Discovery/discovery.sh - test/tools/apt/Discovery/servicesBadTouch - test/tools/apt/Discovery/servicesPhantomTouch - test/tools/apt/Discovery/servicesTouch - test/tools/apt/Discovery/servicesTweedle - test/tools/apt/Misc/Marked.java - test/tools/apt/Misc/Marker.java - test/tools/apt/Misc/Misc.java - test/tools/apt/Misc/misc.sh - test/tools/apt/Misc/servicesMisc - test/tools/apt/Options/Marked.java - test/tools/apt/Options/Marker.java - test/tools/apt/Options/OptionChecker.java - test/tools/apt/Options/options.sh - test/tools/apt/Options/servicesOptions - test/tools/apt/Scanners/Counter.java - test/tools/apt/Scanners/MemberOrderApf.java - test/tools/apt/Scanners/Order.java - test/tools/apt/Scanners/Scanner.java - test/tools/apt/Scanners/TestEnum.java - test/tools/apt/Scanners/VisitOrder.java - test/tools/apt/Scanners/scanner.sh - test/tools/apt/Scanners/servicesScanner - test/tools/apt/lib/Ignore.java - test/tools/apt/lib/Test.java - test/tools/apt/lib/TestProcessor.java - test/tools/apt/lib/TestProcessorFactory.java - test/tools/apt/lib/Tester.java - test/tools/apt/mirror/declaration/AnnoMirror.java - test/tools/apt/mirror/declaration/AnnoTypeDecl.java - test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java - test/tools/apt/mirror/declaration/AnnoVal.java - test/tools/apt/mirror/declaration/ClassDecl.java - test/tools/apt/mirror/declaration/ConstExpr.java - test/tools/apt/mirror/declaration/ConstructorDecl.java - test/tools/apt/mirror/declaration/EnumDecl.java - test/tools/apt/mirror/declaration/FieldDecl.java - test/tools/apt/mirror/declaration/GetAnno.java - test/tools/apt/mirror/declaration/InterfaceDecl.java - test/tools/apt/mirror/declaration/MethodDecl.java - test/tools/apt/mirror/declaration/PackageDecl.java - test/tools/apt/mirror/declaration/ParameterDecl.java - test/tools/apt/mirror/declaration/pkg1/AClass.java - test/tools/apt/mirror/declaration/pkg1/AnAnnoType.java - test/tools/apt/mirror/declaration/pkg1/AnEnum.java - test/tools/apt/mirror/declaration/pkg1/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/package-info.java - test/tools/apt/mirror/declaration/pkg1/pkg2/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/pkg2/package.html - test/tools/apt/mirror/type/AnnoTyp.java - test/tools/apt/mirror/type/ArrayTyp.java - test/tools/apt/mirror/type/ClassTyp.java - test/tools/apt/mirror/type/EnumTyp.java - test/tools/apt/mirror/type/InterfaceTyp.java - test/tools/apt/mirror/type/PrimitiveTyp.java - test/tools/apt/mirror/type/TypeVar.java - test/tools/apt/mirror/type/WildcardTyp.java - test/tools/apt/mirror/util/Overrides.java - test/tools/apt/mirror/util/TypeCreation.java From lana.steuck at oracle.com Thu Feb 23 14:13:57 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:13:57 +0000 Subject: hg: jdk8/awt/hotspot: 69 new changesets Message-ID: <20120223221623.B9CD74767A@hg.openjdk.java.net> Changeset: 3c4621be5149 Author: amurillo Date: 2012-02-06 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3c4621be5149 7143122: new hotspot build - hs23-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 869be5c8882e Author: phh Date: 2012-02-03 17:21 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/869be5c8882e 7142586: Cannot build on Solaris 11 due to use of ia_nice Summary: Delete the single use of ia_nice in os_solaris.cpp Reviewed-by: kamg, kvn ! src/os/solaris/vm/os_solaris.cpp Changeset: c77d473e71f7 Author: ohrstrom Date: 2012-01-31 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c77d473e71f7 7132779: build-infra merge: Enable ccache to work for most developer builds. Summary: When a build number is not specified, the JRE_RELEASE_VERSION define contains a date and timestamp. Thus ccache cannot cache the object files for longer than a minute since the define is passed to the compilation of all source files. This change passes JRE_RELEASE_VERSION only to vm_version.cpp and adds a function jre_release_version() to Abstract_VM_Version. This allows all other source files to be ccached. Reviewed-by: ohair, rottenha Contributed-by: fredrik.ohrstrom at oracle.com ! make/bsd/makefiles/vm.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: 719f7007c8e8 Author: erikj Date: 2012-02-06 09:14 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/719f7007c8e8 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Summary: Cleaned up make variables for compilers and linker to consistently use CXX for C++ compiler, CC for C compiler and LD for linker. Reviewed-by: dholmes, ohrstrom ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make Changeset: ea677dbdd883 Author: fparain Date: 2012-02-07 12:34 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ea677dbdd883 Merge Changeset: 5e9fba4e8718 Author: kvn Date: 2012-02-07 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5e9fba4e8718 7142167: MAC: _get_previous_fp broken on bsd with llvm-gcc Summary: LLVM-GCC (__llvm__) should use the same _get_previous_fp implementation as __clang__ (as is the case for os::current_stack_pointer). Reviewed-by: twisti, never, dcubed ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: b9bc6cae88f2 Author: kvn Date: 2012-02-07 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b9bc6cae88f2 7143491: G1 C2 CTW: assert(p2x->outcnt() == 2) failed: expects 2 users: Xor and URShift nodes Summary: Adjust the assert and code in eliminate_card_mark() method for case when stored value is NULL. Reviewed-by: iveresov, never ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp Changeset: c742b0b47fe5 Author: roland Date: 2012-02-08 09:52 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c742b0b47fe5 7119286: JSR292: SIGSEGV in JNIHandleBlock::release_block(JNIHandleBlock*, Thread*)+0x3c Summary: unaligned stack in throw_NullPointerException_at_call_entry(). Reviewed-by: twisti, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 2f985b6ce7ff Author: jrose Date: 2012-02-09 18:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2f985b6ce7ff Merge Changeset: 1ac084126285 Author: dlong Date: 2012-01-24 18:00 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1ac084126285 7130319: C2: running with -XX:+PrintOptoAssembly crashes the VM with assert(false) failed: bad tag in log Summary: Relax assert to allow the VMThread to close the log while the compiler thread is still writing to it. Reviewed-by: dholmes, never Contributed-by: dean.long at oracle.com ! src/share/vm/utilities/xmlstream.cpp Changeset: d851f3714641 Author: dholmes Date: 2012-01-25 19:26 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d851f3714641 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: a79cb7c55012 Author: jiangli Date: 2012-01-25 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a79cb7c55012 7132690: InstanceKlass:_reference_type should be u1 type Summary: Change InstanceKlass::_reference_type to u1 type. Reviewed-by: dholmes, coleenp, acorn Contributed-by: Jiangli Zhou ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f3fa16bd7159 Author: bobv Date: 2012-01-25 21:30 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f3fa16bd7159 Merge Changeset: b7b8b6d2f97d Author: bpittore Date: 2012-02-06 10:57 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b7b8b6d2f97d Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f174909614bd Author: bpittore Date: 2012-02-10 10:55 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f174909614bd Merge ! src/share/vm/opto/library_call.cpp Changeset: d71e662fe037 Author: amurillo Date: 2012-02-10 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d71e662fe037 Merge Changeset: fd3060701216 Author: amurillo Date: 2012-02-10 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fd3060701216 Added tag hs23-b15 for changeset d71e662fe037 ! .hgtags Changeset: 087daaec688d Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/087daaec688d Added tag jdk8-b26 for changeset fd3060701216 ! .hgtags Changeset: 094138495da4 Author: amurillo Date: 2012-02-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/094138495da4 7144322: new hotspot build - hs23-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 77a488cd4af2 Author: dlong Date: 2012-02-15 00:51 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/77a488cd4af2 7140866: assert(covered) failed: Card for end of new region not committed Summary: resize covered region only after successfully mapping shared archive Reviewed-by: brutisso, ysr Contributed-by: dean.long at oracle.com ! src/share/vm/memory/compactingPermGenGen.cpp Changeset: f9961b6498f9 Author: bpittore Date: 2012-02-15 16:09 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f9961b6498f9 Merge Changeset: 95f6641e38e0 Author: iveresov Date: 2012-02-10 17:40 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/95f6641e38e0 7144296: PS: Optimize nmethods processing Summary: Prunes scavenge roots in code list every young GC, promote objects directly pointed by the code immediately Reviewed-by: johnc, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp Changeset: caa4652b4414 Author: tonyp Date: 2012-02-14 08:21 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/caa4652b4414 7129892: G1: explicit marking cycle initiation might fail to initiate a marking cycle Summary: If we try to schedule an initial-mark GC in order to explicit start a conc mark cycle and it gets pre-empted by antoher GC, we should retry the attempt as long as it's appropriate for the GC cause. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: d903bf750e9f Author: johnc Date: 2012-01-18 09:50 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d903bf750e9f 7129514: time warp warnings after 7117303 Summary: Replace calls to os::javaTimeMillis() that are used to update the milliseconds since the last GC to an equivalent that uses a monotonically non-decreasing time source. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: a9647476d1a4 Author: tonyp Date: 2012-02-15 13:06 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a9647476d1a4 7132029: G1: mixed GC phase lasts for longer than it should Summary: Revamp of the mechanism that chooses old regions for inclusion in the CSet. It simplifies the code and introduces min and max bounds on the number of old regions added to the CSet at each mixed GC to avoid pathological cases. It also ensures that when we do a mixed GC we'll always find old regions to add to the CSet (i.e., it eliminates the case where a mixed GC will collect no old regions which can happen today). Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: ab4422d0ed59 Author: jcoomes Date: 2012-02-16 13:12 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ab4422d0ed59 7146343: PS invoke methods should indicate the type of gc done Reviewed-by: stefank, jmasa ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp Changeset: 23c0eb012d6f Author: jcoomes Date: 2012-02-16 13:13 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/23c0eb012d6f 6330863: vm/gc/InfiniteList.java fails intermittently due to timeout Summary: in some cases, allocate from the old gen before doing a full gc Reviewed-by: stefank, jmasa ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp Changeset: be398bba40e9 Author: stefank Date: 2012-02-17 13:23 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/be398bba40e9 Merge Changeset: 1b0e0f8be510 Author: minqi Date: 2012-02-09 00:51 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1b0e0f8be510 7131006: java/lang/management/ThreadMXBean/ThreadLists.java Reviewed-by: dholmes, acorn ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/utilities/preserveException.cpp Changeset: db006a85bf91 Author: zgu Date: 2012-02-09 10:16 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/db006a85bf91 7141259: Native stack is missing in hs_err Summary: Code cleanup and creating a private decoder for error handler, since it can be triggered from in signal handler, where no lock can be taken Reviewed-by: dholmes, kamg, acorn, coleenp ! src/os/bsd/vm/decoder_machO.hpp ! src/os/windows/vm/decoder_windows.hpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/decoder_elf.hpp ! src/share/vm/utilities/vmError.hpp Changeset: ea527c5cde03 Author: zgu Date: 2012-02-09 07:35 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ea527c5cde03 Merge Changeset: 54d3535a6dd3 Author: poonam Date: 2012-02-12 19:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/54d3535a6dd3 7009098: SA cannot open core files larger than 2GB on Linux 32-bit Summary: Added Large File Support by compiling libsaproc.so with -D_FILE_OFFSET_BITS=64, and a small change with which SA should first load libraries from the path specified with SA_ALTROOT. Reviewed-by: dholmes, kevinw, dcubed, minqi ! agent/src/os/linux/Makefile ! agent/src/os/linux/libproc_impl.c ! make/linux/makefiles/saproc.make Changeset: 1bb2838e2fc1 Author: fparain Date: 2012-02-13 06:24 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1bb2838e2fc1 Merge Changeset: 849412a95e45 Author: coleenp Date: 2012-02-13 12:30 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/849412a95e45 7059899: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV Summary: Increase StackShadowPages to accomodate the JDK changes to increase buffer size in socketWrite Reviewed-by: acorn, phh ! src/cpu/x86/vm/globals_x86.hpp Changeset: 1891640ca63f Author: fparain Date: 2012-02-14 06:54 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1891640ca63f 7143760: Memory leak in GarbageCollectionNotifications Reviewed-by: dholmes, dcubed, kamg ! src/share/vm/services/gcNotifier.cpp ! src/share/vm/services/gcNotifier.hpp Changeset: a9831b955a0a Author: kamg Date: 2012-02-13 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a9831b955a0a 7069991: Setup make/jprt.properties files for jdk8 Summary: Change default release value to jdk8 (but overrideable) Reviewed-by: phh, jcoomes, dholmes, ohair ! make/jprt.properties Changeset: a9ac4910e7f2 Author: kamg Date: 2012-02-14 15:52 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a9ac4910e7f2 Merge Changeset: 28d91e43ab6d Author: coleenp Date: 2012-02-14 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/28d91e43ab6d 7145587: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV (sparc version) Summary: Increase StackShadowPages to accomodate the JDK changes to increase buffer size in socketWrite Reviewed-by: acorn, phh, dcubed, kamg, dsamersoff ! src/cpu/sparc/vm/globals_sparc.hpp Changeset: cf772dff4bfd Author: coleenp Date: 2012-02-14 18:35 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cf772dff4bfd Merge Changeset: b8a4e1d372a0 Author: kamg Date: 2012-02-14 20:02 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b8a4e1d372a0 7145589: First JSDT provider creation fails Summary: 0 is a successful return from an ioctl() call Reviewed-by: dcubed, phh, dsamersoff ! src/share/vm/runtime/dtraceJSDT.cpp Changeset: 91a81502a27d Author: kamg Date: 2012-02-15 00:09 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/91a81502a27d Merge Changeset: 2b150750d53d Author: sspitsyn Date: 2012-02-14 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2b150750d53d 7130993: nsk/jdi/ReferenceType/instances/instances004 fails with JFR: assert(ServiceUtil::visible_oop(obj)) Summary: Skip reporting invisible refs in iterate_over_object to avoid assert(ServiceUtil::visible_oop(obj)) Reviewed-by: dcubed, mgronlun, rbackman Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: cd239a88b90c Author: minqi Date: 2012-02-14 20:54 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cd239a88b90c Merge Changeset: 64fc5ac1b770 Author: minqi Date: 2012-02-14 23:50 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/64fc5ac1b770 Merge Changeset: f1cb6f9cfe21 Author: fparain Date: 2012-02-15 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f1cb6f9cfe21 7145243: Need additional specializations for argument parsing framework Reviewed-by: acorn, fparain Contributed-by: nils.loodin at oracle.com ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticArgument.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp Changeset: 4a24c4f648bd Author: phh Date: 2012-02-16 13:50 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4a24c4f648bd 7142113: Add Ivy Bridge to the known Intel x86 cpu families Summary: In vm_version_x86.hpp, add and use CPU_MODEL_IVYBRIDGE_EP, and restrict is_intel_tsc_synced_at_init() to EP models. Reviewed-by: kvn, acorn ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: 7df3125953cb Author: coleenp Date: 2012-02-16 15:52 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7df3125953cb 7146354: Re-enable Compressed OOPs after 7118647 is resolved Summary: Relax the assertion to simply check for COOP mode rather than an exact address. Reviewed-by: coleenp, kvn, phh, dcubed Contributed-by: james.melvin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/virtualspace.cpp Changeset: df4927a3b82e Author: coleenp Date: 2012-02-16 17:19 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/df4927a3b82e Merge Changeset: d3384450b649 Author: fparain Date: 2012-02-17 06:34 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d3384450b649 Merge Changeset: 73df3733f2eb Author: kvn Date: 2012-02-10 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/73df3733f2eb 7129284: +DoEscapeAnalysis regression w/ early build of 7u4 (HotSpot 23) on Linux Summary: Removed code which tried to create edges from fields of destination objects of arraycopy to fields of source objects. Added 30 sec time limit for EA graph construction. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: de34c646c3f7 Author: kvn Date: 2012-02-10 17:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/de34c646c3f7 7140985: HSDIS does not handle caller options correctly Summary: Fix typo. Reviewed-by: jrose, kvn Contributed-by: Andrew Haley ! src/share/tools/hsdis/hsdis.c Changeset: 45a1bf98f1bb Author: twisti Date: 2012-02-13 02:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/45a1bf98f1bb 7141329: Strange values of stack_size in -XX:+TraceMethodHandles output Reviewed-by: kvn, never ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: f09ae3853e3b Author: twisti Date: 2012-02-13 04:30 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f09ae3853e3b 7143766: add ALT_JDK_IMAGE_DIR and improve test_jdk Reviewed-by: rbackman, jrose, dholmes ! make/Makefile ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/top.make ! make/defs.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/top.make Changeset: b522995d91f0 Author: roland Date: 2012-02-14 09:43 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b522995d91f0 7144405: JumbleGC002 assert(m->offset() == pc_offset) failed: oopmap not found Summary: oop map needs pc stored in frame anchor in StubGenerator::generate_throw_exception() Reviewed-by: twisti, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 8f4eb44b3b76 Author: never Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8f4eb44b3b76 7143061: nsk/stress/stack/b4525850 crash VM Reviewed-by: kvn, twisti ! src/cpu/x86/vm/globals_x86.hpp Changeset: 80107dc493db Author: roland Date: 2012-02-15 09:43 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/80107dc493db 7126041: jdk7u4 b05 and b06 crash with RubyMine 3.2.4, works well with b04 Summary: Goto that replaces a If mistaken to be a back branch and triggers erroneous OSR compilation. Reviewed-by: never, iveresov ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: 09d00c18e323 Author: never Date: 2012-02-15 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/09d00c18e323 7145537: minor tweaks to LogEvents Reviewed-by: kvn, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp Changeset: cfdfbeac0a5b Author: iveresov Date: 2012-02-15 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cfdfbeac0a5b 7145345: Code cache sweeper must cooperate with safepoints Summary: Safepoint in the sweeper loop in necessary Reviewed-by: kvn, never ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp Changeset: 69333a2fbae2 Author: iveresov Date: 2012-02-15 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/69333a2fbae2 7142680: default GC affected by jvm path Summary: Removed old tiered code Reviewed-by: never, kvn ! src/share/vm/runtime/arguments.cpp Changeset: fd8114661503 Author: kvn Date: 2012-02-15 21:37 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fd8114661503 7125136: SIGILL on linux amd64 in gc/ArrayJuggle/Juggle29 Summary: For C2 moved saving EBP after ESP adjustment. For C1 generated 5 byte nop instruction first if needed. Reviewed-by: never, twisti, azeemj ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/output.cpp Changeset: c7401dcad8bf Author: roland Date: 2012-02-16 09:20 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c7401dcad8bf 7143038: SIGSEGV in assert_equal / LinearScan::assign_reg_num Summary: forced exit may destory global objects that are still in use. Reviewed-by: twisti, never, kvn ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp Changeset: ad3b47344802 Author: never Date: 2012-02-16 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ad3b47344802 7144318: GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint( Reviewed-by: kvn, twisti ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp Changeset: 9b8ce46870df Author: kvn Date: 2012-02-16 17:12 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9b8ce46870df 7145346: VerifyStackAtCalls is broken Summary: Replace call_epilog() encoding with macroassembler use. Moved duplicated code to x86.ad. Fixed return_addr() definition. Reviewed-by: never ! src/cpu/x86/vm/x86.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_32.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_64.ad ! src/os_cpu/linux_x86/vm/linux_x86_32.ad ! src/os_cpu/linux_x86/vm/linux_x86_64.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_32.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad ! src/os_cpu/windows_x86/vm/windows_x86_32.ad ! src/os_cpu/windows_x86/vm/windows_x86_64.ad ! src/share/vm/opto/chaitin.cpp Changeset: 72c425c46102 Author: never Date: 2012-02-17 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/72c425c46102 7146729: nightly failure after 7141200: tty is sometimes null during shutdown of main thread Reviewed-by: kvn ! src/share/vm/utilities/events.hpp Changeset: 15085a6eb50c Author: never Date: 2012-02-17 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/15085a6eb50c Merge ! src/cpu/x86/vm/globals_x86.hpp ! src/share/vm/runtime/arguments.cpp Changeset: f92a171cf007 Author: amurillo Date: 2012-02-17 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f92a171cf007 Merge Changeset: 98cd09d11a21 Author: amurillo Date: 2012-02-17 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/98cd09d11a21 Added tag hs23-b16 for changeset f92a171cf007 ! .hgtags Changeset: 931e5f39e365 Author: kvn Date: 2012-02-20 13:11 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/931e5f39e365 7147064: assert(allocates2(pc)) failed: not in CodeBuffer memory: 0xffffffff778d9d60 <= 0xffffffff778da69c Summary: Increase size of deopt_blob and uncommon_trap_blob by size of stack bang code (SPARC). Reviewed-by: azeemj, iveresov, never, phh ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp Changeset: 3b24e7e01d20 Author: jcoomes Date: 2012-02-20 22:32 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3b24e7e01d20 Added tag hs23-b16 for changeset 931e5f39e365 ! .hgtags From lana.steuck at oracle.com Thu Feb 23 14:14:33 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 22:14:33 +0000 Subject: hg: jdk8/awt/jdk: 38 new changesets Message-ID: <20120223222107.0DF2F4767B@hg.openjdk.java.net> Changeset: 4196fc971f65 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4196fc971f65 Added tag jdk8-b26 for changeset 5aca406e87cb ! .hgtags Changeset: 7a5c8c6f1c6b Author: prr Date: 2012-02-03 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7a5c8c6f1c6b 7141914: Draw glyph cause JVM crash Reviewed-by: bae, igor ! src/share/classes/sun/font/FileFont.java ! src/share/classes/sun/font/StandardGlyphVector.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java Changeset: 996cd6e8d00e Author: lana Date: 2012-02-09 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/996cd6e8d00e Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: a06fd6ada85c Author: prr Date: 2012-02-14 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a06fd6ada85c 7143612: improve backwards compatibility of OSIS post-CR6887286 Reviewed-by: flar, prr Contributed-by: david.buck at oracle.com ! src/share/classes/sun/awt/image/OffScreenImageSource.java Changeset: 24e30ae2a192 Author: lana Date: 2012-02-15 15:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/24e30ae2a192 Merge Changeset: ac26d04e76c3 Author: fparain Date: 2012-02-01 03:52 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ac26d04e76c3 7120974: ManagementPermission "control" needs clarification Reviewed-by: mchung, dholmes ! src/share/classes/java/lang/management/ManagementPermission.java Changeset: 55a82eba1986 Author: wetmore Date: 2012-02-01 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/55a82eba1986 7141910: Incorrect copyright dates on new test cases. Reviewed-by: mullan ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh Changeset: 24478d62d068 Author: ksrini Date: 2012-02-02 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/24478d62d068 7141141: Add 3 new test scenarios for testing Main-Class attribute in jar manifest file Reviewed-by: ksrini, darcy Contributed-by: sonali.goel at oracle.com ! test/tools/launcher/Arrrghs.java + test/tools/launcher/MainClassAttributeTest.java Changeset: bbadb6605a1c Author: chegar Date: 2012-02-04 07:29 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbadb6605a1c 7041778: Move SCTP implementation out of sun.nio.ch and into its own package Reviewed-by: alanb ! make/com/sun/nio/sctp/Exportedfiles.gmk ! make/com/sun/nio/sctp/FILES_java.gmk ! make/com/sun/nio/sctp/Makefile ! make/com/sun/nio/sctp/mapfile-vers ! src/share/classes/com/sun/nio/sctp/MessageInfo.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/share/classes/com/sun/nio/sctp/SctpServerChannel.java ! src/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java ! src/share/classes/sun/nio/ch/AbstractPollArrayWrapper.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/Net.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java ! src/share/classes/sun/nio/ch/SelChImpl.java ! src/share/classes/sun/nio/ch/SelectionKeyImpl.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/Util.java + src/share/classes/sun/nio/ch/sctp/MessageInfoImpl.java + src/share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/NativeThread.java ! src/solaris/classes/sun/nio/ch/PollArrayWrapper.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java + src/solaris/classes/sun/nio/ch/sctp/AssociationChange.java + src/solaris/classes/sun/nio/ch/sctp/AssociationImpl.java + src/solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java + src/solaris/classes/sun/nio/ch/sctp/ResultContainer.java + src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SctpNet.java + src/solaris/classes/sun/nio/ch/sctp/SctpNotification.java + src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SendFailed.java + src/solaris/classes/sun/nio/ch/sctp/Shutdown.java - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c + src/solaris/native/sun/nio/ch/sctp/Sctp.h + src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c + src/solaris/native/sun/nio/ch/sctp/SctpNet.c + src/solaris/native/sun/nio/ch/sctp/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java Changeset: e528a64dd21b Author: chegar Date: 2012-02-04 07:36 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e528a64dd21b Merge Changeset: ce5ffdb2be25 Author: alanb Date: 2012-02-05 12:29 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ce5ffdb2be25 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com ! make/common/Release.gmk ! make/common/internal/Defs-jaxws.gmk Changeset: e55522710586 Author: darcy Date: 2012-02-05 21:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e55522710586 7041249: Remove apt tool and API from the JDK Reviewed-by: jjg, ohair ! make/com/sun/Makefile ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! make/docs/Makefile ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 Changeset: c6d6ef8ec2bf Author: alanb Date: 2012-02-07 13:28 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c6d6ef8ec2bf 7142847: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java has incorrect @run tag, runs Basic Reviewed-by: chegar ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/SensitivityModifier.java Changeset: 946056e6116e Author: darcy Date: 2012-02-07 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/946056e6116e 7143629: JDK jar/zip code should use unsigned library support Reviewed-by: sherman ! src/share/classes/java/util/jar/JarOutputStream.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/zip/InflaterInputStream.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipConstants.java Changeset: 085c4f780d4e Author: weijun Date: 2012-02-08 11:44 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/085c4f780d4e 6880619: reg tests for 6879540 Reviewed-by: valeriep + test/sun/security/krb5/auto/EmptyPassword.java Changeset: c64c815974ff Author: chegar Date: 2012-02-08 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c64c815974ff 7105929: java/util/concurrent/FutureTask/BlockingTaskExecutor.java fails on solaris sparc Reviewed-by: dholmes ! test/java/util/concurrent/FutureTask/BlockingTaskExecutor.java Changeset: 7289599216fe Author: gadams Date: 2012-02-08 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7289599216fe 6736316: Timeout value in java/util/concurrent/locks/Lock/FlakyMutex.java is insufficient Reviewed-by: chegar, dholmes, alanb ! test/java/util/concurrent/locks/Lock/FlakyMutex.java Changeset: 72d8f91514d1 Author: gadams Date: 2012-02-08 11:19 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/72d8f91514d1 6957683: test/java/util/concurrent/ThreadPoolExecutor/Custom.java failing Reviewed-by: chegar, dholmes, alanb ! test/java/util/concurrent/ThreadPoolExecutor/Custom.java Changeset: 184b9cb4f13a Author: alanb Date: 2012-02-09 13:43 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/184b9cb4f13a 7114611: (fs) DirectoryStream fails with SIGBUS on some embedded platforms, dirent alignment Reviewed-by: dholmes, alanb Contributed-by: carlos.lucasius at oracle.com ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Changeset: 8326d434681d Author: alanb Date: 2012-02-09 16:38 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8326d434681d 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently Reviewed-by: chegar ! test/java/nio/file/WatchService/SensitivityModifier.java Changeset: bdd1dd1e1462 Author: weijun Date: 2012-02-10 11:41 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bdd1dd1e1462 6879539: enable empty password support for pkcs12 keystore Reviewed-by: vinnie, weijun Contributed-by: Florian Weimer ! src/share/classes/com/sun/crypto/provider/PBEKey.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/sun/security/pkcs12/Bug6415637.java Changeset: 7fc2797cbb4c Author: lana Date: 2012-02-09 22:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fc2797cbb4c Merge Changeset: b16cbeb0d213 Author: wetmore Date: 2012-02-10 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b16cbeb0d213 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Reviewed-by: valeriep ! src/share/classes/javax/crypto/CipherSpi.java + test/javax/crypto/CipherSpi/DirectBBRemaining.java Changeset: da8b8ee281f9 Author: xuelei Date: 2012-02-10 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/da8b8ee281f9 7144781: incorrect URLs in JSSE java doc Reviewed-by: wetmore, skannan ! src/share/classes/javax/net/ssl/ExtendedSSLSession.java ! src/share/classes/javax/net/ssl/SSLParameters.java Changeset: 27a6b299ed6a Author: chegar Date: 2012-02-12 08:47 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27a6b299ed6a 7133367: ResponseCache.put should not be called when setUseCaches(false) Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/NoCache.java Changeset: 27e746e6f3fe Author: alanb Date: 2012-02-12 21:09 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27e746e6f3fe 7144895: ProblemList.txt updates (2/2012) Reviewed-by: darcy, ohair ! test/Makefile ! test/ProblemList.txt ! test/TEST.ROOT Changeset: 445ada5e6b4a Author: smarks Date: 2012-02-12 21:56 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/445ada5e6b4a 7143230: fix warnings in java.util.jar, sun.tools.jar, zipfs demo, etc. Reviewed-by: alanb, chegar, lancea, smarks Contributed-by: Mani Sarkar , Michael Barker , Carl Jokl , Dinuk Weerasinghe , Markus Stoy , Tom Anderson ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/sun/tools/jar/CommandLine.java ! src/share/classes/sun/tools/jar/Manifest.java ! src/share/classes/sun/tools/jar/SignatureFile.java ! src/share/demo/management/MemoryMonitor/MemoryMonitor.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java Changeset: 3554f175341a Author: vinnie Date: 2012-02-13 14:26 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3554f175341a 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done Reviewed-by: xuelei, wetmore ! src/share/classes/sun/security/pkcs/PKCS7.java Changeset: 59bd472746d6 Author: vinnie Date: 2012-02-13 14:31 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/59bd472746d6 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java Changeset: f62077973f9b Author: vinnie Date: 2012-02-14 11:47 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f62077973f9b 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Reviewed-by: xuelei ! test/sun/security/tools/jarsigner/ec.sh Changeset: 13aef38438d8 Author: fparain Date: 2012-02-14 07:28 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/13aef38438d8 7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData Reviewed-by: fparain, dholmes ! test/sun/tools/jcmd/jcmd-Defaults.sh ! test/sun/tools/jcmd/jcmd-f.sh ! test/sun/tools/jcmd/jcmd-help-help.sh ! test/sun/tools/jcmd/jcmd-help.sh ! test/sun/tools/jcmd/jcmd-pid.sh Changeset: 0720542d6c1e Author: mullan Date: 2012-02-15 07:45 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0720542d6c1e 7024604: OID.1 causes IAE in X500Principal constructor Reviewed-by: vinnie ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/classes/javax/security/auth/x500/package.html ! test/javax/security/auth/x500/X500Principal/Parse.java Changeset: 3207b3e271f2 Author: mullan Date: 2012-02-15 07:52 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3207b3e271f2 Merge Changeset: 59884f656b7d Author: fparain Date: 2012-02-15 09:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/59884f656b7d 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/tools/jcmd/jcmd_Output1.awk Changeset: 20d39a0e6fdc Author: fparain Date: 2012-02-15 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/20d39a0e6fdc 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean Reviewed-by: acorn, mchung, phh ! make/java/management/mapfile-vers - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/native/sun/management/HotSpotDiagnostic.c - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: 2a3f026b3a29 Author: lana Date: 2012-02-15 15:28 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2a3f026b3a29 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: c68342532e2e Author: lana Date: 2012-02-18 16:11 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c68342532e2e Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: 75247b827d6c Author: lana Date: 2012-02-22 22:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/75247b827d6c Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java From denis.fokin at sun.com Fri Feb 24 01:57:39 2012 From: denis.fokin at sun.com (denis.fokin at sun.com) Date: Fri, 24 Feb 2012 09:57:39 +0000 Subject: hg: jdk8/awt/jdk: 7145980: Dispose method of window.java takes long Message-ID: <20120224095804.7C22B4768B@hg.openjdk.java.net> Changeset: 82e3c4a6bfd8 Author: bagiras Date: 2012-02-24 13:50 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/82e3c4a6bfd8 7145980: Dispose method of window.java takes long Reviewed-by: anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java From anthony.petrov at oracle.com Mon Feb 27 06:30:16 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 27 Feb 2012 18:30:16 +0400 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 Message-ID: <4F4B9378.3050209@oracle.com> Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With that fix the code setting the awt.toolkit and java.awt.graphicsenv system properties has been removed from JNI_OnLoad() of libawt.so. Actually, the test WrappedToolkitTest.sh relies on the ability to override the default toolkit by means of setting the AWT_TOOLKIT environment variable, and because of the removal the test has failed. With the fix for 7147435 I'm restoring the removed parts. In order to not break the fix for 7124511, I'm setting the system properties only if the XToolkit has been requested explicitly. [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ -- best regards, Anthony From artem.ananiev at oracle.com Mon Feb 27 14:01:57 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 27 Feb 2012 14:01:57 -0800 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4B9378.3050209@oracle.com> References: <4F4B9378.3050209@oracle.com> Message-ID: <4F4BFD55.6060606@oracle.com> Hi, Anthony, I have an impression your webrev is prepared against an outdated version of code. For example, the change in java_props_md.c:431 is already in the workspace... Other comments: 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not sun.awt 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set in java_props.c 3. GraphicsEnvironment.java also looks fine. Thanks, Artem On 2/27/2012 6:30 AM, Anthony Petrov wrote: > Hello, > > Please review a fix for > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: > > http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ > > This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With > that fix the code setting the awt.toolkit and java.awt.graphicsenv > system properties has been removed from JNI_OnLoad() of libawt.so. > Actually, the test WrappedToolkitTest.sh relies on the ability to > override the default toolkit by means of setting the AWT_TOOLKIT > environment variable, and because of the removal the test has failed. > > With the fix for 7147435 I'm restoring the removed parts. In order to > not break the fix for 7124511, I'm setting the system properties only if > the XToolkit has been requested explicitly. > > [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ > > -- > best regards, > Anthony From anthony.petrov at oracle.com Tue Feb 28 02:47:02 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 28 Feb 2012 14:47:02 +0400 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4BFD55.6060606@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> Message-ID: <4F4CB0A6.8040309@oracle.com> Hi Artem, I believe you've clicked the wrong link. My webrev at http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ contains changes to the awt_LoadLibrary.c file only. I have provided a link to the webrev for 7124511 as a reference only, and put it in the very end of my message to avoid confusion. Please follow the link in the beginning of the message to review the fix. Thanks. -- best regards, Anthony On 2/28/2012 2:01 AM, Artem Ananiev wrote: > Hi, Anthony, > > I have an impression your webrev is prepared against an outdated version > of code. For example, the change in java_props_md.c:431 is already in > the workspace... > > Other comments: > > 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not sun.awt > > 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set in > java_props.c > > 3. GraphicsEnvironment.java also looks fine. > > Thanks, > > Artem > > On 2/27/2012 6:30 AM, Anthony Petrov wrote: >> Hello, >> >> Please review a fix for >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >> >> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >> >> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With >> that fix the code setting the awt.toolkit and java.awt.graphicsenv >> system properties has been removed from JNI_OnLoad() of libawt.so. >> Actually, the test WrappedToolkitTest.sh relies on the ability to >> override the default toolkit by means of setting the AWT_TOOLKIT >> environment variable, and because of the removal the test has failed. >> >> With the fix for 7147435 I'm restoring the removed parts. In order to >> not break the fix for 7124511, I'm setting the system properties only if >> the XToolkit has been requested explicitly. >> >> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >> >> -- >> best regards, >> Anthony From alexander.zuev at oracle.com Tue Feb 28 04:36:36 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 28 Feb 2012 15:36:36 +0300 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4B9378.3050209@oracle.com> References: <4F4B9378.3050209@oracle.com> Message-ID: <4F4CCA54.4000900@oracle.com> Anthony, fix looks fine to me. With best regards, Alex On 2/27/12 17:30, Anthony Petrov wrote: > Hello, > > Please review a fix for > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: > > http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ > > This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. > With that fix the code setting the awt.toolkit and > java.awt.graphicsenv system properties has been removed from > JNI_OnLoad() of libawt.so. Actually, the test WrappedToolkitTest.sh > relies on the ability to override the default toolkit by means of > setting the AWT_TOOLKIT environment variable, and because of the > removal the test has failed. > > With the fix for 7147435 I'm restoring the removed parts. In order to > not break the fix for 7124511, I'm setting the system properties only > if the XToolkit has been requested explicitly. > > [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ > > -- > best regards, > Anthony From artem.ananiev at oracle.com Tue Feb 28 09:22:15 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 28 Feb 2012 09:22:15 -0800 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4CB0A6.8040309@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> <4F4CB0A6.8040309@oracle.com> Message-ID: <4F4D0D47.8090103@oracle.com> Hi, Anthony, On 2/28/2012 2:47 AM, Anthony Petrov wrote: > Hi Artem, > > I believe you've clicked the wrong link. My webrev at yes, it really sounds like I looked into another webrev... > http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ > > contains changes to the awt_LoadLibrary.c file only. I have provided a > link to the webrev for 7124511 as a reference only, and put it in the > very end of my message to avoid confusion. Please follow the link in the > beginning of the message to review the fix. Thanks. Here are some comments from my side: 1. On X11, we don't have any other toolkits than XToolkit, so I don't see any point in checking the AWT_TOOLKIT var on X11. 2. On Mac, CToolkit is not explicitly set in awt_LoadLibrary.c - I realize it's used by default (inherited from java_props_md.c), but it would be fine to leave a comment in the code. 3. AFAIK, there is no need to check global refs for NULL: DeleteGlobalRef() is ready to handle null refs. Thanks, Artem > -- > best regards, > Anthony > > On 2/28/2012 2:01 AM, Artem Ananiev wrote: >> Hi, Anthony, >> >> I have an impression your webrev is prepared against an outdated >> version of code. For example, the change in java_props_md.c:431 is >> already in the workspace... >> >> Other comments: >> >> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not sun.awt >> >> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set >> in java_props.c >> >> 3. GraphicsEnvironment.java also looks fine. >> >> Thanks, >> >> Artem >> >> On 2/27/2012 6:30 AM, Anthony Petrov wrote: >>> Hello, >>> >>> Please review a fix for >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >>> >>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>> >>> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With >>> that fix the code setting the awt.toolkit and java.awt.graphicsenv >>> system properties has been removed from JNI_OnLoad() of libawt.so. >>> Actually, the test WrappedToolkitTest.sh relies on the ability to >>> override the default toolkit by means of setting the AWT_TOOLKIT >>> environment variable, and because of the removal the test has failed. >>> >>> With the fix for 7147435 I'm restoring the removed parts. In order to >>> not break the fix for 7124511, I'm setting the system properties only if >>> the XToolkit has been requested explicitly. >>> >>> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >>> >>> -- >>> best regards, >>> Anthony From anthony.petrov at oracle.com Tue Feb 28 09:32:23 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 28 Feb 2012 21:32:23 +0400 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4D0D47.8090103@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> <4F4CB0A6.8040309@oracle.com> <4F4D0D47.8090103@oracle.com> Message-ID: <4F4D0FA7.5030807@oracle.com> Hi Artem, Thanks for the review. Please find my comments below. On 2/28/2012 9:22 PM, Artem Ananiev wrote: >> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >> >> contains changes to the awt_LoadLibrary.c file only. I have provided a >> link to the webrev for 7124511 as a reference only, and put it in the >> very end of my message to avoid confusion. Please follow the link in the >> beginning of the message to review the fix. Thanks. > > Here are some comments from my side: > > 1. On X11, we don't have any other toolkits than XToolkit, so I don't > see any point in checking the AWT_TOOLKIT var on X11. A custom toolkit may be specified via the -Dawt.toolkit= argument. The AWT_TOOLKIT env var must override this setting. Therefore, the var must be checked. Please note that the test in question fails on X11 exactly for this reason, it invokes: > AWT_TOOLKIT=XToolkit ${TESTJAVA}/bin/java -Djava.awt.headless=true \ > -Dawt.toolkit=sun.awt.motif.MToolkit \ > TestWrapped sun.awt.X11.XToolkit and expects the AWT_TOOLKIT to have precedence over the -Dawt.toolkit setting. So we must check the environment variable on any *NIX platform. > 2. On Mac, CToolkit is not explicitly set in awt_LoadLibrary.c - I > realize it's used by default (inherited from java_props_md.c), but it > would be fine to leave a comment in the code. The comment at line 112 has been added for exactly this reason. It's already there. > 3. AFAIK, there is no need to check global refs for NULL: > DeleteGlobalRef() is ready to handle null refs. It may be implemented this way. However, its specification [1] doesn't mention that NULL is a valid argument. Therefore, I prefer to check for NULL before calling the function. [1] http://download.java.net/jdk8/docs/technotes/guides/jni/spec/functions.html#DeleteGlobalRef -- best regards, Anthony > > Thanks, > > Artem > >> -- >> best regards, >> Anthony >> >> On 2/28/2012 2:01 AM, Artem Ananiev wrote: >>> Hi, Anthony, >>> >>> I have an impression your webrev is prepared against an outdated >>> version of code. For example, the change in java_props_md.c:431 is >>> already in the workspace... >>> >>> Other comments: >>> >>> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not sun.awt >>> >>> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set >>> in java_props.c >>> >>> 3. GraphicsEnvironment.java also looks fine. >>> >>> Thanks, >>> >>> Artem >>> >>> On 2/27/2012 6:30 AM, Anthony Petrov wrote: >>>> Hello, >>>> >>>> Please review a fix for >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >>>> >>>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>>> >>>> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. >>>> With >>>> that fix the code setting the awt.toolkit and java.awt.graphicsenv >>>> system properties has been removed from JNI_OnLoad() of libawt.so. >>>> Actually, the test WrappedToolkitTest.sh relies on the ability to >>>> override the default toolkit by means of setting the AWT_TOOLKIT >>>> environment variable, and because of the removal the test has failed. >>>> >>>> With the fix for 7147435 I'm restoring the removed parts. In order to >>>> not break the fix for 7124511, I'm setting the system properties >>>> only if >>>> the XToolkit has been requested explicitly. >>>> >>>> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >>>> >>>> -- >>>> best regards, >>>> Anthony From artem.ananiev at oracle.com Tue Feb 28 10:05:50 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 28 Feb 2012 10:05:50 -0800 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4D0FA7.5030807@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> <4F4CB0A6.8040309@oracle.com> <4F4D0D47.8090103@oracle.com> <4F4D0FA7.5030807@oracle.com> Message-ID: <4F4D177E.2040506@oracle.com> On 2/28/2012 9:32 AM, Anthony Petrov wrote: > Hi Artem, > > Thanks for the review. Please find my comments below. > > On 2/28/2012 9:22 PM, Artem Ananiev wrote: >>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>> >>> contains changes to the awt_LoadLibrary.c file only. I have provided a >>> link to the webrev for 7124511 as a reference only, and put it in the >>> very end of my message to avoid confusion. Please follow the link in the >>> beginning of the message to review the fix. Thanks. >> >> Here are some comments from my side: >> >> 1. On X11, we don't have any other toolkits than XToolkit, so I don't >> see any point in checking the AWT_TOOLKIT var on X11. > > A custom toolkit may be specified via the -Dawt.toolkit= argument. The > AWT_TOOLKIT env var must override this setting. Therefore, the var must I don't think so. awt.toolkit is a system property referenced in JavaDoc (see Toolkit#getDefaultToolkit() for details), but AWT_TOOLKIT is just an optional hint. The system property must take a precedence over the env variable. > be checked. Please note that the test in question fails on X11 exactly > for this reason, it invokes: > >> AWT_TOOLKIT=XToolkit ${TESTJAVA}/bin/java -Djava.awt.headless=true \ >> -Dawt.toolkit=sun.awt.motif.MToolkit \ >> TestWrapped sun.awt.X11.XToolkit > > and expects the AWT_TOOLKIT to have precedence over the -Dawt.toolkit > setting. So we must check the environment variable on any *NIX platform. > >> 2. On Mac, CToolkit is not explicitly set in awt_LoadLibrary.c - I >> realize it's used by default (inherited from java_props_md.c), but it >> would be fine to leave a comment in the code. > > The comment at line 112 has been added for exactly this reason. It's > already there. > >> 3. AFAIK, there is no need to check global refs for NULL: >> DeleteGlobalRef() is ready to handle null refs. > > It may be implemented this way. However, its specification [1] doesn't > mention that NULL is a valid argument. Therefore, I prefer to check for > NULL before calling the function. > > [1] > http://download.java.net/jdk8/docs/technotes/guides/jni/spec/functions.html#DeleteGlobalRef OK, let it be so. Thanks, Artem > -- > best regards, > Anthony > >> >> Thanks, >> >> Artem >> >>> -- >>> best regards, >>> Anthony >>> >>> On 2/28/2012 2:01 AM, Artem Ananiev wrote: >>>> Hi, Anthony, >>>> >>>> I have an impression your webrev is prepared against an outdated >>>> version of code. For example, the change in java_props_md.c:431 is >>>> already in the workspace... >>>> >>>> Other comments: >>>> >>>> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not >>>> sun.awt >>>> >>>> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set >>>> in java_props.c >>>> >>>> 3. GraphicsEnvironment.java also looks fine. >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>> On 2/27/2012 6:30 AM, Anthony Petrov wrote: >>>>> Hello, >>>>> >>>>> Please review a fix for >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >>>>> >>>>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>>>> >>>>> >>>>> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. >>>>> With >>>>> that fix the code setting the awt.toolkit and java.awt.graphicsenv >>>>> system properties has been removed from JNI_OnLoad() of libawt.so. >>>>> Actually, the test WrappedToolkitTest.sh relies on the ability to >>>>> override the default toolkit by means of setting the AWT_TOOLKIT >>>>> environment variable, and because of the removal the test has failed. >>>>> >>>>> With the fix for 7147435 I'm restoring the removed parts. In order to >>>>> not break the fix for 7124511, I'm setting the system properties >>>>> only if >>>>> the XToolkit has been requested explicitly. >>>>> >>>>> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony From anthony.petrov at oracle.com Tue Feb 28 10:56:05 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 28 Feb 2012 22:56:05 +0400 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4D177E.2040506@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> <4F4CB0A6.8040309@oracle.com> <4F4D0D47.8090103@oracle.com> <4F4D0FA7.5030807@oracle.com> <4F4D177E.2040506@oracle.com> Message-ID: <4F4D2345.6020603@oracle.com> On 2/28/2012 10:05 PM, Artem Ananiev wrote: >>> 1. On X11, we don't have any other toolkits than XToolkit, so I don't >>> see any point in checking the AWT_TOOLKIT var on X11. >> >> A custom toolkit may be specified via the -Dawt.toolkit= argument. The >> AWT_TOOLKIT env var must override this setting. Therefore, the var must > > I don't think so. awt.toolkit is a system property referenced in JavaDoc > (see Toolkit#getDefaultToolkit() for details), but AWT_TOOLKIT is just > an optional hint. The system property must take a precedence over the > env variable. I agree that the AWT_TOOLKIT isn't documented properly. However, the test has been written some time ago and relied on this behavior. And it worked just fine before merging the Mac Port changes. So technically this is a regression. Yes, we can just drop this behavior, in which case the fix that you're currently reviewing doesn't make sense and should actually change the test by eliminating the command line causing this test to fail. Please clarify if you want this issue to be addressed this way. -- best regards, Anthony > >> be checked. Please note that the test in question fails on X11 exactly >> for this reason, it invokes: >> >>> AWT_TOOLKIT=XToolkit ${TESTJAVA}/bin/java -Djava.awt.headless=true \ >>> -Dawt.toolkit=sun.awt.motif.MToolkit \ >>> TestWrapped sun.awt.X11.XToolkit >> >> and expects the AWT_TOOLKIT to have precedence over the -Dawt.toolkit >> setting. So we must check the environment variable on any *NIX platform. >> >>> 2. On Mac, CToolkit is not explicitly set in awt_LoadLibrary.c - I >>> realize it's used by default (inherited from java_props_md.c), but it >>> would be fine to leave a comment in the code. >> >> The comment at line 112 has been added for exactly this reason. It's >> already there. >> >>> 3. AFAIK, there is no need to check global refs for NULL: >>> DeleteGlobalRef() is ready to handle null refs. >> >> It may be implemented this way. However, its specification [1] doesn't >> mention that NULL is a valid argument. Therefore, I prefer to check for >> NULL before calling the function. >> >> [1] >> http://download.java.net/jdk8/docs/technotes/guides/jni/spec/functions.html#DeleteGlobalRef >> > > OK, let it be so. > > Thanks, > > Artem > >> -- >> best regards, >> Anthony >> >>> >>> Thanks, >>> >>> Artem >>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 2/28/2012 2:01 AM, Artem Ananiev wrote: >>>>> Hi, Anthony, >>>>> >>>>> I have an impression your webrev is prepared against an outdated >>>>> version of code. For example, the change in java_props_md.c:431 is >>>>> already in the workspace... >>>>> >>>>> Other comments: >>>>> >>>>> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not >>>>> sun.awt >>>>> >>>>> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set >>>>> in java_props.c >>>>> >>>>> 3. GraphicsEnvironment.java also looks fine. >>>>> >>>>> Thanks, >>>>> >>>>> Artem >>>>> >>>>> On 2/27/2012 6:30 AM, Anthony Petrov wrote: >>>>>> Hello, >>>>>> >>>>>> Please review a fix for >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >>>>>> >>>>>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>>>>> >>>>>> >>>>>> >>>>>> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. >>>>>> With >>>>>> that fix the code setting the awt.toolkit and java.awt.graphicsenv >>>>>> system properties has been removed from JNI_OnLoad() of libawt.so. >>>>>> Actually, the test WrappedToolkitTest.sh relies on the ability to >>>>>> override the default toolkit by means of setting the AWT_TOOLKIT >>>>>> environment variable, and because of the removal the test has failed. >>>>>> >>>>>> With the fix for 7147435 I'm restoring the removed parts. In order to >>>>>> not break the fix for 7124511, I'm setting the system properties >>>>>> only if >>>>>> the XToolkit has been requested explicitly. >>>>>> >>>>>> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony From artem.ananiev at oracle.com Tue Feb 28 12:16:04 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 28 Feb 2012 12:16:04 -0800 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4D2345.6020603@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> <4F4CB0A6.8040309@oracle.com> <4F4D0D47.8090103@oracle.com> <4F4D0FA7.5030807@oracle.com> <4F4D177E.2040506@oracle.com> <4F4D2345.6020603@oracle.com> Message-ID: <4F4D3604.40504@oracle.com> On 2/28/2012 10:56 AM, Anthony Petrov wrote: > On 2/28/2012 10:05 PM, Artem Ananiev wrote: >>>> 1. On X11, we don't have any other toolkits than XToolkit, so I don't >>>> see any point in checking the AWT_TOOLKIT var on X11. >>> >>> A custom toolkit may be specified via the -Dawt.toolkit= argument. The >>> AWT_TOOLKIT env var must override this setting. Therefore, the var must >> >> I don't think so. awt.toolkit is a system property referenced in >> JavaDoc (see Toolkit#getDefaultToolkit() for details), but AWT_TOOLKIT >> is just an optional hint. The system property must take a precedence >> over the env variable. > > I agree that the AWT_TOOLKIT isn't documented properly. However, the > test has been written some time ago and relied on this behavior. And it > worked just fine before merging the Mac Port changes. So technically > this is a regression. I don't know why the test was written this way even back in 1.6 time frame, when both XToolkit and MToolkit were available. > Yes, we can just drop this behavior, in which case the fix that you're > currently reviewing doesn't make sense and should actually change the > test by eliminating the command line causing this test to fail. The right behavior with -Dawt.toolkit=sun.awt.motif.MToolkit is to throw a ClassNotFoundException exception, because there is not such toolkit in JDK7. However, I'm also fine if you completely remove this scenario from the test. Thanks, Artem > Please clarify if you want this issue to be addressed this way. > > -- > best regards, > Anthony > > >> >>> be checked. Please note that the test in question fails on X11 exactly >>> for this reason, it invokes: >>> >>>> AWT_TOOLKIT=XToolkit ${TESTJAVA}/bin/java -Djava.awt.headless=true \ >>>> -Dawt.toolkit=sun.awt.motif.MToolkit \ >>>> TestWrapped sun.awt.X11.XToolkit >>> >>> and expects the AWT_TOOLKIT to have precedence over the -Dawt.toolkit >>> setting. So we must check the environment variable on any *NIX platform. >>> >>>> 2. On Mac, CToolkit is not explicitly set in awt_LoadLibrary.c - I >>>> realize it's used by default (inherited from java_props_md.c), but it >>>> would be fine to leave a comment in the code. >>> >>> The comment at line 112 has been added for exactly this reason. It's >>> already there. >>> >>>> 3. AFAIK, there is no need to check global refs for NULL: >>>> DeleteGlobalRef() is ready to handle null refs. >>> >>> It may be implemented this way. However, its specification [1] doesn't >>> mention that NULL is a valid argument. Therefore, I prefer to check for >>> NULL before calling the function. >>> >>> [1] >>> http://download.java.net/jdk8/docs/technotes/guides/jni/spec/functions.html#DeleteGlobalRef >>> >> >> OK, let it be so. >> >> Thanks, >> >> Artem >> >>> -- >>> best regards, >>> Anthony >>> >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 2/28/2012 2:01 AM, Artem Ananiev wrote: >>>>>> Hi, Anthony, >>>>>> >>>>>> I have an impression your webrev is prepared against an outdated >>>>>> version of code. For example, the change in java_props_md.c:431 is >>>>>> already in the workspace... >>>>>> >>>>>> Other comments: >>>>>> >>>>>> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not >>>>>> sun.awt >>>>>> >>>>>> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set >>>>>> in java_props.c >>>>>> >>>>>> 3. GraphicsEnvironment.java also looks fine. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Artem >>>>>> >>>>>> On 2/27/2012 6:30 AM, Anthony Petrov wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Please review a fix for >>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. >>>>>>> With >>>>>>> that fix the code setting the awt.toolkit and java.awt.graphicsenv >>>>>>> system properties has been removed from JNI_OnLoad() of libawt.so. >>>>>>> Actually, the test WrappedToolkitTest.sh relies on the ability to >>>>>>> override the default toolkit by means of setting the AWT_TOOLKIT >>>>>>> environment variable, and because of the removal the test has >>>>>>> failed. >>>>>>> >>>>>>> With the fix for 7147435 I'm restoring the removed parts. In >>>>>>> order to >>>>>>> not break the fix for 7124511, I'm setting the system properties >>>>>>> only if >>>>>>> the XToolkit has been requested explicitly. >>>>>>> >>>>>>> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >>>>>>> >>>>>>> -- >>>>>>> best regards, >>>>>>> Anthony From lana.steuck at oracle.com Tue Feb 28 19:32:38 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:32:38 +0000 Subject: hg: jdk8/awt: 4 new changesets Message-ID: <20120229033238.D37C3476FA@hg.openjdk.java.net> Changeset: 97bb465be99d Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/97bb465be99d Added tag jdk8-b27 for changeset 1533dfab9903 ! .hgtags Changeset: 9760a2114f51 Author: asaha Date: 2012-02-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/9760a2114f51 Merge Changeset: d47bf204f34d Author: asaha Date: 2012-02-17 14:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/d47bf204f34d Merge Changeset: 6e2541d60f4e Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/6e2541d60f4e Merge From lana.steuck at oracle.com Tue Feb 28 19:32:47 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:32:47 +0000 Subject: hg: jdk8/awt/jaxws: 5 new changesets Message-ID: <20120229033247.B1320476FB@hg.openjdk.java.net> Changeset: 6a2e8a833460 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/6a2e8a833460 Added tag jdk8-b27 for changeset 38c037af4127 ! .hgtags Changeset: 4289a81ba085 Author: asaha Date: 2012-02-14 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/4289a81ba085 Merge Changeset: 456621c5d797 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/456621c5d797 Merge Changeset: c88e83be4b1a Author: lana Date: 2012-02-23 00:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/c88e83be4b1a Merge Changeset: 88b85470e72c Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/88b85470e72c Merge From lana.steuck at oracle.com Tue Feb 28 19:32:43 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:32:43 +0000 Subject: hg: jdk8/awt/corba: 5 new changesets Message-ID: <20120229033252.E9BD8476FC@hg.openjdk.java.net> Changeset: 7bf4278af030 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/7bf4278af030 Added tag jdk8-b27 for changeset 4fffe75e4edd ! .hgtags Changeset: 66c7161ee588 Author: coffeys Date: 2011-11-17 10:51 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/66c7161ee588 7110704: Issues with some method in corba Reviewed-by: mbankal ! src/share/classes/com/sun/corba/se/impl/dynamicany/DynAnyFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/dynamicany/DynAnyImpl.java ! src/share/classes/com/sun/org/omg/SendingContext/_CodeBaseImplBase.java Changeset: c4afff3939d8 Author: asaha Date: 2012-02-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/c4afff3939d8 Merge Changeset: 695408e22b29 Author: asaha Date: 2012-02-17 14:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/695408e22b29 Merge Changeset: 2082eb35d49a Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/2082eb35d49a Merge From lana.steuck at oracle.com Tue Feb 28 19:32:56 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:32:56 +0000 Subject: hg: jdk8/awt/jaxp: 4 new changesets Message-ID: <20120229033256.AED35476FD@hg.openjdk.java.net> Changeset: 38cc4c09b847 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/38cc4c09b847 Added tag jdk8-b27 for changeset 80c47eb83d24 ! .hgtags Changeset: 6fc515ab48c3 Author: asaha Date: 2012-02-14 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/6fc515ab48c3 Merge Changeset: a8e76ac83b62 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/a8e76ac83b62 Merge Changeset: f3244c1f0486 Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/f3244c1f0486 Merge From lana.steuck at oracle.com Tue Feb 28 19:32:47 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:32:47 +0000 Subject: hg: jdk8/awt/hotspot: Added tag jdk8-b27 for changeset 3b24e7e01d20 Message-ID: <20120229033300.16579476FE@hg.openjdk.java.net> Changeset: 0ed0960af27d Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0ed0960af27d Added tag jdk8-b27 for changeset 3b24e7e01d20 ! .hgtags From lana.steuck at oracle.com Tue Feb 28 19:33:04 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:33:04 +0000 Subject: hg: jdk8/awt/langtools: 5 new changesets Message-ID: <20120229033319.A122C476FF@hg.openjdk.java.net> Changeset: 8503479162bd Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8503479162bd Added tag jdk8-b27 for changeset be456f9c64e8 ! .hgtags Changeset: 3b168225dfc0 Author: asaha Date: 2012-02-14 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/3b168225dfc0 Merge - src/share/classes/com/sun/tools/javac/Launcher.java Changeset: d903497bf389 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d903497bf389 Merge Changeset: a696a8610b2a Author: lana Date: 2012-02-23 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a696a8610b2a Merge Changeset: 5bed623b0c77 Author: lana Date: 2012-02-24 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/5bed623b0c77 Merge From lana.steuck at oracle.com Tue Feb 28 19:33:29 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 03:33:29 +0000 Subject: hg: jdk8/awt/jdk: 29 new changesets Message-ID: <20120229033914.B1D0F47700@hg.openjdk.java.net> Changeset: 7d683ab46571 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7d683ab46571 Added tag jdk8-b27 for changeset c68342532e2e ! .hgtags Changeset: 2152ac3e4575 Author: dl Date: 2011-10-12 16:33 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2152ac3e4575 7082299: AtomicReferenceArray should ensure that array is Object[] Reviewed-by: chegar, dholmes, alanb ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java Changeset: 23c3d1a0e150 Author: amenkov Date: 2011-10-26 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/23c3d1a0e150 7088367: JavaSound security issue (12865443) Reviewed-by: denis ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java + test/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java Changeset: 3ee041967af6 Author: smarks Date: 2011-11-11 15:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ee041967af6 7110700: Enhance exception throwing mechanism in ObjectStreamClass Reviewed-by: dmeetry, hawtin ! src/share/classes/java/io/ObjectStreamClass.java ! test/java/io/Serializable/expectedStackTrace/ExpectedStackTrace.java Changeset: 18335c98ab8b Author: smarks Date: 2011-11-17 15:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/18335c98ab8b 7112267: clean up fix for 7110700 Reviewed-by: dmeetry ! test/java/io/Serializable/expectedStackTrace/ExpectedStackTrace.java Changeset: 4b98d2682c31 Author: okutsu Date: 2011-12-14 11:23 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b98d2682c31 6351654: Problem with java/classes_util_i18n Reviewed-by: hawtin, coffeys ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/awt/AppContext.java + src/share/classes/sun/misc/JavaAWTAccess.java ! src/share/classes/sun/misc/SharedSecrets.java Changeset: 5d7e49a3a2f9 Author: bagiras Date: 2011-12-14 14:43 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5d7e49a3a2f9 7112642: Incorrect checking for graphics rendering object Reviewed-by: art, bae ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/opengl/OGLRenderer.java ! src/share/classes/sun/java2d/pipe/BufferedContext.java ! src/windows/classes/sun/java2d/d3d/D3DRenderer.java ! src/windows/classes/sun/java2d/windows/GDIRenderer.java ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp Changeset: a7cb0afadbee Author: sherman Date: 2011-12-15 14:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a7cb0afadbee 7118283: Better input parameter checking in zip file processing Summary: Fixed off-by-one bug in zip_util.c Reviewed-by: alanb ! src/share/native/java/util/zip/zip_util.c Changeset: d544965b59fe Author: bagiras Date: 2011-12-28 14:26 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d544965b59fe 7121482: some sun/java2d and sun/awt tests failed with InvalidPipeException since 1.7.0_03b02, 6u31b02 Reviewed-by: art, bae ! src/share/classes/sun/java2d/SunGraphics2D.java Changeset: 5e6f3c8646cf Author: xuelei Date: 2012-01-09 20:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5e6f3c8646cf 7123519: problems with certification path Summary: Also including the contribution from Dennis Gu Reviewed-by: mullan, weijun ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java + src/share/classes/sun/security/provider/certpath/UntrustedChecker.java + src/share/classes/sun/security/util/UntrustedCertificates.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! src/share/classes/sun/security/validator/ValidatorException.java + test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java + test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java + test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/ComodoHacker.java Changeset: d9897e95323c Author: chegar Date: 2012-01-18 15:35 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d9897e95323c 7126960: Add property to limit number of request headers to the HTTP Server Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerConfig.java Changeset: 7699f0a9c6d7 Author: asaha Date: 2012-02-20 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7699f0a9c6d7 Merge ! make/java/java/FILES_java.gmk ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/validator/SimpleValidator.java Changeset: f525c1e9e12c Author: lana Date: 2012-02-23 00:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f525c1e9e12c Merge Changeset: 45804d661008 Author: xuelei Date: 2012-02-15 23:45 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/45804d661008 7145837: a little performance improvement on the usage of SecureRandom Reviewed-by: chegar, wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java Changeset: b971b51bec01 Author: sherman Date: 2012-02-16 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b971b51bec01 6708398: Support integer overflow Summary: Added add/sub/multiply/toIntExact methods to j.l.Math and StrictMath classes Reviewed-by: emcmanus Contributed-by: roger.riggs at oracle.com ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java + test/java/lang/Math/ExactArithTests.java + test/java/lang/StrictMath/ExactArithTests.java Changeset: d38fed7d2ea7 Author: sherman Date: 2012-02-16 22:13 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d38fed7d2ea7 4153167: separate between ANSI and OEM code pages on Windows Summary: To use OEM code page for System.out&err when not redirected Reviewed-by: alanb ! src/share/classes/java/lang/System.java ! src/share/native/java/lang/System.c ! src/share/native/java/lang/java_props.h ! src/windows/native/java/lang/java_props_md.c Changeset: 24c298ef20a8 Author: forax Date: 2012-02-19 16:51 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/24c298ef20a8 7146152: File.path should be final Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/io/File.java Changeset: de7f6d5841b6 Author: littlee Date: 2012-02-20 11:24 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/de7f6d5841b6 7146506: (fc) Add EACCES check to the return of fcntl native method Summary: Add EACCES check according to the spec of fcntl Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/FileDispatcherImpl.c Changeset: 7326971f09af Author: alanb Date: 2012-02-20 18:55 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7326971f09af 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Reviewed-by: chegar, coffeys ! src/share/classes/sun/nio/ch/NativeThreadSet.java ! src/windows/classes/sun/nio/ch/NativeThread.java ! src/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/windows/native/sun/nio/ch/SocketDispatcher.c Changeset: 5e56d498e913 Author: alanb Date: 2012-02-20 19:33 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5e56d498e913 7147087: Remove AWT/Swing/client tests from ProblemList Reviewed-by: ohair ! test/Makefile ! test/ProblemList.txt Changeset: 0243e7c0b0fb Author: weijun Date: 2012-02-21 08:51 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0243e7c0b0fb 7144530: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java + test/sun/security/krb5/ktab/FileKeyTab.java Changeset: b739dd7ce59c Author: weijun Date: 2012-02-21 15:11 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b739dd7ce59c 7147336: clarification on warning of keytool -printcrl Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java Changeset: a4e3dde9a8a7 Author: xuelei Date: 2012-02-21 05:44 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4e3dde9a8a7 7147407: remove never used debug code in DnsClient.java Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/dns/DnsClient.java Changeset: 6a5d6b2800f6 Author: lana Date: 2012-02-22 16:52 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6a5d6b2800f6 Merge Changeset: fcdd5a4bae0e Author: lana Date: 2012-02-23 07:54 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fcdd5a4bae0e Merge Changeset: ca2218135bac Author: asaha Date: 2012-02-24 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ca2218135bac 7148758: Resolve merge issue which caused testcase failure Reviewed-by: alanb, chegar ! src/share/classes/sun/net/httpserver/ServerConfig.java Changeset: 39dcb3264fb3 Author: lana Date: 2012-02-24 17:38 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/39dcb3264fb3 Merge Changeset: 1e1d41daaded Author: lana Date: 2012-02-24 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1e1d41daaded Merge Changeset: 52fa1b465a3b Author: lana Date: 2012-02-28 17:52 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/52fa1b465a3b Merge From anthony.petrov at oracle.com Wed Feb 29 02:33:36 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 29 Feb 2012 14:33:36 +0400 Subject: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11 In-Reply-To: <4F4D3604.40504@oracle.com> References: <4F4B9378.3050209@oracle.com> <4F4BFD55.6060606@oracle.com> <4F4CB0A6.8040309@oracle.com> <4F4D0D47.8090103@oracle.com> <4F4D0FA7.5030807@oracle.com> <4F4D177E.2040506@oracle.com> <4F4D2345.6020603@oracle.com> <4F4D3604.40504@oracle.com> Message-ID: <4F4DFF00.4060100@oracle.com> On 2/29/2012 12:16 AM, Artem Ananiev wrote: >>> I don't think so. awt.toolkit is a system property referenced in >>> JavaDoc (see Toolkit#getDefaultToolkit() for details), but AWT_TOOLKIT >>> is just an optional hint. The system property must take a precedence >>> over the env variable. >> >> I agree that the AWT_TOOLKIT isn't documented properly. However, the >> test has been written some time ago and relied on this behavior. And it >> worked just fine before merging the Mac Port changes. So technically >> this is a regression. > > I don't know why the test was written this way even back in 1.6 time > frame, when both XToolkit and MToolkit were available. Well, the test has been written by you. :) >> Yes, we can just drop this behavior, in which case the fix that you're >> currently reviewing doesn't make sense and should actually change the >> test by eliminating the command line causing this test to fail. > > The right behavior with -Dawt.toolkit=sun.awt.motif.MToolkit is to throw > a ClassNotFoundException exception, because there is not such toolkit in > JDK7. However, I'm also fine if you completely remove this scenario from > the test. Fine by me. We'll review a new fix with you. -- best regards, Anthony > > Thanks, > > Artem > >> Please clarify if you want this issue to be addressed this way. >> >> -- >> best regards, >> Anthony >> >> >>> >>>> be checked. Please note that the test in question fails on X11 exactly >>>> for this reason, it invokes: >>>> >>>>> AWT_TOOLKIT=XToolkit ${TESTJAVA}/bin/java -Djava.awt.headless=true \ >>>>> -Dawt.toolkit=sun.awt.motif.MToolkit \ >>>>> TestWrapped sun.awt.X11.XToolkit >>>> >>>> and expects the AWT_TOOLKIT to have precedence over the -Dawt.toolkit >>>> setting. So we must check the environment variable on any *NIX >>>> platform. >>>> >>>>> 2. On Mac, CToolkit is not explicitly set in awt_LoadLibrary.c - I >>>>> realize it's used by default (inherited from java_props_md.c), but it >>>>> would be fine to leave a comment in the code. >>>> >>>> The comment at line 112 has been added for exactly this reason. It's >>>> already there. >>>> >>>>> 3. AFAIK, there is no need to check global refs for NULL: >>>>> DeleteGlobalRef() is ready to handle null refs. >>>> >>>> It may be implemented this way. However, its specification [1] doesn't >>>> mention that NULL is a valid argument. Therefore, I prefer to check for >>>> NULL before calling the function. >>>> >>>> [1] >>>> http://download.java.net/jdk8/docs/technotes/guides/jni/spec/functions.html#DeleteGlobalRef >>>> >>>> >>> >>> OK, let it be so. >>> >>> Thanks, >>> >>> Artem >>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>>> >>>>> Thanks, >>>>> >>>>> Artem >>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 2/28/2012 2:01 AM, Artem Ananiev wrote: >>>>>>> Hi, Anthony, >>>>>>> >>>>>>> I have an impression your webrev is prepared against an outdated >>>>>>> version of code. For example, the change in java_props_md.c:431 is >>>>>>> already in the workspace... >>>>>>> >>>>>>> Other comments: >>>>>>> >>>>>>> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not >>>>>>> sun.awt >>>>>>> >>>>>>> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are >>>>>>> set >>>>>>> in java_props.c >>>>>>> >>>>>>> 3. GraphicsEnvironment.java also looks fine. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Artem >>>>>>> >>>>>>> On 2/27/2012 6:30 AM, Anthony Petrov wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> Please review a fix for >>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. >>>>>>>> With >>>>>>>> that fix the code setting the awt.toolkit and java.awt.graphicsenv >>>>>>>> system properties has been removed from JNI_OnLoad() of libawt.so. >>>>>>>> Actually, the test WrappedToolkitTest.sh relies on the ability to >>>>>>>> override the default toolkit by means of setting the AWT_TOOLKIT >>>>>>>> environment variable, and because of the removal the test has >>>>>>>> failed. >>>>>>>> >>>>>>>> With the fix for 7147435 I'm restoring the removed parts. In >>>>>>>> order to >>>>>>>> not break the fix for 7124511, I'm setting the system properties >>>>>>>> only if >>>>>>>> the XToolkit has been requested explicitly. >>>>>>>> >>>>>>>> [1] http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/ >>>>>>>> >>>>>>>> -- >>>>>>>> best regards, >>>>>>>> Anthony From alexandr.scherbatiy at oracle.com Wed Feb 29 06:48:16 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Wed, 29 Feb 2012 14:48:16 +0000 Subject: hg: jdk8/awt/jdk: 7133573: [macosx] closed/javax/swing/JToolTip/4846413/bug4846413.java fails on MacOS Message-ID: <20120229144839.F0B3C4771B@hg.openjdk.java.net> Changeset: ea888347969d Author: alexsch Date: 2012-02-29 18:47 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea888347969d 7133573: [macosx] closed/javax/swing/JToolTip/4846413/bug4846413.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JToolTip/4846413/bug4846413.java From anthony.petrov at ORACLE.COM Wed Feb 29 06:58:32 2012 From: anthony.petrov at ORACLE.COM (Anthony Petrov) Date: Wed, 29 Feb 2012 18:58:32 +0400 Subject: [7u4] Review request for 7145818: [macosx] dialogs not showing when JFrame is in full screen mode Message-ID: <4F4E3D18.3010109@oracle.com> Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7145818 at: http://cr.openjdk.java.net/~anthony/x-21-popupInFullscreen-7145818.0/ Thanks Mike for the suggestion to use the [NSWindow toggleFullScreen] API. I've tested the fix on both 10.7 and 10.6.8, and it works consistently on both systems. Although the new API is claimed to be supported starting with 10.7 only, it works fine on my 10.6.8 box as well (but prints out a warning about sending an unrecognized selector to an AWTWindow instance.) I've also verified that the native resize events contain correct window size, so I removed the machinery that sent synthetic events in the full screen mode. -- best regards, Anthony