<AWT Dev> [8] Review request for 7170657: [macosx] There seems to be no keyboard/mouse action to select non-contiguous items in List

Pavel Porvatov pavel.porvatov at oracle.com
Thu Jul 12 09:26:19 PDT 2012


Hi Sergey,

The fix looks good. Could you please remove unnecessary code from the 
test like:

1. @run main/othervm bug7170657
2. The "FAILED" field: you can throw exception from the "fail" method
3. What is the reason to use final here: "public final class"?

Regards, Pavel
> Hi Everyone,
> Please review the fix.
> Bug in SwingUtilities.convertMouseEvent().This method does not convert 
> extended state of the event.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170657
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/7170657/webrev.00
>




More information about the awt-dev mailing list