<AWT Dev> [8] Review request for 7170657: [macosx] There seems to be no keyboard/mouse action to select non-contiguous items in List

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Jul 12 09:52:13 PDT 2012

Hi, Pavel.
Thanks for review. See comments inline
12.07.2012 20:26, Pavel Porvatov wrote:
> Hi Sergey,
> The fix looks good. Could you please remove unnecessary code from the 
> test like:
> 1. @run main/othervm bug7170657
> 2. The "FAILED" field: you can throw exception from the "fail" method
In this case we skip part of the test. Useful for debug.
> 3. What is the reason to use final here: "public final class"?
I do not think that someone will want to be inherited from it. I just 
make all classes final by default.

New version of the fix:
> Regards, Pavel
>> Hi Everyone,
>> Please review the fix.
>> Bug in SwingUtilities.convertMouseEvent().This method does not 
>> convert extended state of the event.
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170657
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7170657/webrev.00

Best regards, Sergey.

More information about the awt-dev mailing list