<AWT Dev> [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

Kelly Ohair kelly.ohair at oracle.com
Tue May 1 15:19:04 PDT 2012


Do you still need this integrated?
I can integrate the exact same changset to awt, 2d,  and build forests if you want.


Sent from my iPhone

On Apr 26, 2012, at 0:35, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:

> On 2012-04-26 03:06, Jim Graham wrote:
>> Can we remove these "empty JNI" classes from a list of "javah" classes somewhere so that we don't waste time generating the empty JNI headers?
> Good idea -- that's exactly what is being done in the new build system (the build-infra project)! :-)
> We added a new option to javac, which generates JNI headers automatically, if they are needed -- basically, if the class contains native methods *). So header generation is made always when needed and only when needed, quickly and as  a part of normal compilation.
> Since these classes didn't have any native methods, the header files were not generated, and the compile of the native code failed since the #include pointed to non-exisiting files.
> *) Actually, sometimes classes with constants but without native methods are needed. In this case, the new annotation @GenerateNativeHeader is needed.
> /Magnus

More information about the awt-dev mailing list