<AWT Dev> [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth

Denis S. Fokin denis.fokin at oracle.com
Wed Oct 24 03:40:41 PDT 2012

Looks fine.

Thank you,
On Oct 23, 2012, at 6:51 PM, Sergey Bylokhov wrote:

> cc Scott. As plugin may be affected.
> 23.10.2012 15:41, Sergey Bylokhov wrote:
>> Hi Everyone,
>> Please review the fix.
>> This is an attempt to make our resizing better. I try to eliminate all unnecessary repaint actions.
>> 1 "Layer backed view" was changed to "Layer hosting view" - unnecessary call from drawRect() was eliminated. Now we post Paint event in the resize callback when necessary.
>> 2 CALayer options were changed, so now it don't force setNeedsDisplay.
>> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate unnecessary call to drawInCGLContext() when our 2d texture is not ready.
>> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used)
>> After the fix we call Layer.setNeedsDisplay only in the Java2D Queue Flusher threads. It means that we have no possibility to accelerate resizing even more from awt side.
>> I'll make addition research of this question in the following CR.
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/7198229/webrev.00
> -- 
> Best regards, Sergey.

More information about the awt-dev mailing list