<AWT Dev>  [PATCH] Review request for 8001633: Wrong alt processing during switching between windows.
mikhail.cherkasov at oracle.com
Mon Oct 29 06:11:59 PDT 2012
SwingUtilities.getWindowAncestor returns null if passed argument is instance
of Window, so "originalSource == winAncestorthis" check is to handle
I will replace this method with SunToolkit.getContainingWindow,
it returns passed argument, if it's windows instance. So there will be
only one check:
SunToolkit.getContainingWindow(originalSource ) == winAncestor.
On 10/29/2012 4:12 PM, Leonid Romanov wrote:
> I don't understand lines 147-148 in WindowsRootPaneUI.java. Could you
> explain please why two checks are needed (originalSource ==
> winAncestor and SwingUtilities.getWindowAncestor(originalSource) ==
> *From:*awt-dev-bounces at openjdk.java.net
> [mailto:awt-dev-bounces at openjdk.java.net] *On Behalf Of *Mikhail Cherkasov
> *Sent:* Monday, October 29, 2012 4:12 PM
> *To:* awt-dev at openjdk.java.net
> *Subject:* Re: <AWT Dev>  [PATCH] Review request for 8001633: Wrong
> alt processing during switching between windows.
> Sorry, I sent wrong link for webrev, please use this one:
> On 10/29/2012 2:23 PM, Mikhail Cherkasov wrote:
> Hi all,
> Could you please review a fix for 8001633
> Wrong alt processing during switching between windows.
> To prevent wrong focus traversing to menu was added additional
> check to AltProcessor.
> It checks that original source of 'alt' event belongs to
> or its component.
> Patch is attached.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev