<AWT Dev> [8] Review request for 8022997: [macosx] Remaining duplicated key events

Anthony Petrov anthony.petrov at oracle.com
Wed Aug 14 09:50:38 PDT 2013

The fix looks good to me.

best regards,

On 08/14/2013 08:44 PM, Leonid Romanov wrote:
> Hello,
> Please review a one line fix for 8022997: [macosx] Remaining duplicated key events. NsCharToJavaChar() we call at CMenuItem.m:92 translates NSCarriageReturnCharacter (which is the key code generated by OS X when user presses "enter" key) into NSNewlineCharacter. So, in order to filter out the duplicate event at line 101, menuKey has to be NSNewlineCharacter as well. This is what the fix does.
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8022997 (might not be available yet)
> webrev: http://cr.openjdk.java.net/~leonidr/8022997/webrev.00/
> Thanks,
> Leonid.

More information about the awt-dev mailing list