<AWT Dev> [8] Review Request for [macosx] Add javadoc to the handleWindowFocusEvent in CEmbeddedFrame

[Anton V. Tarasov]

Ok, Petr, I got the point (after offline discussion). The method is called when the toplevel browser 
window gets activation, not the plugin window. I'm fine now with the comments.

Thanks,
Anton.

On 27.06.2013 13:30, Petr Pchelko wrote:
>> What happens when no EF had focus before?
> Look like nothing is happening and that looks correct: if we have a text field and an applet inside the browser and the focus is in the text field,
> deactivating/activating the browser window should not trigger focus event in the applet, we should only update the java state parentWindowActive.
> When applet gets a native focus in the browser java focus events will be triggered by the call to handleFocusEvent.
>
> With best regards. Petr.
>
> On Jun 27, 2013, at 1:21 PM, Anton V. Tarasov wrote:
>
>> On 27.06.2013 13:18, Petr Pchelko wrote:
>>> Hello, Anton.
>>>
>>> After discussion with Sergey we propose the new version of the comment:
>>> http://cr.openjdk.java.net/~pchelko/8019237/webrev.01/
>>>
>>>> Actually, the statement "and had focus before the deactivation" is not necessary. In case the EF hadn't been focused before, the 3rd event will come to the default focusable component in the frame, according to the FocusTraversalPolicy.
>>> If you look on the implementation, the method triggers focus events only if the CEmbeddedFrame had focus (not in the mean that the CEmbeddedFrame was the focused component, but that the focus was in some component in this CEmbeddedFrame)
>>> This is done because we could have multiple EmbeddedFrames in a single browser window, and the method is called for all of them.
>> What happens when no EF had focus before?
>>
>> Thanks,
>> Anton.
>>
>>> With best regards. Petr.
>>>
>>> On Jun 27, 2013, at 1:03 PM, Anton V. Tarasov wrote:
>>>
>>>> Hi Petr,
>>>>
>>>> Actually, the statement "and had focus before the deactivation" is not necessary. In case the EF hadn't been focused before, the 3rd event will come to the default focusable component in the frame, according to the FocusTraversalPolicy.
>>>>
>>>> Thanks,
>>>> Anton.
>>>>
>>>> On 27.06.2013 12:35, Petr Pchelko wrote:
>>>>> Hello, AWT Team
>>>>>
>>>>> This is a request to review the docs-only fix for the following issue:
>>>>> http://bugs.sun.com/view_bug.do?bug_id=8019236
>>>>> The webrev is available here:
>>>>> http://cr.openjdk.java.net/~pchelko/8019237/webrev/
>>>>>
>>>>> The issue is just created so it might not show up yet. This is a JDK part of the fix for following issue:
>>>>> http://bugs.sun.com/view_bug.do?bug_id=8013948
>>>>>
>>>>> I am adding a comment to discourage deployment developers from using requestFocus() together with handleWindowActivation(). No code changes are involved.
>>>>>
>>>>> With best regards. Petr.
>>>>>