<AWT Dev> [8] Review Request: 8027913 drop target notifications are sent out of order during DnD

[Anthony Petrov]

The fix looks good to me as well.

--
best regards,
Anthony

On 11/18/2013 05:57 PM, Sergey Bylokhov wrote:
> After executing of the test from the fix on different platforms I found
> other problems in dnd.
>   - On windows the nested event loop sometimes is not stopped if the
> window was disposed before than dnd events was dispatched.
>   - On linux mouse_exit event is not fired, but everything is ok for
> mouse_enter.
>   - On osx there is a problem with lwawt heavyweight components.
> This is not a regressions, I'll file separate CR for them to jdk9.
>
> On 11/18/13 12:02 PM, Artem Ananiev wrote:
>> Hi, Sergey,
>>
>> the fix looks fine in general. I would just propose an alternative
>> naming: instead of "mouseDTEnterExit" use "dropTargetEnterExit".
>>
>> Thanks,
>>
>> Artem
>>
>> On 11/14/2013 7:31 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for jdk 8.
>>> The problem was in the missing notification about exit drop target
>>> event. This happens because usual mouse events and SDT events use the
>>> same fields to track current  / previous component.
>>> In the fix these fields were split.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8027913
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8027913/webrev.00
>>>
>
>