<AWT Dev> [8] Review request for JDK-8022185 - JDK8 Fix Raw and unchecked warnings in classes belonging to java.awt.datatransfer

[srikalyan chandrashekar]

Thanks Artem, i have done the fixes, you can find the updated webrev at
the same location
<https://github.com/srikalyc/JDKfixes/blob/master/java.awt.datatransfer.raw_unchecked_webrevwebrev.zip>.

---
Thanks
kalyan

On 10/9/2013 3:12 AM, Artem Ananiev wrote:
>
> I put the updated webrev here:
>
> http://cr.openjdk.java.net/~art/srikalyc/8022185.01/
>
> A few comments:
>
> 1. DataFlavor.java: some of the lines got too long after the fix.
> Please, reformat or add import statements.
>
> 2. DataFlavor.java: there are some redundant class casts left, e.g. at
> line #334.
>
> 3. MimeTypeParameterList.java: after the fix, some of the class casts
> are redundant, e.g. (String)enum_.nextElement() or
> (String)parameters.get(key)
>
> Thanks,
>
> Artem
>
> On 9/26/2013 11:47 PM, srikalyan chandrashekar wrote:
>> Thanks Petr, I just made the fix and the webrev has been updated, please
>> re download to see the changes.
>>
>> ---
>> Thanks
>> kalyan
>>
>> On 9/26/2013 12:36 PM, Petr Pchelko wrote:
>>> Hello, Srikalyan.
>>>
>>> The SystemFlavorMap class was recently fixed by the following
>>> changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7cad8ef127a9
>>> There was a severe bug which was fixed, and by the way the generics
>>> were added.
>>>
>>> So could you please remove your changes to this class from the webrev?
>>>
>>> With best regards. Petr.
>>>
>>> On Sep 26, 2013, at 11:23 PM, srikalyan chandrashekar
>>> <srikalyan.chandrashekar at oracle.com> wrote:
>>>
>>>> Hi folks , a gentle reminder for review.
>>>>
>>>> ---
>>>> Thanks
>>>> kalyan
>>>>
>>>> On 9/16/2013 2:53 PM, srikalyan chandrashekar wrote:
>>>>> Hi team ,  could someone review the fix
>>>>>     Bug      : https://jbs.oracle.com/bugs/browse/JDK-8022185
>>>>>     Webrev :
>>>>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.datatransfer.raw_unchecked_webrevwebrev.zip
>>>>>
>>>>>
>>>>>     Fix       :  raw and unchecked type warnings fix for
>>>>> java.awt.datatransfer classes
>>>>>
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20131009/001b699b/attachment-0001.html