<AWT Dev> [9] Request for review: 8019990: IM candidate window appears on the South-East corner of the display.

[Sergey Bylokhov]

Hi, Andrew.
The fix looks good.

On 4/2/14 2:45 PM, Andrew Brygin wrote:
> Hello,
>
>  could you please review  a fix for 8019990?
>
>  bug: https://bugs.openjdk.java.net/browse/JDK-8019990
>  webrev: http://cr.openjdk.java.net/~bae/8019990/9/webrev.00/
>
>  The problem was triggered by the fix for 7024749, which moved
>  IME messages handling from awt_Component to awt_Frame. Due
>  to this change, the WM_IME_SETCONTEXT never reaches the applet's
>  component, and candidate window position is never adjusted.
>
>  Suggested fix reverts a part of the fix for 7024749: messages
>  WM_IME_SETCONTEXT and WM_IME_NOTIFY are handled in
>  awt_Component again.
>
>  To prevent the crash described in 7024749, I suggest to check
>  whether the proxy is enabled before routing messages to it
>  (see awt_Component.cpp, line 4090).
>
>  I have verified that the suggested change does not trigger any
>  automatic regression test related to IM.
>
>  Unfortunately, there is no new regression test related to the candidate
>  window position because this problem can be reproduced in a browser,
>  but does not appear in applet-based regression tests.
>
>  Please take a look.
>
> Thanks,
> Andrew
>
>
>


-- 
Best regards, Sergey.