<AWT Dev> [9] Review Request for 8041592: [TEST_BUG] Move 42 AWT hw/lw mixing tests to jdk

Yuri Nesterenko yuri.nesterenko at oracle.com
Tue Apr 29 11:26:53 UTC 2014


Thank you Sergey!

Unfortunately I have already pushed the patch.
I'll fix these oversights as a part of the next batch
or as a separate bugfix.

-yan

On 04/29/2014 03:14 PM, Sergey Bylokhov wrote:
> Hi, Yuri.
> I think the patch quite big, so it is expected that it was not reviewed
> in 3 days.
> A few comments:
>   - System.exit(1) is used in the tests and should be replaced by exception.
>   - in some places empty "catch" block is used
>   - JSplitPaneOverlapping.java LOONG line can be splitted.
>   - in some place like JSplitPaneOverlapping.java we call to fail() and
> after call mouseRelease. This methods can be flipped
>   - MixingFrameResizing.java skip osx. I think the test can override
> paint method for tested component and fill the whole component area with
> some solid color, instead of testing via setBackground().
>   - Looks like Util.java is the same file as
> jdk/test/java/awt/regtesthelpers/Util.java
>
> On 4/29/14 12:42 PM, Yuri Nesterenko wrote:
>> Could anyone please look at this, too: we need 2 reviewers to go on.
>> And thank you Anthony!
>>
>> -yan
>>
>> On 04/25/2014 03:57 PM, Anthony Petrov wrote:
>>> Hi Yuri,
>>>
>>> Great to see more tests covering the HW/LW Mixing functionality coming
>>> in! I briefly skimmed through the patch, and it looks good to me.
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 4/24/2014 1:26 PM, Yuri Nesterenko wrote:
>>>> Hi,
>>>>
>>>> please review this change for
>>>> https://bugs.openjdk.java.net/browse/JDK-8041592
>>>>
>>>> Webrev is in:
>>>> http://cr.openjdk.java.net/~yan/8041592/webrev.00/
>>>>
>>>> Thanks,
>>>> -yan
>>>>
>>>> Here's an excerpt from the bug Description:
>>>> ________________________________________
>>>>
>>>> There are 42 automatic functional tests verifying various aspects of
>>>> HW/LW mixing in AWT. We will move them to a separate directory
>>>> test/java/awt/Mixing/AWT_Mixing/.
>>>>
>>>> Note that:
>>>> (1) we decided to make only small changes to the tests as it is just
>>>> some 5% of our task at hand;
>>>> (2) tests are written in someway different styles;
>>>> (3) most of them extend some basic class (included in the
>>>> same directory);
>>>> (4) they use an utility class (included) someway duplicating new
>>>> functionality of ExtendedRobot. However we left this part intact to
>>>> avoid unnecessary refactoring;
>>>> (5) the tests seems stable enough. They were run on 3 platforms
>>>> continuously many times together demonstrating exactly the same output.
>>>> (6) Of the 42 in total, 3 fail on OS X (2 of them also on Linux and
>>>> Windows) because of the open product bugs.
>>>>
>>
>
>
> --
> Best regards, Sergey.
>



More information about the awt-dev mailing list