<AWT Dev> [9] Review request for 8053657: [TEST_BUG] move some 5 tests related to undecorated Frame/JFrame to JDK

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Aug 12 13:32:59 UTC 2014


Hi, Yuri.
It is unclear why you move creation of the JFrame from the EDT in 
UndecoratedInitiallyIconified. It should be moved back.
On 06.08.2014 17:09, Yuri Nesterenko wrote:
> Oh! You are right, thank you.
> Second version is
>
> http://cr.openjdk.java.net/~yan/8053657/webrev.01/
>
> -yan
>
> On 08/06/2014 04:48 PM, Sergey Bylokhov wrote:
>> Hi, Yuri.
>> In some of these tests focusGained variable is not used or its
>> validation is missed. In UndecoratedInitiallyIconified you can simplify
>> the code and uses a throws in main instead of try/catch.
>>
>> On 05.08.2014 12:41, Yuri Nesterenko wrote:
>>> A friendly reminder!
>>>
>>> Thanks,
>>> -yan
>>>
>>> On 07/30/2014 10:54 AM, Yuri Nesterenko wrote:
>>>> Hi team,
>>>>
>>>> please review yet another test update in jdk9:
>>>>
>>>> http://cr.openjdk.java.net/~yan/8053657/webrev.00
>>>>
>>>> ( https://bugs.openjdk.java.net/browse/JDK-8053657 )
>>>>
>>>> These are 5 tests made out of some 8 old functional ones
>>>> dealing with undecorated Frames (and JFrames).
>>>>
>>>> NB: piggybacking here a removal of
>>>> java/awt/Mixing/AWT_Mixing/Util.java.
>>>> It was approved long ago but I forgot to delete it in
>>>> time.
>>>>
>>>> Tests proven on 4 platforms in continuous runs.
>>>>
>>>> Thanks,
>>>> -yan
>>>
>>
>>
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list