<AWT Dev> [9] Review request for 8051359 JPopupMenu creation in headless mode with JDK9b23 causes NPE

Petr Pchelko petr.pchelko at oracle.com
Mon Jul 21 10:01:50 UTC 2014


Hello, Alexander.

Isn't it better to use a different approach and just remove the headless check in targetToAppContext method?
I think this check is incorrect, because it's perfectly valid to have multiple AppContexts in headless mode.

With best regards. Petr

On 21 июля 2014 г., at 13:33, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:

> 
> Hello,
> 
> Could you review the fix:
>  bug: https://bugs.openjdk.java.net/browse/JDK-8051359
>  webrev: http://cr.openjdk.java.net/~alexsch/8051359/webrev.00
> 
>  The fix avoids NPE throwing in headless mode.
> 
>  There are already regression tests that covers the issue in jdk/test/javax/swing/Headless folder.
> 
> 
> Thanks,
> Alexandr.
> 



More information about the awt-dev mailing list