<AWT Dev> [9] Review Request: 6521783 Unnecessary final modifier for a method in a final class

[Petr Pchelko]

>> What do you think about filing new CRs for private final methods and static final methods?
> Actually I have nothing against private/static final methods. Some times I used them
private final is useless because you can’t override it anyway. It’s arguable as we can possibly
change the method to protected and forget to add final, but static methods cannot be overridden 
at all, so final in this case is completely useless and it only annoys as IDEA highlights these issues.

With best regards. Petr.


> On Jul 21, 2014, at 7:12 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> On 7/21/14 6:53 PM, Petr Pchelko wrote:
>> Hello, Sergey.
>> 
>> The fix looks good.
>> 
>> What do you think about filing new CRs for private final methods and static final methods?
> Actually I have nothing against private/static final methods. Some times I used them
>> 
>> With best regards. Petr.
>> 
>>> On Jul 21, 2014, at 5:35 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>>> 
>>> Hello.
>>> Please review a small fix of warnings from another one tool:
>>> I fix all related issues in the client code.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6521783
>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/6521783/webrev.00
>>> 
>>> -- 
>>> Best regards, Sergey.
>>> 
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140721/7888b147/attachment.html>