<AWT Dev> [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

Alan Bateman Alan.Bateman at oracle.com
Wed Jul 23 13:27:33 UTC 2014


On 23/07/2014 09:25, Petr Pchelko wrote:
> Hello, Alan.
>
> Thank you for the review.
> I've updated the fix according to your comments. The new version is here:
> http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.02/ 
> <http://cr.openjdk.java.net/%7Epchelko/9/8037485/webrev.02/>
>
> Only the DataFlavorUtil file is updated. DesktopService now uses a 
> lazy holder, the doc is fixed, the getFlavorTable method is fixed.
> All the rest is the same as in the previous version.
I'm skimmed over the updated webrev, it mostly looks good except for 
getFlavorMap where it doesn't set map, I assume you meant to do this:

if (map == null)
     flavorMap = map = supplier.get();

-Alan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140723/1b191e1e/attachment.html>


More information about the awt-dev mailing list