<AWT Dev> [9] Review Request: 8044516 [macosx] ScreenPopupFactory uses native method that could be avoided

[Sergey Bylokhov]

On 6/2/14 5:13 PM, Sergey Bylokhov wrote:
> On 6/2/14 5:03 PM, Petr Pchelko wrote:
>> Hello, Sergey.
>>
>>> Should we use getPopup() name, since it should be simple accessor?
>> I thought about it. The HEAVYWEIGHT_POPUP constant is 
>> package-private, so if we use
>> simple getPopup we would need a second method 
>> "getHeavyweightPopupType". So I was
>> not quite sure which is better - use 2 methods or merge them in a 
>> single one. I can change
>> it if you think 2 methods would be better.
> Then why do not call PopupFactory.getHeavyWeightPopup() directly?
Look like getPopup() covers headless situation as well. Then the fix 
looks good.
Thanks.
>>
>> With best regards. Petr.
>>
>> On 02 июня 2014 г., at 16:54, Sergey Bylokhov 
>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>
>>> Hi, Petr.
>>> Should we use getPopup() name, since it should be simple accessor?
>>>
>>> On 6/2/14 4:50 PM, Petr Pchelko wrote:
>>>> Hello, AWT Team.
>>>>
>>>> Please review a simple cleanup fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8044516
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~pchelko/9/8044516/webrev/
>>>>
>>>> No need to go through native to call a method. Accessor pattern works
>>>> fine here, so we can avoid loading a native library.
>>>>
>>>> Thank you.
>>>> With best regards. Petr.
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>
>
> -- 
> Best regards, Sergey.


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140602/778a9707/attachment.html>