<AWT Dev> [9] Review Request for 8044429: move awt automated tests for AWT_Modality to OpenJDK repository

Petr Pchelko petr.pchelko at oracle.com
Wed Jun 18 13:57:44 UTC 2014


Hello, Alexander.

In ExcludeDialogTest and ExcludeFrameTest you are emulating key type manually while ExtendedRobot can do that.
Same in TestWindow, TestFrame and TestDialog : 206 - You are manually emulating the click while ExtendedRobot provides this feature.
typeTab method duplicates functionality in ExtendedRobot.

With best regards. Petr.

On 18 июня 2014 г., at 16:35, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:

> Hello,
> 
> Could you please review the webrev:
> http://cr.openjdk.java.net/~avstepan/8044429/
> 
> This is the 1st portion of functional AWT modality tests prepared for migration to OpenJDK repository in accordance with
> https://bugs.openjdk.java.net/browse/JDK-8044429
> 
> Some helper classes were moved too.
> 
> The tests were checked on Ubuntu 14.04, Solaris 11, and Windows 7.
> 
> At the moment the tests are failing on Mac OS X due to
> https://bugs.openjdk.java.net/browse/JDK-7125054
> https://bugs.openjdk.java.net/browse/JDK-8047179
> 
> Thanks,
> Alexander



More information about the awt-dev mailing list