<AWT Dev> [9] Review Request: JDK-7112454 Fix for TEST_BUG: java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html failed

Petr Pchelko petr.pchelko at oracle.com
Mon Jun 23 12:39:39 UTC 2014


Hello, Andrei.

HTML file still lacks copyright header.

With best regards. Petr.

On 23 июня 2014 г., at 15:22, andrei.eremeev <andrei.eremeev at oracle.com> wrote:

> Fixed Petr's remarks.
> 
> The fix:
> http://cr.openjdk.java.net/~yan/7112454/webrev.diff.04/
> 
> Test moved to open:
> http://cr.openjdk.java.net/~yan/7112454/webrev.04/
> 
> Andrei
> 
> On 01/21/2014 04:41 PM, Petr Pchelko wrote:
>> Hello, Andrei.
>> 
>> Please update the copyright header, it should say 2014. And the header is missing in an html file.
>> 
>> As you’ve added Util you could replace the dragMouse method with Util.drag and remove the method.
>> 
>> With best regards. Petr.
>> 
>> 21 янв. 2014 г., в 4:14 после полудня, andrei.eremeev <andrei.eremeev at oracle.com> написал(а):
>> 
>>> Hi, AWT team.
>>> 
>>> Please review the fix for the issue:
>>> https://bugs.openjdk.java.net/browse/JDK-7112454
>>> 
>>> The fix is available at:
>>> http://cr.openjdk.java.net/~yan/7112454/webrev.diff.03/
>>> 
>>> Test moved to open:
>>> http://cr.openjdk.java.net/~yan/7112454/webrev.03/
> 



More information about the awt-dev mailing list