<AWT Dev> [9] Review request for 8014755: [TEST_BUG] frames didn't closed after execution some awt/dnd/ tests

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu May 15 15:57:40 UTC 2014


Hi, Oleg.
Thanks. The fix looks good.

On 14.05.2014 18:20, Oleg Pekhovskiy wrote:
> Hi Sergey,
>
> thanks you for comments!
>
> Please review the second version of fix here:
> http://cr.openjdk.java.net/~bagiras/9/8014755.2/
>
> I've added re-throwing for catch blocks and commented System.exit() 
> calls that are used only for child VMs.
>
> Thanks,
> Oleg
>
> On 13.05.2014 14:55, Sergey Bylokhov wrote:
>> Hi. Oleg.
>> A few notes.
>>   - Some tests contains empty/non-rethrow catch blocks. I guess we
>> should rethrow an exception and the test should fail in this case.
>>   - Some tests use System.exit() which should be replaced by the 
>> exception.
>>
>> On 5/9/14 7:32 PM, Oleg Pekhovskiy wrote:
>>> Hi all,
>>>
>>> please review the fix
>>> http://cr.openjdk.java.net/~bagiras/9/8014755.1/
>>> for
>>> https://bugs.openjdk.java.net/browse/JDK-8014755
>>>
>>> These tests were moved from the closed workspace.
>>>
>>> The main idea of fix is to force termination of child JVM if it's not
>>> exited automatically after the test sequence.
>>>
>>> Tests accuracy was improved to cover all error cases.
>>>
>>> destroyProcess() method was added to
>>> test.java.awt.regtesthelpers.process.ProcessCommunicator
>>> for termination of child JVM when needed.
>>>
>>> Thanks,
>>> Oleg
>>>
>>
>>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list