<AWT Dev> Boolean valueOf instead of new Boolean
Otávio Gonçalves de Santana
otaviojava at java.net
Thu May 29 01:47:28 UTC 2014
On Tue, May 27, 2014 at 3:02 PM, roger riggs <roger.riggs at oracle.com> wrote:
> Hi Otávio,
>
> I can sponsor these two (Boolean and single char strings) for you.
>
> Because they cross over different repositories and require different
> reviews
> it would be more convenient to process each of them in two batches (client
> vs core)
>
> Please can you break out the 'client' changes into a separate webrev?
> The client packages are: (java and javax...)
> java2d, awt, swing, font, print, beans, media, imageio, applet, sound
> and accessibility.
>
> The client webrevs should be posted to awt-dev and the other two to
> core-libs, net-dev and servicability-dev.
>
> Thanks, Roger
>
>
>
> On 5/27/2014 1:16 PM, Otávio Gonçalves de Santana wrote:
>
>> Can anyone help me as sponsor?
>> On May 25, 2014 2:08 AM, "Otávio Gonçalves de Santana" <
>> otaviojava at java.net>
>> wrote:
>>
>>
>>
>
--
Atenciosamente.
Otávio Gonçalves de Santana
blog: http://otaviosantana.blogspot.com.br/
twitter: http://twitter.com/otaviojava
site: http://www.otaviojava.com.br
(11) 98255-3513
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140528/19303f4c/attachment-0001.html>
-------------- next part --------------
diff -r 28d1de89ff27 src/share/classes/java/net/Socket.java
--- a/src/share/classes/java/net/Socket.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/java/net/Socket.java Sat May 24 10:55:43 2014 -0300
@@ -1017,7 +1017,7 @@
if (isClosed())
throw new SocketException("Socket is closed");
if (!on) {
- getImpl().setOption(SocketOptions.SO_LINGER, new Boolean(on));
+ getImpl().setOption(SocketOptions.SO_LINGER, on);
} else {
if (linger < 0) {
throw new IllegalArgumentException("invalid value for SO_LINGER");
-------------- next part --------------
diff -r e323c74edabd src/share/classes/javax/swing/JEditorPane.java
--- a/src/share/classes/javax/swing/JEditorPane.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/swing/JEditorPane.java Tue May 27 21:48:15 2014 -0300
@@ -964,7 +964,7 @@
// The type could have optional info is part of it,
// for example some charset info. We need to strip that
// of and save it.
- int parm = type.indexOf(";");
+ int parm = type.indexOf(';');
if (parm > -1) {
// Save the paramList.
String paramList = type.substring(parm);
diff -r e323c74edabd src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java
--- a/src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java Tue May 27 21:48:15 2014 -0300
@@ -653,7 +653,7 @@
// strip off the prefix, if there is one.
String fullKey = key.toString();
- String partialKey = fullKey.substring(fullKey.indexOf(".") + 1);
+ String partialKey = fullKey.substring(fullKey.indexOf('.') + 1);
Object obj = null;
int xstate = getExtendedState(ctx, v);
-------------- next part --------------
diff -r e323c74edabd src/share/classes/javax/security/auth/PrivateCredentialPermission.java
--- a/src/share/classes/javax/security/auth/PrivateCredentialPermission.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/security/auth/PrivateCredentialPermission.java Tue May 27 21:48:15 2014 -0300
@@ -495,7 +495,7 @@
// perform new initialization from the permission name
- if (getName().indexOf(" ") == -1 && getName().indexOf("\"") == -1) {
+ if (getName().indexOf('') == -1 && getName().indexOf('\"') == -1) {
// name only has a credential class specified
credentialClass = getName();
diff -r e323c74edabd src/share/classes/javax/security/sasl/Sasl.java
--- a/src/share/classes/javax/security/sasl/Sasl.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/security/sasl/Sasl.java Tue May 27 21:48:15 2014 -0300
@@ -600,7 +600,7 @@
// implementation of an algorithm. We are only interested
// in entries which lead to the implementation
// classes.
- if (currentKey.indexOf(" ") < 0) {
+ if (currentKey.indexOf(' ') < 0) {
String className = providers[i].getProperty(currentKey);
if (!classes.contains(className)) {
classes.add(className);
-------------- next part --------------
diff -r e323c74edabd src/share/classes/javax/management/MBeanPermission.java
--- a/src/share/classes/javax/management/MBeanPermission.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/management/MBeanPermission.java Tue May 27 21:48:15 2014 -0300
@@ -290,7 +290,7 @@
// Parse ObjectName
- int openingBracket = name.indexOf("[");
+ int openingBracket = name.indexOf('[');
if (openingBracket == -1) {
// If "[on]" missing then ObjectName("*:*")
//
@@ -329,7 +329,7 @@
// Parse member
- int poundSign = name.indexOf("#");
+ int poundSign = name.indexOf('#');
if (poundSign == -1)
setMember("*");
diff -r e323c74edabd src/share/classes/javax/management/modelmbean/DescriptorSupport.java
--- a/src/share/classes/javax/management/modelmbean/DescriptorSupport.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/management/modelmbean/DescriptorSupport.java Tue May 27 21:48:15 2014 -0300
@@ -329,7 +329,7 @@
inFld = false;
} else if (inFld && inDesc) {
// want kw=value, eg, name="myname" value="myvalue"
- int eq_separator = tok.indexOf("=");
+ int eq_separator = tok.indexOf('=');
if (eq_separator > 0) {
String kwPart = tok.substring(0,eq_separator);
String valPart = tok.substring(eq_separator+1);
@@ -458,7 +458,7 @@
if ((fields[i] == null) || (fields[i].equals(""))) {
continue;
}
- int eq_separator = fields[i].indexOf("=");
+ int eq_separator = fields[i].indexOf('=');
if (eq_separator < 0) {
// illegal if no = or is first character
if (MODELMBEAN_LOGGER.isLoggable(Level.FINEST)) {
diff -r e323c74edabd src/share/classes/javax/management/modelmbean/RequiredModelMBean.java
--- a/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java Tue May 27 21:48:15 2014 -0300
@@ -934,7 +934,7 @@
String opMethodName;
// Parse for class name and method
- int opSplitter = opName.lastIndexOf(".");
+ int opSplitter = opName.lastIndexOf('.');
if (opSplitter > 0) {
opClassName = opName.substring(0,opSplitter);
opMethodName = opName.substring(opSplitter+1);
@@ -943,7 +943,7 @@
/* Ignore anything after a left paren. We keep this for
compatibility but it isn't specified. */
- opSplitter = opMethodName.indexOf("(");
+ opSplitter = opMethodName.indexOf('(');
if (opSplitter > 0)
opMethodName = opMethodName.substring(0,opSplitter);
-------------- next part --------------
diff -r e323c74edabd src/share/classes/java/util/PropertyPermission.java
--- a/src/share/classes/java/util/PropertyPermission.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/util/PropertyPermission.java Tue May 27 21:48:05 2014 -0300
@@ -547,7 +547,7 @@
offset = name.length()-1;
- while ((last = name.lastIndexOf(".", offset)) != -1) {
+ while ((last = name.lastIndexOf('.', offset)) != -1) {
name = name.substring(0, last+1) + "*";
//System.out.println("check "+name);
diff -r e323c74edabd src/share/classes/java/util/jar/JarVerifier.java
--- a/src/share/classes/java/util/jar/JarVerifier.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/util/jar/JarVerifier.java Tue May 27 21:48:05 2014 -0300
@@ -278,7 +278,7 @@
// now we are parsing a signature block file
- String key = uname.substring(0, uname.lastIndexOf("."));
+ String key = uname.substring(0, uname.lastIndexOf('.'));
if (signerCache == null)
signerCache = new ArrayList<>();
diff -r e323c74edabd src/share/classes/java/util/logging/LogManager.java
--- a/src/share/classes/java/util/logging/LogManager.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/util/logging/LogManager.java Tue May 27 21:48:05 2014 -0300
@@ -866,7 +866,7 @@
int ix = 1;
for (;;) {
- int ix2 = name.indexOf(".", ix);
+ int ix2 = name.indexOf('.', ix);
if (ix2 < 0) {
break;
}
@@ -889,7 +889,7 @@
}
LogNode node = root;
while (name.length() > 0) {
- int ix = name.indexOf(".");
+ int ix = name.indexOf('.');
String head;
if (ix > 0) {
head = name.substring(0, ix);
diff -r e323c74edabd src/share/classes/java/util/logging/XMLFormatter.java
--- a/src/share/classes/java/util/logging/XMLFormatter.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/util/logging/XMLFormatter.java Tue May 27 21:48:05 2014 -0300
@@ -174,7 +174,7 @@
// Check to see if the parameter was not a messagetext format
// or was not null or empty
if ( parameters != null && parameters.length != 0
- && record.getMessage().indexOf("{") == -1 ) {
+ && record.getMessage().indexOf('{') == -1 ) {
for (int i = 0; i < parameters.length; i++) {
sb.append(" <param>");
try {
-------------- next part --------------
diff -r e323c74edabd src/share/classes/java/security/BasicPermission.java
--- a/src/share/classes/java/security/BasicPermission.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/security/BasicPermission.java Tue May 27 21:48:05 2014 -0300
@@ -430,7 +430,7 @@
offset = path.length()-1;
- while ((last = path.lastIndexOf(".", offset)) != -1) {
+ while ((last = path.lastIndexOf('.', offset)) != -1) {
path = path.substring(0, last+1) + "*";
//System.out.println("check "+path);
diff -r e323c74edabd src/share/classes/java/security/Provider.java
--- a/src/share/classes/java/security/Provider.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/security/Provider.java Tue May 27 21:48:05 2014 -0300
@@ -927,7 +927,7 @@
}
private String[] getTypeAndAlgorithm(String key) {
- int i = key.indexOf(".");
+ int i = key.indexOf('.');
if (i < 1) {
if (debug != null) {
debug.println("Ignoring invalid entry in provider "
diff -r e323c74edabd src/share/classes/java/security/Security.java
--- a/src/share/classes/java/security/Security.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/security/Security.java Tue May 27 21:48:05 2014 -0300
@@ -1114,7 +1114,7 @@
// implementation of an algorithm. We are only interested
// in entries which lead to the implementation
// classes.
- if (currentKey.indexOf(" ") < 0) {
+ if (currentKey.indexOf(' ') < 0) {
result.add(currentKey.substring(
serviceName.length() + 1));
}
-------------- next part --------------
diff -r e323c74edabd src/share/classes/java/net/CookieManager.java
--- a/src/share/classes/java/net/CookieManager.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/net/CookieManager.java Tue May 27 21:48:05 2014 -0300
@@ -294,7 +294,7 @@
// the path is the directory of the page/doc
String path = uri.getPath();
if (!path.endsWith("/")) {
- int i = path.lastIndexOf("/");
+ int i = path.lastIndexOf('/');
if (i > 0) {
path = path.substring(0, i + 1);
} else {
@@ -364,7 +364,7 @@
static private boolean isInPortList(String lst, int port) {
- int i = lst.indexOf(",");
+ int i = lst.indexOf(',');
int val = -1;
while (i > 0) {
try {
@@ -375,7 +375,7 @@
} catch (NumberFormatException numberFormatException) {
}
lst = lst.substring(i+1);
- i = lst.indexOf(",");
+ i = lst.indexOf(',');
}
if (!lst.isEmpty()) {
try {
diff -r e323c74edabd src/share/classes/java/net/InetAddress.java
--- a/src/share/classes/java/net/InetAddress.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/net/InetAddress.java Tue May 27 21:48:05 2014 -0300
@@ -1138,7 +1138,7 @@
// This is supposed to be an IPv6 literal
// Check if a numeric or string zone id is present
int pos;
- if ((pos=host.indexOf ("%")) != -1) {
+ if ((pos=host.indexOf ('%')) != -1) {
numericZone = checkNumericZone (host);
if (numericZone == -1) { /* remainder of string must be an ifname */
ifname = host.substring (pos+1);
diff -r e323c74edabd src/share/classes/java/net/SocketPermission.java
--- a/src/share/classes/java/net/SocketPermission.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/net/SocketPermission.java Tue May 27 21:48:05 2014 -0300
@@ -777,7 +777,7 @@
// Literal IPv6 address
host = getName().substring(1, getName().indexOf(']'));
} else {
- int i = getName().indexOf(":");
+ int i = getName().indexOf(':');
if (i == -1)
host = getName();
else {
diff -r e323c74edabd src/share/classes/java/net/SocksSocketImpl.java
--- a/src/share/classes/java/net/SocksSocketImpl.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/net/SocksSocketImpl.java Tue May 27 21:48:05 2014 -0300
@@ -368,7 +368,7 @@
String host = epoint.getHostString();
// IPv6 litteral?
if (epoint.getAddress() instanceof Inet6Address &&
- (!host.startsWith("[")) && (host.indexOf(":") >= 0)) {
+ (!host.startsWith("[")) && (host.indexOf(':') >= 0)) {
host = "[" + host + "]";
}
try {
@@ -684,7 +684,7 @@
String host = saddr.getHostString();
// IPv6 litteral?
if (saddr.getAddress() instanceof Inet6Address &&
- (!host.startsWith("[")) && (host.indexOf(":") >= 0)) {
+ (!host.startsWith("[")) && (host.indexOf(':') >= 0)) {
host = "[" + host + "]";
}
try {
diff -r e323c74edabd src/share/classes/java/net/URI.java
--- a/src/share/classes/java/net/URI.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/net/URI.java Tue May 27 21:48:05 2014 -0300
@@ -1851,9 +1851,9 @@
sb.append("//");
if (authority.startsWith("[")) {
// authority should (but may not) contain an embedded IPv6 address
- int end = authority.indexOf("]");
+ int end = authority.indexOf(']');
String doquote = authority, dontquote = "";
- if (end != -1 && authority.indexOf(":") != -1) {
+ if (end != -1 && authority.indexOf(':') != -1) {
// the authority contains an IPv6 address
if (end == authority.length()) {
dontquote = authority;
@@ -1889,8 +1889,8 @@
* because we must not quote a literal IPv6 address
*/
if (opaquePart.startsWith("//[")) {
- int end = opaquePart.indexOf("]");
- if (end != -1 && opaquePart.indexOf(":")!=-1) {
+ int end = opaquePart.indexOf(']');
+ if (end != -1 && opaquePart.indexOf(':')!=-1) {
String doquote, dontquote;
if (end == opaquePart.length()) {
dontquote = opaquePart;
-------------- next part --------------
diff -r e323c74edabd src/share/classes/java/lang/Class.java
--- a/src/share/classes/java/lang/Class.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/lang/Class.java Tue May 27 21:48:05 2014 -0300
@@ -1296,7 +1296,7 @@
String simpleName = getSimpleBinaryName();
if (simpleName == null) { // top level class
simpleName = getName();
- return simpleName.substring(simpleName.lastIndexOf(".")+1); // strip the package name
+ return simpleName.substring(simpleName.lastIndexOf('.')+1); // strip the package name
}
// According to JLS3 "Binary Compatibility" (13.1) the binary
// name of non-package classes (not top level) is the binary
diff -r e323c74edabd src/share/classes/java/lang/ClassLoader.java
--- a/src/share/classes/java/lang/ClassLoader.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/lang/ClassLoader.java Tue May 27 21:48:05 2014 -0300
@@ -2136,7 +2136,7 @@
return result.booleanValue();
// Check for most specific package entry
- int dotIndex = className.lastIndexOf(".");
+ int dotIndex = className.lastIndexOf('.');
if (dotIndex < 0) { // default package
result = packageAssertionStatus.get(null);
if (result != null)
@@ -2147,7 +2147,7 @@
result = packageAssertionStatus.get(className);
if (result != null)
return result.booleanValue();
- dotIndex = className.lastIndexOf(".", dotIndex-1);
+ dotIndex = className.lastIndexOf('.', dotIndex-1);
}
// Return the classloader default
diff -r e323c74edabd src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
--- a/src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Tue May 27 21:48:05 2014 -0300
@@ -84,7 +84,7 @@
private InvokerBytecodeGenerator(LambdaForm lambdaForm, int localsMapSize,
String className, String invokerName, MethodType invokerType) {
if (invokerName.contains(".")) {
- int p = invokerName.indexOf(".");
+ int p = invokerName.indexOf('.');
className = invokerName.substring(0, p);
invokerName = invokerName.substring(p+1);
}
More information about the awt-dev
mailing list