<AWT Dev> <AWT_Dev> [9] Review request for 8063102: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 1

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Nov 10 12:29:53 UTC 2014


Hi,
The fix looks fine.

On 10.11.2014 11:15, Petr Pchelko wrote:
> Hello, Yuri.
>
> As long as the classpath hack will be fixed in a separate bug, This fix looks good to me.
>
> With best regards. Petr.
>
> On 07 нояб. 2014 г., at 20:15, Yuri Nesterenko <yuri.nesterenko at oracle.com> wrote:
>
>> Colleagues,
>>
>> please review the first batch of 34 regression tests
>> modified to eliminate internal references (mostly to realSync
>> but not only). Several closed tests moved in the open.
>>
>> Change:
>> http://cr.openjdk.java.net/~yan/8063102/webrev.00
>>
>> removal diff:
>> http://cr.openjdk.java.net/~yan/8063102/webrev.diff.00
>>
>> These are (1) AWT tests; (2) mostly non-interactive: not
>> creating a Robot for automated interactions.
>>
>> This batch of tests passed (and some failed as before)
>> on three platforms.
>>
>> A change to  WarningWindowDisposeTest.java contains a hack
>> in passing of arguments to a child JVM process. We'll
>> fix that by modification of a common helper class in 8064355.
>>
>> Thanks,
>> -yan


-- 
Best regards, Sergey.



More information about the awt-dev mailing list