<AWT Dev> [9] Review Request for 8054143: move awt automated tests from AWT_Modality to OpenJDK repository - part 6

[Petr Pchelko]

Hello, Alexander.

test/java/awt/Modal/ToBack/ToBackDDFTest.java
- setModal should be volatile or final
- rightFrameOverlapsDialog: what's 7? why is it 7? I think it's better to calculate the center of the frame in case the size of window decorations will be changed in some OS version.
line 146: Here you end up calling getLocationOnScreen not on EDT, however everywhere else you try to use EDT. 

test/java/awt/Modal/ToBack/ToBackDDFTest.java
- same with setModal flag
- same with getLocationOnScreen of EDT

With best regards. Petr.

On 27 окт. 2014 г., at 14:24, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:

> Hello,
> 
> Could please anyone review this old request?
> 
> Thanks,
> Alexander
> 
> On 25.09.2014 17:06, alexander stepanov wrote:
>> Just a reminder.
>> 
>> Thanks,
>> Alexander
>> 
>> On 11.09.2014 18:29, alexander stepanov wrote:
>>> Sorry, just a reminder.
>>> 
>>> Thanks,
>>> Alexander
>>> 
>>> On 05.09.2014 17:20, alexander stepanov wrote:
>>>> Hello,
>>>> 
>>>> Could you please review the fix for
>>>> https://bugs.openjdk.java.net/browse/JDK-8054143
>>>> 
>>>> webrev:
>>>> http://cr.openjdk.java.net/~avstepan/8054143/
>>>> 
>>>> This is the next portion of functional AWT tests prepared for migration to OpenJDK repository.
>>>> 
>>>> The tests were checked on Ubuntu 14.04 Linux, Solaris 11, Windows 7, Mac OS X 10.8.5.
>>>> 
>>>> Thanks,
>>>> Alexander
>>> 
>> 
>