<AWT Dev> [9] Review Request for 8074807: Fix some tests unnecessary using internal API

Yuri Nesterenko yuri.nesterenko at oracle.com
Mon Apr 6 07:32:15 UTC 2015

On 04/03/2015 07:38 PM, Phil Race wrote:
> http://cr.openjdk.java.net/~yan/8074807/webrev.diff.00/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html.sdiff.html
> I find it very weird to add copyright 2015 just when adding the license
> header that contains the copyright !
> -phil.

Phil, note that it is 1/2 of a test.
Now consider this: in the closed code there was no copyright at all.
I'm moving the test and have to add copyright no matter what.
What should I do?
Simplest thing would be, to add 2015 and mind my own business.
Second simplest, open the bug and find "Resolved" date, and
guess it is the date, but the test is appearing in the repo now,
in 2015.
Finally, JDK code is updated every year by a script. Perhaps that
script can distinguish important change from unimportant, I don't


> On 03/17/2015 04:28 AM, Yuri Nesterenko wrote:
>> Colleagues,
>> please review this test fix to
>> https://bugs.openjdk.java.net/browse/JDK-8074807
>> Webrev:
>> http://cr.openjdk.java.net/~yan/8074807/webrev.00/
>> 5 closed tests moved to open after this change:
>> http://cr.openjdk.java.net/~yan/8074807/webrev.diff.00/
>> Resulting tests don't use internal API.
>> There is one test from javax/swing/ToolTipManager hierarchy
>> but I dare to post to AWT list only.
>> Verified on Linux, OS X, and Windows 7.
>> Thank you!
>> -yan

More information about the awt-dev mailing list