<AWT Dev> [9] Review Request: 8132382 [macosx] Crash during JMC execution

[Semyon Sadetsky]

On 8/3/2015 4:41 PM, Sergey Bylokhov wrote:
> On 31.07.15 21:34, Semyon Sadetsky wrote:
>>
>>
>> On 7/31/2015 6:28 PM, Sergey Bylokhov wrote:
>>> On 31.07.15 18:12, Semyon Sadetsky wrote:
>>>>
>>>>
>>>> On 7/31/2015 5:55 PM, Sergey Bylokhov wrote:
>>>>> On 31.07.15 17:29, Semyon Sadetsky wrote:
>>>>>> So the test could use one of these java resources inside the 
>>>>>> native app without any external libraries only using JNI library, 
>>>>>> right?
>>>>> Since we do not place a binary files to the ws, It will require an 
>>>>> xcode and comandline tools.
>>>>>
>>>>
>>>> Yes it's standard tools.
>>> It is not standard and not installed by default, like on linux for 
>>> example.
>>>> And we have binary tests in WS, for example, in DnD test suite 
>>>> there are precompiled images for each platform.
>>> And all of them are closed like sqe tests.
>> We are moving closed tests to open repo.
> We do not move the tests which have the binary files.
>>>> Functionality that is involved in native scenarios cannot be tested 
>>>> otherwise.
>>> But these scenarios already covered.
>> Then what is the existing test suite name?
> jmc, swing. and deployment was filed this weekend.
Sorry, I did not catch.
I asked for an automatic test suite which can be run on regular base for 
OpenJDK build to prevent new regressions connected to embeded JVM.
>>
>>>>
>>>>>>
>>>>>> On 7/31/2015 5:18 PM, Sergey Bylokhov wrote:
>>>>>>> On 31.07.15 16:51, Semyon Sadetsky wrote:
>>>>>>>> There are plenty classes extending CFRetainedResource, TryIcon 
>>>>>>>> for example. Will disposing them cause the same issue inside 
>>>>>>>> the native app?
>>>>>>> The crash occurs when any of these subclasses will be disposed, 
>>>>>>> in some cases app will crash immediately, in other cases the app 
>>>>>>> will crash after the objects will be gc.
>>>>>>>
>>>>>>>> On 7/31/2015 4:37 PM, Sergey Bylokhov wrote:
>>>>>>>>> Yes, it is possible if this simple native application emulate 
>>>>>>>>> initialization of these libraries.
>>>>>>>>>
>>>>>>>>> On 31.07.15 16:07, Semyon Sadetsky wrote:
>>>>>>>>>> Is it possible to reproduce the scenario using simple native 
>>>>>>>>>> application which embeds the Java VM?
>>>>>>>>>>
>>>>>>>>>> On 7/31/2015 3:37 PM, Sergey Bylokhov wrote:
>>>>>>>>>>> On 31.07.15 10:30, Semyon Sadetsky wrote:
>>>>>>>>>>>> JMC-4034 is not an OpenJDK project. Souldn't this test be 
>>>>>>>>>>>> copied to the client-libs test base?
>>>>>>>>>>>> JDK-8132469 description contains manual steps executed 
>>>>>>>>>>>> using SwingSet2, right?
>>>>>>>>>>> All sqe tests is not a part of openjdk project. These 
>>>>>>>>>>> particular tests cannot be copied to our ws because they are 
>>>>>>>>>>> depend from the external java libraries, which require some 
>>>>>>>>>>> manual configuration.
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --Semyon
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On 7/30/2015 5:55 PM, Sergey Bylokhov wrote:
>>>>>>>>>>>>> Hi, Semyon.
>>>>>>>>>>>>> There are two tests which failed, see JMC-4034( 
>>>>>>>>>>>>> jmc_plugintest/swt case) and JDK-8132469(swingnode/fx case).
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 30.07.15 9:49, Semyon Sadetsky wrote:
>>>>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> You've marked the bug as noreg-sqe. I could not find the 
>>>>>>>>>>>>>> existing test that crashes during the bug scenario. Could 
>>>>>>>>>>>>>> add this info?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --Semyon
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 7/29/2015 6:51 PM, Sergey Bylokhov wrote:
>>>>>>>>>>>>>>> Hello.
>>>>>>>>>>>>>>> Please review the fix for jdk9.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> In the fix 8068886[1] the new native resources 
>>>>>>>>>>>>>>> deallocation code assumes that we have a full control 
>>>>>>>>>>>>>>> over the Cocoa NSApplication. This is incorrect in case 
>>>>>>>>>>>>>>> of embedding, when NSApplication is controlled by swt or 
>>>>>>>>>>>>>>> fx libraries. In the fix I add an additional check that 
>>>>>>>>>>>>>>> the necessary selector exists in the current NSApp.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> [1] 
>>>>>>>>>>>>>>> http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/b26427c5b3fe
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132382
>>>>>>>>>>>>>>> Webrev can be found at: 
>>>>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8132382/webrev.02
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> -- 
>>>>>>>>>>>>> Best regards, Sergey.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> -- 
>>>>>>>>>>> Best regards, Sergey.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -- 
>>>>>>>>> Best regards, Sergey.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> -- 
>>>>>>> Best regards, Sergey.
>>>>>>
>>>>>
>>>>>
>>>>> -- 
>>>>> Best regards, Sergey.
>>>>
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>
>
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150804/e28cd4c8/attachment-0001.html>