<AWT Dev> [9] Review Request for 8132958: [TEST_BUG] Part 1: update client tests failing after changes in setAccessible(true) routine

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Aug 13 10:15:32 UTC 2015


+1

On 13.08.15 13:07, Alexander Scherbatiy wrote:
>
>   The fix looks good to me.
>
>   Thanks,
>   Alexandr.
>
> On 8/13/2015 10:54 AM, Yuri Nesterenko wrote:
>> Please see the second version:
>> http://cr.openjdk.java.net/~yan/8132958/webrev.01/
>> Test test/java/awt/image/MultiResolutionImageTest.java removed from 
>> the fix.
>>
>> Reference webrev about a moved test is unchanged:
>> http://cr.openjdk.java.net/~yan/8132958/webrev.diff.00/
>>
>> Thanks,
>> -yan
>>
>> On 08/12/2015 06:33 PM, Alexander Scherbatiy wrote:
>>>
>>>   The test/java/awt/image/MultiResolutionImageTest.java has part which
>>> can be run on all platforms.
>>>
>>>   There is the specific check for Mac OS X dependent part. It looks 
>>> like
>>> the test does not need to have the @requires mac tag.
>>>
>>>   Thanks,
>>>   Alexandr.
>>>
>>> On 8/12/2015 4:29 PM, Yuri Nesterenko wrote:
>>>> Colleagues,
>>>>
>>>> please review this test-only fix.
>>>> Some tests would need more elaborate permissions now to access
>>>> the private methods of internal classes.
>>>>
>>>> CR is https://bugs.openjdk.java.net/browse/JDK-8132958
>>>> Webrev see in http://cr.openjdk.java.net/~yan/8132958/webrev.00/
>>>> A diff in a moved closed test is in
>>>>   http://cr.openjdk.java.net/~yan/8132958/webrev.diff.00/
>>>>
>>>> Thanks,
>>>> -yan
>>>
>>
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list