<AWT Dev> RfR JDK-8055160

Mandy Chung mandy.chung at oracle.com
Wed Jun 10 23:29:33 UTC 2015

> On Jun 10, 2015, at 3:33 PM, Pete Brunet <peter.brunet at oracle.com> wrote:
> Due to some other priorities it's been over 2 months since the last webrev.  An update is here:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03

   You can use try-with-resource
    try (PrintWriter writer = new PrintWriter("BarProvider.txt”)) {
    } catch (IOException e) {
         throw new UncheckedException(e);

That will close the writer.  I think you should rethow IOException instead of swallowing it.

Same comment to other provider implementation.

   The test should clean up all files before starting loading the providers since someone may run the test standalone multiple times on the same directory.

Otherwise looks good to me.

make/Images.gmk needs fixing as I mentioned earlier.


More information about the awt-dev mailing list