<AWT Dev> [9] Review Request: 8078658 Make custom Cursors available for modular build

Chris Hegarty chris.hegarty at oracle.com
Wed Jun 17 18:05:31 UTC 2015

On 17 Jun 2015, at 18:58, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 17/06/2015 18:47, Sergey Bylokhov wrote:
>> On 27.05.15 19:03, Sergey Bylokhov wrote:
>>> Hi, Alan.
>>> On 27.05.15 18:51, Alan Bateman wrote:
>>>> A minor comment on the usage of ByteArrayOutputStream is that you should be able to replace this soon with:
>>>>    Image image = toolkit.createImage( in.readAllBytes() );
>>>> The readAllBytes method is currently in review on core-libs-dev.
>>> Thanks for this suggestion. I'll postpone the fix a little bit.
>> Here is the new version of the fix:
>> http://cr.openjdk.java.net/~serb/8078658/webrev.01/src/java.desktop/share/classes/java/awt/Cursor.java.sdiff.html 
>> The new method is used.
> Using readAllBytes looks good to me.

Yes, this looks good to me too. Nice to see this new API in action ;-)


> -Alan

More information about the awt-dev mailing list