<AWT Dev> RfR JDK-8055160

Mandy Chung mandy.chung at oracle.com
Tue Mar 17 01:14:19 UTC 2015

On 3/16/2015 1:52 PM, Pete Brunet wrote:
> The following patch to accessibility related code is for the modularity
> effort.
> http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.00/

    line 799-804: this can simply be replaced with
    Class<?> clazz = Class.forName(atName, false, cl);

    line 886-892: can be shortened to just:
    If the requested name matches the {@linkplain
    javax.accessibility.AccessibilitySPI#name name of the service provider},
    the {@linkplain javax.accessibility.AccessibilitySPI#activate activate}
    method will be invoked to activate the matching service provider.

    I think the statement "The service providers has two methods..." is
    not needed.
    line 894: @implSpec would apply [1] here as it's the implementation
    specification. I think line 896 can say this implementation will
    look at a properties file.... IMO, you can take out "fall back".

   - I sample several SPI names from javadoc and maybe AccessibilityProvider?
     Just to pass this to you if you consider it an option.
   - I think you can use @apiNote instead of @implNote there (see [1])
For the test, since you support multiple providers, perhaps good
to add one more test case to activate two providers and load two
providers but only one is activated.

[1] http://openjdk.java.net/jeps/8068562

More information about the awt-dev mailing list