<AWT Dev> [9] Review Request: JDK-8078855 [TEST_BUG] javax/swing/JComboBox/8032878/bug8032878.java fails in WindowsClassicLookAndFeel

Alexey Ivanov alexey.ivanov at oracle.com
Fri May 22 13:08:19 UTC 2015


Hi Pooja,

The fix looks good to me.

Regards,
Alexey

On 20.05.2015 20:54, pooja chopra wrote:
> Hi All,
>
> Please review the updated webrev link as per discussion with Alexey as 
> below for the fix :-
>
> Please review a fix for issue:
> 8078855 [TEST_BUG] javax/swing/JComboBox/8032878/bug8032878.java fails 
> in WindowsClassicLookAndFeel
> Test bug fix.
> https://bugs.openjdk.java.net/browse/JDK-8078855
> The webrev is : http://cr.openjdk.java.net/~pchopra/8078855/webrev.01
>
> Regards,
> Pooja
>
> On 5/5/2015 6:46 PM, Alexey Ivanov wrote:
>> Hello Pooja,
>>
>> The modified test case does not reproduce the problem reported in 
>> https://bugs.openjdk.java.net/browse/JDK-8032878. So this fix cannot 
>> be applied to the regression test.
>>
>> I confirm that the original test fails in WindowsClassicLookAndFeel 
>> because the editor selects the text, thus the typed text '123' is not 
>> added to existing text but replaces it. It could be a bug in 
>> WindowsClassicLookAndFeel or its feature. If it's not a bug, then the 
>> test should expect the value of "123" rather than "one123" where 
>> WindowsClassicLookAndFeel is used.
>>
>> Regards,
>> Alexey
>>
>> On 30.04.2015 23:39, pooja chopra wrote:
>>> Hello,
>>> Please review a fix for issue:
>>> 8078855 [TEST_BUG] javax/swing/JComboBox/8032878/bug8032878.java 
>>> fails in WindowsClassicLookAndFeel
>>> Test bug fix.
>>> https://bugs.openjdk.java.net/browse/JDK-8078855
>>> The webrev is : http://cr.openjdk.java.net/~pchopra/8078855/webrev.00/
>>>
>>> Thanks,
>>> Pooja
>>
>



More information about the awt-dev mailing list