<AWT Dev> [9] Review Request: 8078658 Make custom Cursors available for modular build

Alan Bateman Alan.Bateman at oracle.com
Wed May 27 15:51:27 UTC 2015

On 27/05/2015 14:48, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
> The usage of getResource() was changed to getResourceAsStream(). Note 
> that before the fix the toolkit.getImage() cached the image, but it 
> should not be a problem in the new code, because cursor itself is 
> cached in the Cursor.getSystemCustomCursor().
> Bug: https://bugs.openjdk.java.net/browse/JDK-8078658
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8078658/webrev.00
This looks okay to me. I assume existing tests will exercise this code well.

A minor comment on the usage of ByteArrayOutputStream is that you should 
be able to replace this soon with:
     Image image = toolkit.createImage( in.readAllBytes() );

The readAllBytes method is currently in review on core-libs-dev.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150527/4887776f/attachment.html>

More information about the awt-dev mailing list