<AWT Dev> [9] Review Request: 6815345 java.awt.Component.createImage(int width, int height) should remove behavioral optionality

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Sep 24 12:25:22 UTC 2015

On 24.09.15 11:36, Semyon Sadetsky wrote:
> Hi Sergey,
>   isHeadless()=true must return null. If so please add the corresponding
> test case. It is not not obvious from the code.

isHeadless()=true is headless mode where the frames are always not 
displayable, so everything is similar to the current test except that in 
headless the pack() will be throw an exception and second part of the 
test in this mode is unnecessary.

> --Semyon
> On 9/23/2015 9:14 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk9.
>> The specification is updated as suggested in JDK-6186530 and
>> JDK-6815345. The test is added to prove that we always return null
>> when the component is not displayable.
>> ccc request will be created after the technical review. One additional
>> bug filed https://bugs.openjdk.java.net/browse/JDK-8137047
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6815345
>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/6815345/webrev.04

Best regards, Sergey.

More information about the awt-dev mailing list