<AWT Dev> Review Request for bug JDK-8027154

Ambarish Rapte ambarish.rapte at oracle.com
Mon Apr 4 11:25:59 UTC 2016

Hi Ramesh,

                Below are few comments,

                General comments :

1.       Please provide description about bug cause & how this change fixes the bug, with the review email.
Also update the bug on JBS with similar analysis.

2.       Subject line for review email should in format,  "Review Request For BUG_ID : BUG summary line"

3.       Remove wild card import statements, @author tag &  System.out.println lines.


Comments Specific to the test:

4.       Passing null to Util.waitForIdle() creates a new robot object at each call, instead please pass the created robot object.

5.       The delay on line number 86 can be removed, Util.WaitForIdle() should be sufficient for synchronization.






From: Ramesh Gangadhar 
Sent: Friday, April 01, 2016 12:28 PM
To: awt-dev at openjdk.java.net
Subject: <AWT Dev> Review Request for bug JDK-8027154



Please review fix for Bug 8027154

bug: https://bugs.openjdk.java.net/browse/JDK-8027154

webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.01/


Best Regards,

Ramesh BG
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160404/df496f6a/attachment.html>

More information about the awt-dev mailing list