<AWT Dev> Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Ramesh Gangadhar ramesh.gangadhar at oracle.com
Tue Apr 12 09:10:35 UTC 2016



Please review bug fix for 8027154

bug: https://bugs.openjdk.java.net/browse/JDK-8027154

Webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.02/




mouseMoved(MouseEvent) recieves sometimes position as [29,29] and sometimes as [30,30] from AWT native code


What modifications Done? 

Since this testcase is mainly focused on checking mouse position instead of two Robot.mouseMove(149,149) and Robot.mouseMove(150,150) method calls it is reduced to only one call of Robot.mouseMove(150,150) and also removed creation of OuterFrame when mouseMoved on InnerFrame.



Code Tested on Windows and oracle linux for verification.


Best Regards,

Ramesh BG



From: Ambarish Rapte 
Sent: Monday, April 04, 2016 4:56 PM
To: Ramesh Gangadhar; awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> Review Request for bug JDK-8027154


Hi Ramesh,

                Below are few comments,

                General comments :

1.       Please provide description about bug cause & how this change fixes the bug, with the review email.
Also update the bug on JBS with similar analysis.

2.       Subject line for review email should in format,  "Review Request For BUG_ID : BUG summary line"

3.       Remove wild card import statements, @author tag &  System.out.println lines.


Comments Specific to the test:

4.       Passing null to Util.waitForIdle() creates a new robot object at each call, instead please pass the created robot object.

5.       The delay on line number 86 can be removed, Util.WaitForIdle() should be sufficient for synchronization.






From: Ramesh Gangadhar 
Sent: Friday, April 01, 2016 12:28 PM
To: HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: <AWT Dev> Review Request for bug JDK-8027154



Please review fix for Bug 8027154

bug: https://bugs.openjdk.java.net/browse/JDK-8027154

webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.01/


Best Regards,

Ramesh BG
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160412/467df65e/attachment.html>

More information about the awt-dev mailing list