<AWT Dev> [9] Review request for 8132706 [macosx] Toolkit.getImage() throws NPE for null URL
Alexander Scherbatiy
alexandr.scherbatiy at oracle.com
Fri Apr 15 19:13:02 UTC 2016
On 15/04/16 22:54, Sergey Bylokhov wrote:
> On 15.04.16 21:47, Alexander Scherbatiy wrote:
>> If the second option is acceptable probably the Toolkit.getImage()
>> javadoc can be updated.
>
> As far as I understand, we always throw NPE in case of SecManager, and
> throw NPE w/o secManager since 7u40/8u25?
Small correction. It started to throw NPE for the method
getImage((URL)null) but not for getImage((String)null).
Thanks,
Alexandr.
>
>
> Also please take a look to the similar bug
> https://bugs.openjdk.java.net/browse/JDK-4358053
>
>>
>> Thanks,
>> Alexandr.
>>
>>>
>>> -phil.
>>>
>>>
>>> On 04/15/2016 11:10 AM, Alexander Scherbatiy wrote:
>>>> On 15/04/16 20:30, Sergey Bylokhov wrote:
>>>>> How the object of URLImageSource(null) will be useful? I guess we
>>>>> will get some unspecified NPE exceptions if will try to call its
>>>>> methods?
>>>> I know nothing about the URLImageSource(null) usefulness but
>>>> ImageFetcher swallows the NPE during the image loading in the
>>>> fetchloop() method:
>>>> -------
>>>> try {
>>>> src.doFetch();
>>>> } catch (Exception e) {
>>>> System.err.println("Uncaught error fetching image:");
>>>> e.printStackTrace();
>>>> }
>>>> -------
>>>>
>>>> Thanks,
>>>> Alexandr.
>>>>>
>>>>> On 15.04.16 18:02, Alexander Scherbatiy wrote:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> Could you review the fix:
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8132706
>>>>>> webrev: http://cr.openjdk.java.net/~alexsch/8132706/webrev.00
>>>>>>
>>>>>> The fix makes the Toolkit.getDefaultToolkit().getImage(URL)
>>>>>> return a
>>>>>> ToolkitImage based on URLImageSource with null url as it was before
>>>>>> the
>>>>>> fix JDK-8011059.
>>>>>>
>>>>>> Thanks,
>>>>>> Alexandr.
>>>>>
>>>>>
>>>>
>>>
>>
>
>
More information about the awt-dev
mailing list