<AWT Dev> <AWT dev>[9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

Manajit Halder manajit.halder at oracle.com
Wed Apr 20 12:16:37 UTC 2016

Hi Semyon,

Thank you for the review comment. 
The test can’t be automated because of the following reasons:

On Mac OS X and Windows:
	There is no key code for the right ALT button (no right key codes for ALT, SHIFT, COMMAND).	robot.keyPress(KeyEvent.VK_ALT) will press the left ALT key.
	It is not possible to press the right ALT key using robot. 
	Hence Alt-Gr modifier won’t be set using robot.

On Linux:
	The Alt graph is configurable.


> On 12-Apr-2016, at 9:07 pm, Semyon Sadetsky <semyon.sadetsky at oracle.com> wrote:
> Hi Manajit,
> The fix itself is OK. 
> Why the test cannot be automated?
> --Semyon
> On 4/12/2016 1:46 PM, Manajit Halder wrote:
>> Hi All,
>> Gentle remainder. Please review the changes.
>> Thanks,
>> Manajit
>>> On 07-Apr-2016, at 1:48 pm, Manajit Halder <manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>> wrote:
>>> Hi All,
>>> Kindly review the fix for JDK9.
>>> Bug: 
>>>  	 <https://bugs.openjdk.java.net/browse/JDK-8151136>https://bugs.openjdk.java.net/browse/JDK-8151136 <https://bugs.openjdk.java.net/browse/JDK-8151136>
>>> Webrev: 
>>> 	http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/ <http://cr.openjdk.java.net/%7Earapte/manajit/8151136/webrev.00/>
>>> Issue: 
>>> [macosx] According to the description,the case is failed (AltGraph key is not supported on OS X).
>>> Cause: 
>>> 	On OS X AltGraph functionality was not implemented. 
>>> Information on AltGraph Key on OS X:
>>> 	On OS X there is no key defined for AltGraph on the Keyboard. As per wikipedia link https://en.wikipedia.org/wiki/AltGr_key <https://en.wikipedia.org/wiki/AltGr_key> Option key has function similar to the AltGr key. But Option is also Alt key on OS X. 
>>> Fix: 
>>> 	Right Option key is defined to behave as AltGraph key on OS X. AltGraph functionality is added for left key. 
>>> Regards,
>>> Manajit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160420/1c9a7f9e/attachment.html>

More information about the awt-dev mailing list