<AWT Dev> RFR: 8047931: Remove unused medialib code
philip.race at oracle.com
Mon Apr 25 16:00:41 UTC 2016
This review is on the wrong list. Medialib is unrelated to awt.
It is 2D only .. please discard this thread and start again on 2d-dev.
On 04/25/2016 03:50 AM, Vadim Pakhnushev wrote:
> Hi all,
> Please review this cleanup fix:
> While investigating unused files in the sparc build, it was found that
> there are a lot of unused code in the medialib.
> So without further ado, here's the whopping 35000 lines removal webrev:
> At least on Windows, it reduced the size of the mlib_image.dll by
> almost 180KB from 663KB to 486KB and shortened the build by 3 minutes
> on my i5.
> It was tested with the JPRT build on all platforms.
> Some notes in order of the files in the webrev:
> Deleted removed files from the sparc exclude list.
> Main entry point mlib_ImageAffine always pass NULL as a colormap to
> the mlib_ImageAffine_alltypes.
> This is basically a starting point for the majority of removal which
> leads to removal of colormap parameters of several other functions and
> elimination of several if (colormap != NULL) blocks.
> Which in turn leads to removal of function pointer arrays such as
> mlib_AffineFunArr_bl_i and mlib_AffineFunArr_bc_i.
> Removed colormap parameters and related declarations.
> Removed parts of the code in the mlib_ImageAffineEdge* functions
> related to the colormaps.
> Removed 2x2 through 7x7 convolution functions as we only use NxM ones.
> Basically removed all functions with a colormap parameter.
> Removed sparc implementations of unused mlib_ImageAffine* functions.
More information about the awt-dev