<AWT Dev> [9] Review request for 8171952: [macosx] AWT_Modality/Automated/ModalExclusion/NoExclusion/ModelessDialog test fails as DummyButton on Dialog did not gain focus when clicked.

Dmitry Markov dmitry.markov at oracle.com
Thu Dec 29 14:47:36 UTC 2016


Thank you for review, Sergey!
Looking for the second +1 from someone else.

Thanks in advance,
Dmitry
> On 29 Dec 2016, at 20:02, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Looks fine.
> 
>> 
>> Hello,
>> 
>> Could you review a fix for jdk9, please?
>> 
>> 	bug: https://bugs.openjdk.java.net/browse/JDK-8171952 <https://bugs.openjdk.java.net/browse/JDK-8171952>
>> 	webrev: http://cr.openjdk.java.net/~dmarkov/8171952/webrev.00/ <http://cr.openjdk.java.net/~dmarkov/8171952/webrev.00/>
>> 
>> Problem description:
>> LWCToolkit.getPlatformWindowUnderMouse() looks for a window only at normal window level/layer, (i.e. NSNormalWindowLevel). However after integration of JDK-8080729 the child windows of focused window are placed to floating level, (i.e. NSFloatingWindowLevel).
>> So the following situation may take place: the window is in focused state and obscured by its child dialog, but the current implementation of getPlatformWindowUnderMouse() reports that the window is under mouse.
>> 
>> Fix:
>> getPlatformWindowUnderMouse() should look at all possible window levels/layers during retrieval of the topmost window under mouse.
>> 
>> Thanks,
>> Dmitry
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20161229/bd68f40c/attachment-0001.html>


More information about the awt-dev mailing list