<AWT Dev> Review request for 8147834: [macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0

Manajit Halder manajit.halder at oracle.com
Fri Feb 12 12:37:59 UTC 2016

Hi All,

Kindly review the fix for JDK9.

https://bugs.openjdk.java.net/browse/JDK-8147834 <https://bugs.openjdk.java.net/browse/JDK-8147834>

http://cr.openjdk.java.net/~mhalder/8147834/webrev.00 <http://cr.openjdk.java.net/~mhalder/8147834/webrev.00>

[macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0.

Added the key codes for function keys F17, F18 and F19 on the MacOS X side. The values of the keys were referred from following file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h on MacOS X. Fix is also added for function key F20 because F20 key is valid in Java and MacOS X the and need to be supported on MacOS. But this key can’t be tested with the normal USB keyboard because it has function key till F19. 	 

Justification of fix:
Key codes of the keys F17, F18, F19 and F20 were not added on the MacOS X side. Fix for key F20 is added because the key should be supported as per the java documentation and the key is a valid function key on MacOS X.

Testing the fix: 
The fix was tested manually using the code present in the description. The automated test case is not ready. While writing the test case it was found that robot.keyPress is failing for function keys F13 to F19 (also will fail for F20). An issue is created for the same problem with jira id https://bugs.openjdk.java.net/browse/JDK-8149456 <https://bugs.openjdk.java.net/browse/JDK-8149456>.

aAutomated test case will be provided in future after fixing issue https://bugs.openjdk.java.net/browse/JDK-8149456 <https://bugs.openjdk.java.net/browse/JDK-8149456>.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160212/7913c3ce/attachment.html>

More information about the awt-dev mailing list