<AWT Dev>  Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11
Sergey.Bylokhov at oracle.com
Wed Feb 24 17:32:20 UTC 2016
On 11.02.16 8:52, Avik Niyogi wrote:
> Here is my two cents:
> * As of Xcode 7, Rich Text Font Document attributes have to be
> mentioned explicitly and not with a nil.
> I can see that to mitigate the warning an empty array is placed
> there. The system is able to still process RTF document with this.
> Ideally, the parameter to be passed for the document attribute as
> per my understanding is
> at line numbers 627 and 684 AWTView.m
> Please refer to the below link for further clarification regarding
> values to be passed (like NULL instead of nil):
Fixed. But I wonder why "RTFDFromRange" have this in the documentation:
"If there are no document-level attributes, dict can be nil."
> * *performFileOperation* at line 224 is deprecated in OSX10.11.
> *recycleURLs:completionHandler:* should be used instead as far as it
> is possible (until a good substitute for performFileOperation is
Unfortunately we cannot use recycleURLs, since it is asynchronous. I
found another possible solution NSFileManager.trashItemAtURL():
> With Regards,
> Avik Niyogi
>> On 10-Feb-2016, at 11:46 pm, Chris Bensen <chris.bensen at oracle.com
>> <mailto:chris.bensen at oracle.com>> wrote:
>>> On Feb 10, 2016, at 9:16 AM, David DeHaven <david.dehaven at oracle.com
>>> <mailto:david.dehaven at oracle.com>> wrote:
>>>> Please review one more iteration of the fix of warnings in awt on osx.
>>>> The fix was contributed by Chris Bensen.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141553
>>>> Webrev can be found at:
>>> Thanks for doing this! I'm not a (R)eviewer, but I've been using
>>> these changes for some time now with no ill effects.
Best regards, Sergey.
More information about the awt-dev