<AWT Dev> Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

Vikrant Agarwal vikrant.v.agarwal at oracle.com
Thu Mar 3 04:54:43 UTC 2016


Friendly reminder. Please review this fix.

Webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.02/

Bug: https://bugs.openjdk.java.net/browse/JDK-6734341

Best Regards,
Vikrant

-----Original Message-----
From: Sergey Bylokhov 
Sent: Friday, February 26, 2016 6:51 PM
To: Vikrant Agarwal; awt-dev at openjdk.java.net; Alexander Scherbatiy; Semyon Sadetsky
Subject: Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

Looks fine.

On 26.02.16 15:53, Vikrant Agarwal wrote:
> Hi Sergey,
>
> I have updated the test to a standalone test.
>
> Updated Webrev: 
> http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.02/
>
> Bug: JDK-6734341 : REGTEST fails: SelectionAutoscrollTest.html
>
> Best Regards,
> Vikrant
>
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Thursday, February 25, 2016 2:03 AM
> To: Vikrant Agarwal; awt-dev at openjdk.java.net; Alexander Scherbatiy; 
> Semyon Sadetsky
> Subject: Re: Review request for 6734341 : REGTEST fails: 
> SelectionAutoscrollTest.html
>
> Hi, Vikrant.
> The @bug tag should be updated in the html file, because it have a @test tag. But I suggest to remove the html file and change SelectionAutoscrollTest.java to a standalone test(instead of Applet).
>
> On 24.02.16 11:25, Vikrant Agarwal wrote:
>> Hi All,
>>
>> Please review the fix for JDK9.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6734341
>>
>> Webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.00/
>>
>> Issue:  java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest  
>> test was always failing for mac and intermittently failing for other platforms.
>>
>> Fix: using mouseMove() from test.java.awt.regtesthelpers.Util insted 
>> of
>> mouseMove() from java.awt.Robot makes the test more stable and the 
>> test passes on all the tested machines including mac.
>>
>> Best Regards,
>>
>> Vikrant
>>
>
>
> --
> Best regards, Sergey.
>


--
Best regards, Sergey.


More information about the awt-dev mailing list