<AWT Dev> [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed May 11 21:55:33 UTC 2016


On 12/05/16 01:50, Phil Race wrote:
> Alexander ... I am concurrently deleting GThreadHelper (see webrev I 
> just sent out)
>  which is covered by a separate bug so please revert that part of the 
> fix.

   Sorry. Here is the updated fix where only SoftCache is moved to the 
java.desktop module and the test ReferrersTest is updated.
     http://cr.openjdk.java.net/~alexsch/8154539/webrev.02/

   Thanks,
   Alexandr.
>
> -phil.
>
> On 5/11/2016 2:43 PM, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the updated fix:
>>   http://cr.openjdk.java.net/~alexsch/8154539/webrev.01
>>
>>   - The test/com/sun/jdi/ReferrersTest.java test is updated to use 
>> sun.awt.SoftCache
>>   - The sun.misc.GThreadHelper class is moved to the sun.awt package 
>> in the java.desktop module
>>
>>   The jdk.unsupported dependency was removed from the 
>> src/java.desktop/share/classes/module-info.java file.
>>   The sun.misc.GThreadHelper class is called by JNI and may be it 
>> does not require the declared dependency to the jdk.unsupported 
>> module. In any case it seems better to move the GThreadHelper class 
>> to the java.desktop module.
>>
>>   Thanks,
>>   Alexandr.
>>
>>
>> On 12/05/16 00:15, Mandy Chung wrote:
>>>> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy 
>>>> <alexandr.scherbatiy at oracle.com> wrote:
>>>>
>>>>
>>>> Hello,
>>>>
>>>> Could you review the fix:
>>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8154539
>>>>   webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00
>>>>
>>>>   This is a request from the jigsaw team to get rid of the 
>>>> dependency to jdk.unsupported module from the java.desktop module.
>>>>   The fix moves the sun.misc.SoftCache class to the sun.awt package 
>>>> in the java.desktop module.
>>> Looks okay.  Moving sun.misc.SoftCache to java.desktop is fine.
>>>
>>> test/com/sun/jdi/ReferrersTest.java references sun.misc.SoftCache.  
>>> I don’t know whether this test finds sun.misc.SoftCache in the 
>>> reference graph at all.  I suggest to update the test to check 
>>> “sun.awt.SoftCache” instead and file a bug to the serviceability to 
>>> follow up if that check is needed or not.
>>>
>>> Mandy
>>
>



More information about the awt-dev mailing list