<AWT Dev> [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

[Phil Race]

So are you saying we will never call this from the Toolkit thread, so 
provably
there will never be an NPE ?

Seems we have had a ton of NPE bugs from getAppContext() returning null
so I am not so confident about that.

-phil.

On 11/15/2016 10:44 AM, Sergey Bylokhov wrote:
> I guess this should be closed as not a defect. getAppContext() can 
> return null if it will be called from the toolkit thread. If this 
> method is called by the user then appcontext should not be null, 
> additionally we should not cache this value in the static, so all 
> other code will use this cached static value.
>
> On 15.11.16 20:38, Phil Race wrote:
>>
>> +1
>>
>> -phil.
>>
>> On 11/15/2016 08:24 AM, Alexander Zvegintsev wrote:
>>> Hello,
>>>
>>> please review the fix
>>>
>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8151189/00/
>>>
>>> for the issue
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8151189
>>>
>>
>
>