<AWT Dev> [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

Sergey Malenkov malenkov at gmail.com
Mon Nov 28 15:01:02 UTC 2016

The fix looks good, but we realized that the direction is not always changed.
For example, Windows from VirtualBox on Mac.

-    jint scrollLines = 3;
+    jint toScroll = 3;

-    UINT platformLines;
+    UINT platformUnits;

Also I prefer to use similar names for this variables as before.
For example, scrollUnits instead of toScroll

On Thu, Nov 24, 2016 at 4:32 PM, Alexandr Scherbatiy
<alexandr.scherbatiy at oracle.com> wrote:
> The fix looks good to me.
> Thanks,
> Alexandr.
> On 11/23/2016 5:20 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk9.
>> Support of WM_MOUSEHWHEEL for Swing was added (AWT components were not
>> touched), which mostly the code symmetric to the WM_MOUSEWHEEL, except that
>> I changed the direction to align it in Swing and OS. It seems that this
>> functionality does not work on linux as well, at least I was not able to
>> enable it. Will file a separate bug for jdk on linux.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-4419271
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/4419271/webrev.02

Best regards,
Sergey A. Malenkov

More information about the awt-dev mailing list